IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Various code cleanup [skip ci]

Browse Source
This commit is contained in:
James Cole
2018-03-10 22:38:20 +01:00
parent a55d18709c
commit aad0864018
59 changed files with 118 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Services/Internal/Destroy/AccountDestroyService.php
View File

@@ -63,7 +63,7 @@ class AccountDestroyService
try {
$account->delete();
} catch (Exception $e) { // @codeCoverageIgnore
Log::error(sprintf('Could not delete account: %s',$e->getMessage())); // @codeCoverageIgnore
Log::error(sprintf('Could not delete account: %s', $e->getMessage())); // @codeCoverageIgnore
}
return true;

3
app/Services/Internal/Destroy/BillDestroyService.php
View File

@@ -26,6 +26,7 @@ namespace FireflyIII\Services\Internal\Destroy;
use Exception;
use FireflyIII\Models\Bill;
use Log;
/**
* @codeCoverageIgnore
* Class BillDestroyService
@@ -40,7 +41,7 @@ class BillDestroyService
try {
$bill->delete();
} catch (Exception $e) { // @codeCoverageIgnore
Log::error(sprintf('Could not delete bill: %s',$e->getMessage())); // @codeCoverageIgnore
Log::error(sprintf('Could not delete bill: %s', $e->getMessage())); // @codeCoverageIgnore
}
}

2
app/Services/Internal/Destroy/JournalDestroyService.php
View File

@@ -56,7 +56,7 @@ class JournalDestroyService
}
$journal->delete();
} catch (Exception $e) {
Log::error(sprintf('Could not delete bill: %s',$e->getMessage())); // @codeCoverageIgnore
Log::error(sprintf('Could not delete bill: %s', $e->getMessage())); // @codeCoverageIgnore
}
return;

2
app/Services/Internal/Support/AccountServiceTrait.php
View File

@@ -23,7 +23,6 @@ declare(strict_types=1);
namespace FireflyIII\Services\Internal\Support;
use Exception;
use FireflyIII\Factory\AccountFactory;
use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Factory\TransactionFactory;
@@ -255,6 +254,7 @@ trait AccountServiceTrait
return true;
}
return true; // @codeCoverageIgnore
}

1
app/Services/Internal/Support/BillServiceTrait.php
View File

@@ -22,6 +22,7 @@
declare(strict_types=1);
namespace FireflyIII\Services\Internal\Support;
use FireflyIII\Models\Bill;
use FireflyIII\Models\Note;

3
app/Services/Internal/Support/TransactionServiceTrait.php
View File

@@ -217,6 +217,7 @@ trait TransactionServiceTrait
{
if (is_null($budget)) {
$transaction->budgets()->sync([]);
return;
}
$transaction->budgets()->sync([$budget->id]);
@@ -233,6 +234,7 @@ trait TransactionServiceTrait
{
if (is_null($category)) {
$transaction->categories()->sync([]);
return;
}
$transaction->categories()->sync([$category->id]);
@@ -260,6 +262,7 @@ trait TransactionServiceTrait
if (is_null($currency)) {
$transaction->foreign_currency_id = null;
$transaction->save();
return;
}
$transaction->foreign_currency_id = $currency->id;

7
app/Services/Internal/Update/AccountUpdateService.php
View File

@@ -23,14 +23,8 @@ declare(strict_types=1);
namespace FireflyIII\Services\Internal\Update;
use Exception;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Factory\AccountMetaFactory;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountMeta;
use FireflyIII\Models\AccountType;
use FireflyIII\Services\Internal\Support\AccountServiceTrait;
use Log;
/**
* Class AccountUpdateService
@@ -40,7 +34,6 @@ class AccountUpdateService
use AccountServiceTrait;
/**
* Update account data.
*