mirror of
https://github.com/firefly-iii/firefly-iii.git
synced 2025-02-25 18:45:27 -06:00
Some code cleanup
Signed-off-by: James Cole <thegrumpydictator@gmail.com>
This commit is contained in:
parent
114dd5fc2a
commit
ababdacf89
@ -21,11 +21,10 @@ use Illuminate\Support\Collection;
|
|||||||
*/
|
*/
|
||||||
class BasicCollector
|
class BasicCollector
|
||||||
{
|
{
|
||||||
/** @var Collection */
|
|
||||||
private $files;
|
|
||||||
|
|
||||||
/** @var ExportJob */
|
/** @var ExportJob */
|
||||||
protected $job;
|
protected $job;
|
||||||
|
/** @var Collection */
|
||||||
|
private $files;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* BasicCollector constructor.
|
* BasicCollector constructor.
|
||||||
|
@ -9,6 +9,7 @@ declare(strict_types = 1);
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
namespace FireflyIII\Export\Collector;
|
namespace FireflyIII\Export\Collector;
|
||||||
|
|
||||||
use Illuminate\Support\Collection;
|
use Illuminate\Support\Collection;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@ -18,16 +19,16 @@ use Illuminate\Support\Collection;
|
|||||||
*/
|
*/
|
||||||
interface CollectorInterface
|
interface CollectorInterface
|
||||||
{
|
{
|
||||||
/**
|
|
||||||
* @return bool
|
|
||||||
*/
|
|
||||||
public function run();
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @return Collection
|
* @return Collection
|
||||||
*/
|
*/
|
||||||
public function getFiles();
|
public function getFiles();
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return bool
|
||||||
|
*/
|
||||||
|
public function run();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @param Collection $files
|
* @param Collection $files
|
||||||
*
|
*
|
||||||
|
@ -21,10 +21,9 @@ use Illuminate\Support\Collection;
|
|||||||
*/
|
*/
|
||||||
class BasicExporter
|
class BasicExporter
|
||||||
{
|
{
|
||||||
private $entries;
|
|
||||||
|
|
||||||
/** @var ExportJob */
|
/** @var ExportJob */
|
||||||
protected $job;
|
protected $job;
|
||||||
|
private $entries;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* BasicExporter constructor.
|
* BasicExporter constructor.
|
||||||
@ -54,5 +53,4 @@ class BasicExporter
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
}
|
}
|
||||||
|
@ -9,6 +9,7 @@ declare(strict_types = 1);
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
namespace FireflyIII\Export\Exporter;
|
namespace FireflyIII\Export\Exporter;
|
||||||
|
|
||||||
use Illuminate\Support\Collection;
|
use Illuminate\Support\Collection;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@ -23,6 +24,11 @@ interface ExporterInterface
|
|||||||
*/
|
*/
|
||||||
public function getEntries();
|
public function getEntries();
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return string
|
||||||
|
*/
|
||||||
|
public function getFileName();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
*
|
*
|
||||||
*/
|
*/
|
||||||
@ -34,9 +40,4 @@ interface ExporterInterface
|
|||||||
*/
|
*/
|
||||||
public function setEntries(Collection $entries);
|
public function setEntries(Collection $entries);
|
||||||
|
|
||||||
/**
|
|
||||||
* @return string
|
|
||||||
*/
|
|
||||||
public function getFileName();
|
|
||||||
|
|
||||||
}
|
}
|
||||||
|
@ -63,6 +63,7 @@ class FireRulesForStore
|
|||||||
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -62,6 +62,7 @@ class FireRulesForUpdate
|
|||||||
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -33,6 +33,7 @@ class ScanForBillsAfterStore
|
|||||||
{
|
{
|
||||||
$journal = $event->journal;
|
$journal = $event->journal;
|
||||||
BillScanner::scan($journal);
|
BillScanner::scan($journal);
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -32,6 +32,7 @@ class ScanForBillsAfterUpdate
|
|||||||
{
|
{
|
||||||
$journal = $event->journal;
|
$journal = $event->journal;
|
||||||
BillScanner::scan($journal);
|
BillScanner::scan($journal);
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -15,8 +15,8 @@ use FireflyIII\Helpers\Collection\Balance;
|
|||||||
use FireflyIII\Helpers\Collection\BalanceEntry;
|
use FireflyIII\Helpers\Collection\BalanceEntry;
|
||||||
use FireflyIII\Helpers\Collection\BalanceHeader;
|
use FireflyIII\Helpers\Collection\BalanceHeader;
|
||||||
use FireflyIII\Helpers\Collection\BalanceLine;
|
use FireflyIII\Helpers\Collection\BalanceLine;
|
||||||
use FireflyIII\Models\Budget as BudgetModel;
|
|
||||||
use FireflyIII\Models\Budget;
|
use FireflyIII\Models\Budget;
|
||||||
|
use FireflyIII\Models\Budget as BudgetModel;
|
||||||
use FireflyIII\Models\Tag;
|
use FireflyIII\Models\Tag;
|
||||||
use FireflyIII\Models\TransactionJournal;
|
use FireflyIII\Models\TransactionJournal;
|
||||||
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
|
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
|
||||||
|
@ -4,7 +4,6 @@ use Auth;
|
|||||||
use Carbon\Carbon;
|
use Carbon\Carbon;
|
||||||
use Config;
|
use Config;
|
||||||
use FireflyIII\Http\Requests\NewUserFormRequest;
|
use FireflyIII\Http\Requests\NewUserFormRequest;
|
||||||
use FireflyIII\Models\AccountMeta;
|
|
||||||
use FireflyIII\Repositories\Account\AccountRepositoryInterface as ARI;
|
use FireflyIII\Repositories\Account\AccountRepositoryInterface as ARI;
|
||||||
use Preferences;
|
use Preferences;
|
||||||
use Session;
|
use Session;
|
||||||
|
@ -7,6 +7,7 @@ use Closure;
|
|||||||
use Illuminate\Http\Request;
|
use Illuminate\Http\Request;
|
||||||
use Illuminate\Support\Facades\Auth;
|
use Illuminate\Support\Facades\Auth;
|
||||||
use Session;
|
use Session;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Class Authenticate
|
* Class Authenticate
|
||||||
*
|
*
|
||||||
|
@ -4,7 +4,6 @@ declare(strict_types = 1);
|
|||||||
namespace FireflyIII\Http\Requests;
|
namespace FireflyIII\Http\Requests;
|
||||||
|
|
||||||
use Auth;
|
use Auth;
|
||||||
use Input;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Class TokenFormRequest
|
* Class TokenFormRequest
|
||||||
|
@ -19,7 +19,6 @@ use Illuminate\Support\ServiceProvider;
|
|||||||
use Twig;
|
use Twig;
|
||||||
use TwigBridge\Extension\Loader\Functions;
|
use TwigBridge\Extension\Loader\Functions;
|
||||||
use Validator;
|
use Validator;
|
||||||
use Auth;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Class FireflyServiceProvider
|
* Class FireflyServiceProvider
|
||||||
|
@ -51,6 +51,7 @@ class AbstractTrigger
|
|||||||
$self = new static;
|
$self = new static;
|
||||||
$self->triggerValue = $triggerValue;
|
$self->triggerValue = $triggerValue;
|
||||||
$self->stopProcessing = $stopProcessing;
|
$self->stopProcessing = $stopProcessing;
|
||||||
|
|
||||||
return $self;
|
return $self;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -40,9 +40,11 @@ class Steam
|
|||||||
|
|
||||||
bcscale(2);
|
bcscale(2);
|
||||||
|
|
||||||
$balance = strval($account->transactions()->leftJoin(
|
$balance = strval(
|
||||||
|
$account->transactions()->leftJoin(
|
||||||
'transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id'
|
'transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id'
|
||||||
)->where('transaction_journals.date', '<=', $date->format('Y-m-d'))->sum('transactions.amount'));
|
)->where('transaction_journals.date', '<=', $date->format('Y-m-d'))->sum('transactions.amount')
|
||||||
|
);
|
||||||
|
|
||||||
if (!$ignoreVirtualBalance) {
|
if (!$ignoreVirtualBalance) {
|
||||||
$balance = bcadd($balance, $account->virtual_balance);
|
$balance = bcadd($balance, $account->virtual_balance);
|
||||||
|
@ -16,13 +16,11 @@ use FireflyIII\Models\TransactionType;
|
|||||||
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
|
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
|
||||||
use FireflyIII\Rules\Triggers\TriggerInterface;
|
use FireflyIII\Rules\Triggers\TriggerInterface;
|
||||||
use FireflyIII\User;
|
use FireflyIII\User;
|
||||||
use Input;
|
|
||||||
use Illuminate\Contracts\Encryption\DecryptException;
|
use Illuminate\Contracts\Encryption\DecryptException;
|
||||||
use Illuminate\Validation\Validator;
|
use Illuminate\Validation\Validator;
|
||||||
|
use Input;
|
||||||
use Log;
|
use Log;
|
||||||
use PragmaRX\Google2FA\Contracts\Google2FA;
|
|
||||||
use Symfony\Component\Translation\TranslatorInterface;
|
use Symfony\Component\Translation\TranslatorInterface;
|
||||||
use Session;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Class FireflyValidator
|
* Class FireflyValidator
|
||||||
|
Loading…
Reference in New Issue
Block a user