IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix test coverage.

Browse Source
This commit is contained in:
James Cole
2018-12-09 20:54:11 +01:00
parent 97f6e68164
commit ae4612f134
46 changed files with 383 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/Unit/Factory/TransactionFactoryTest.php
View File

@@ -878,6 +878,12 @@ class TransactionFactoryTest extends TestCase
// first search action is for the asset account, second is for expense account.
$accountRepos->shouldReceive('findNull')->andReturn($asset, $expense)->atLeast()->once();
// Find budget, but based on null it returns null.
$budgetFactory->shouldReceive('find')->withArgs([null, null])->andReturnNull()->atLeast()->once();
// find category, but none are present so return null.
$categoryFactory->shouldReceive('findOrCreate')->withArgs([null, null])->andReturnNull()->atLeast()->once();
// factories return various stuff:
$currencyFactory->shouldReceive('find')->andReturn(null, null)->atLeast()->once();
@@ -896,7 +902,7 @@ class TransactionFactoryTest extends TestCase
$newCount = $withdrawal->transactions()->count();
$this->assertEquals($count, $newCount);
$this->assertEquals($count, $newCount - 2);
}
/**

4
tests/Unit/Transformers/AccountTransformerTest.php
View File

@@ -207,7 +207,7 @@ class AccountTransformerTest extends TestCase
$this->assertEquals($note->text, $result['notes']);
$this->assertEquals('2018-02-01', $result['monthly_payment_date']);
$this->assertEquals('monthlyFull', $result['credit_card_type']);
$this->assertEquals('ccAsset', $result['role']);
$this->assertEquals('ccAsset', $result['account_role']);
}
/**
@@ -292,7 +292,7 @@ class AccountTransformerTest extends TestCase
$this->assertEquals($note->text, $result['notes']);
$this->assertNull($result['monthly_payment_date']);
$this->assertNull($result['credit_card_type']);
$this->assertNull($result['role']);
$this->assertNull($result['account_role']);
}
/**

1
tests/Unit/Transformers/TagTransformerTest.php
View File

@@ -55,7 +55,6 @@ class TagTransformerTest extends TestCase
);
$transformer = new TagTransformer(new ParameterBag);
$result = $transformer->transform($tag);
$this->assertEquals('nothing', $result['tag_mode']);
$this->assertEquals($tag->tag, $result['tag']);
$this->assertEquals(5.5, $result['latitude']);
$this->assertEquals(6.6, $result['longitude']);

77
tests/Unit/Transformers/TransactionTransformerTest.php
View File

@@ -35,6 +35,7 @@ use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Transformers\TransactionTransformer;
use Illuminate\Support\Collection;
use Symfony\Component\HttpFoundation\ParameterBag;
@@ -52,6 +53,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testBasic(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -130,6 +136,7 @@ class TransactionTransformerTest extends TestCase
$this->assertEquals($expense->iban, $result['destination_iban']);
$this->assertEquals($expense->id, $result['destination_id']);
$this->assertEquals('Expense account', $result['destination_type']);
}
/**
@@ -140,6 +147,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testDeposit(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -228,6 +240,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testDepositBudget(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -325,6 +342,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testForeignAmount(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -421,6 +443,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testJournalBudget(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -523,6 +550,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testJournalCategory(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -625,6 +657,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testOpeningBalanceNeg(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -714,6 +751,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testOpeningBalancePos(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -803,6 +845,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testReconciliationNeg(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -892,6 +939,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testReconciliationPos(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -981,6 +1033,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testTransactionBudget(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -1085,6 +1142,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testTransactionCategory(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -1188,6 +1250,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testTransactionDescription(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$asset = Account::create(
[
@@ -1276,6 +1343,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testTransferOne(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$left = Account::create(
[
@@ -1364,6 +1436,11 @@ class TransactionTransformerTest extends TestCase
*/
public function testTransferTwo(): void
{
$journalRepository = $this->mock(JournalRepositoryInterface::class);
$journalRepository->shouldReceive('getNoteText')->andReturn('Some notes')->atLeast()->once();
$journalRepository->shouldReceive('getMetaField')->andReturn('FieldValue')->atLeast()->once();
$journalRepository->shouldReceive('getMetaDateString')->andReturn('2018-01-01')->atLeast()->once();
// make new asset account:
$left = Account::create(
[