Various code cleanup.

app/Events/AdminRequestedTestMessage.php

@@ -42,6 +42,7 @@ class AdminRequestedTestMessage extends Event
     /** @var User The user */
     public $user;
 
+
     /**
      * Create a new event instance.
      *

app/Events/RegisteredUser.php

@@ -41,6 +41,7 @@ class RegisteredUser extends Event
     /** @var User The user */
     public $user;
 
+
     /**
      * Create a new event instance. This event is triggered when a new user registers.
      *

app/Events/RequestedNewPassword.php

@@ -43,6 +43,7 @@ class RequestedNewPassword extends Event
     /** @var User The user */
     public $user;
 
+
     /**
      * Create a new event instance. This event is triggered when a users tries to reset his or her password.
      *

app/Events/RequestedReportOnJournals.php

@@ -46,6 +46,7 @@ class RequestedReportOnJournals
     /** @var int The ID of the user. */
     public $userId;
 
+
     /**
      * Create a new event instance.
      *

app/Events/RequestedVersionCheckStatus.php

@@ -40,6 +40,7 @@ class RequestedVersionCheckStatus extends Event
     /** @var User The user */
     public $user;
 
+
     /**
      * Create a new event instance. This event is triggered when Firefly III wants to know
      * what the deal is with the version checker.

app/Events/StoredTransactionGroup.php

@@ -41,6 +41,7 @@ class StoredTransactionGroup extends Event
     /** @var TransactionGroup The group that was stored. */
     public $transactionGroup;
 
+
     /**
      * Create a new event instance.
      *

app/Events/UpdatedTransactionGroup.php

@@ -31,7 +31,6 @@ use Illuminate\Queue\SerializesModels;
  * Class UpdatedTransactionGroup.
  *
  * @codeCoverageIgnore
- *
  */
 class UpdatedTransactionGroup extends Event
 {
@@ -42,6 +41,7 @@ class UpdatedTransactionGroup extends Event
     /** @var TransactionGroup The group that was stored. */
     public $transactionGroup;
 
+
     /**
      * Create a new event instance.
      *

app/Events/UserChangedEmail.php

@@ -45,6 +45,7 @@ class UserChangedEmail extends Event
     /** @var User The user itself */
     public $user;
 
+
     /**
      * UserChangedEmail constructor.
      *

app/Exceptions/Handler.php

@@ -31,10 +31,10 @@ use Exception;
 use FireflyIII\Jobs\MailError;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Http\Request;
 use Illuminate\Validation\ValidationException as LaravelValidationException;
 use League\OAuth2\Server\Exception\OAuthServerException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Illuminate\Http\Request;
 use Throwable;
 /**
  * Class Handler

app/Factory/AccountFactory.php

@@ -113,7 +113,7 @@ class AccountFactory
             }
 
             // fix virtual balance when it's empty
-            if ('' === (string)$databaseData['virtual_balance']) {
+            if ('' === (string) $databaseData['virtual_balance']) {
                 $databaseData['virtual_balance'] = null;
             }
 
@@ -152,7 +152,6 @@ class AccountFactory
     }
 
     /**
-     *
      * @param string $accountName
      * @param string $accountType
      *
@@ -198,7 +197,6 @@ class AccountFactory
      * @param null|string $accountType
      *
      * @return AccountType|null
-     *
      */
     protected function getAccountType(?int $accountTypeId, ?string $accountType): ?AccountType
     {

app/Factory/AttachmentFactory.php

@@ -39,6 +39,7 @@ class AttachmentFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *

app/Factory/BillFactory.php

@@ -43,6 +43,7 @@ class BillFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *

app/Factory/BudgetFactory.php

@@ -21,7 +21,6 @@
 /** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);
 
-
 namespace FireflyIII\Factory;
 
 use FireflyIII\Models\Budget;
@@ -36,6 +35,7 @@ class BudgetFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *
@@ -53,7 +53,6 @@ class BudgetFactory
      * @param null|string $budgetName
      *
      * @return Budget|null
-     *
      */
     public function find(?int $budgetId, ?string $budgetName): ?Budget
     {

app/Factory/CategoryFactory.php

@@ -38,6 +38,7 @@ class CategoryFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *

app/Factory/PiggyBankEventFactory.php

@@ -54,7 +54,6 @@ class PiggyBankEventFactory
      * @param PiggyBank|null     $piggyBank
      *
      * @return PiggyBankEvent|null
-     *
      */
     public function create(TransactionJournal $journal, ?PiggyBank $piggyBank): ?PiggyBankEvent
     {

app/Factory/PiggyBankFactory.php

@@ -36,6 +36,7 @@ class PiggyBankFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *
@@ -53,7 +54,6 @@ class PiggyBankFactory
      * @param null|string $piggyBankName
      *
      * @return PiggyBank|null
-     *
      */
     public function find(?int $piggyBankId, ?string $piggyBankName): ?PiggyBank
     {

app/Factory/RecurrenceFactory.php

@@ -39,12 +39,13 @@ use Log;
  */
 class RecurrenceFactory
 {
+
+    use TransactionTypeTrait, RecurringTransactionTrait;
     /** @var MessageBag */
     private $errors;
     /** @var User */
     private $user;
 
-    use TransactionTypeTrait, RecurringTransactionTrait;
 
     /**
      * Constructor.

app/Factory/TagFactory.php

@@ -40,6 +40,7 @@ class TagFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *

app/Factory/TransactionCurrencyFactory.php

@@ -82,7 +82,6 @@ class TransactionCurrencyFactory
      * @param null|string $currencyCode
      *
      * @return TransactionCurrency|null
-     *
      */
     public function find(?int $currencyId, ?string $currencyCode): ?TransactionCurrency
     {

app/Factory/TransactionFactory.php

@@ -51,6 +51,7 @@ class TransactionFactory
     /** @var User */
     private $user;
 
+
     /**
      * Constructor.
      *

app/Factory/TransactionGroupFactory.php

@@ -40,6 +40,7 @@ class TransactionGroupFactory
     /** @var User The user */
     private $user;
 
+
     /**
      * TransactionGroupFactory constructor.
      */

app/Factory/TransactionJournalFactory.php

@@ -76,6 +76,7 @@ class TransactionJournalFactory
     /** @var User The user */
     private $user;
 
+
     /**
      * Constructor.
      *
@@ -101,7 +102,7 @@ class TransactionJournalFactory
             'import_hash', 'import_hash_v2', 'external_id', 'original_source',
 
             // recurring transactions
-            'recurrence_total', 'recurrence_count'
+            'recurrence_total', 'recurrence_count',
         ];
 
 

database/migrations/2020_07_24_162820_changes_for_v540.php

@@ -19,7 +19,7 @@ class ChangesForV540 extends Migration
     {
         Schema::table(
             'oauth_clients', static function (Blueprint $table) {
-            $table->dropColumn('order');
+            $table->dropColumn('provider');
         }
         );