IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed boolean for left join that was never called more than twice anyway.

Browse Source
This commit is contained in:
James Cole 2016-03-02 11:52:17 +01:00
parent b0cc6dd714
commit bf4a7846dd
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/Models/TransactionJournal.php
View File

@ -40,9 +40,6 @@ class TransactionJournal extends Model
'encrypted' => 'required|boolean', 'encrypted' => 'required|boolean',
]; ];
/** @var bool */
private $joinedTransactionTypes;
/** /**
* @param $value * @param $value
* *
@ -307,12 +304,9 @@ class TransactionJournal extends Model
*/ */
public function scopeTransactionTypes(EloquentBuilder $query, array $types) public function scopeTransactionTypes(EloquentBuilder $query, array $types)
{ {
if (is_null($this->joinedTransactionTypes)) { $query->leftJoin(
$query->leftJoin( 'transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id'
'transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id' );
);
$this->joinedTransactionTypes = true;
}
$query->whereIn('transaction_types.type', $types); $query->whereIn('transaction_types.type', $types);
} }