IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Some code cleanup.

Browse Source
This commit is contained in:
James Cole
2015-02-01 08:51:27 +01:00
parent 210d597a48
commit c2d2eb53e8
15 changed files with 232 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/GoogleChartController.php
View File

@@ -361,7 +361,6 @@ class GoogleChartController extends BaseController
$end->endOfYear();
}
while ($start <= $end) {
$spent = $budgetRepository->spentInMonth($budget, $start);
$repetition = $budgetRepository->repetitionOnStartingOnDate($budget, $start);

3
app/controllers/PiggybankController.php
View File

@@ -313,6 +313,8 @@ class PiggyBankController extends BaseController
/**
* @param PiggyBank $piggyBank
*
* @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind.
*
* @return $this
* @throws FireflyException
*/
@@ -327,7 +329,6 @@ class PiggyBankController extends BaseController
$data['user_id'] = Auth::user()->id;
$data['repeats'] = 0;
// always validate:
$messages = $this->_repository->validate($data);
Session::flash('warnings', $messages['warnings']);

2
app/controllers/ReportController.php
View File

@@ -124,7 +124,7 @@ class ReportController extends BaseController
$mainTitleIcon = 'fa-line-chart';
$balances = $this->_repository->yearBalanceReport($date);
$groupedIncomes = $this->_repository->revenueGroupedByAccount($date, $end, 15);
$groupedIncomes = $this->_repository->revenueGroupedByAccount($date, $end);
$groupedExpenses = $this->_repository->expensesGroupedByAccount($date, $end, 15);
return View::make(

3
app/controllers/TransactionController.php
View File

@@ -242,7 +242,6 @@ class TransactionController extends BaseController
public function store($what)
{
$data = Input::except('_token');
$transactionType = $this->_repository->getJournalType($what);
$transactionCurrency = $this->_repository->getJournalCurrencyById(intval($data['amount_currency_id']));
$data['transaction_type_id'] = $transactionType->id;
@@ -284,6 +283,8 @@ class TransactionController extends BaseController
/**
* @param TransactionJournal $journal
*
* @SuppressWarnings("CyclomaticComplexity") // It's exactly 5. So I don't mind.
*
* @return $this
* @throws FireflyException
*/