From c55aebd00576f9ad21a816415fc037c7d7ceb76b Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 1 Jul 2018 10:11:41 +0200 Subject: [PATCH] Fix credit test. --- app/Import/Converter/Amount.php | 2 +- tests/Unit/Import/Converter/AmountCreditTest.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Import/Converter/Amount.php b/app/Import/Converter/Amount.php index 79a0c218e5..c9317f2045 100644 --- a/app/Import/Converter/Amount.php +++ b/app/Import/Converter/Amount.php @@ -99,7 +99,7 @@ class Amount implements ConverterInterface Log::debug(sprintf('No decimal character found. Converted amount from "%s" to "%s".', $original, $value)); } - return (string)number_format(round(floatval($value), 12), 12, '.', ''); + return number_format(round((float)$value, 12), 12, '.', ''); } /** diff --git a/tests/Unit/Import/Converter/AmountCreditTest.php b/tests/Unit/Import/Converter/AmountCreditTest.php index 50741e2b55..17ae55727e 100644 --- a/tests/Unit/Import/Converter/AmountCreditTest.php +++ b/tests/Unit/Import/Converter/AmountCreditTest.php @@ -37,7 +37,7 @@ class AmountCreditTest extends TestCase { $values = [ '0' => '0.000000000000', - '0.0' => '0', + '0.0' => '0.000000000000', '0.1' => '0.1', '.2' => '0.2', '0.01' => '0.01', @@ -154,7 +154,7 @@ class AmountCreditTest extends TestCase foreach ($values as $value => $expected) { $converter = new AmountCredit; $result = $converter->convert($value); - $this->assertEquals($expected, $result, sprintf('The original value was %s', $value)); + $this->assertEquals($expected, $result, sprintf('The original value was %s, expected was %s', $value, $expected)); } }