Update test coverage.

app/Helpers/Attachments/AttachmentHelper.php

@@ -144,9 +144,11 @@ class AttachmentHelper implements AttachmentHelperInterface
     {
         $resource = tmpfile();
         if (false === $resource) {
+            // @codeCoverageIgnoreStart
             Log::error('Cannot create temp-file for file upload.');
 
             return false;
+            // @codeCoverageIgnoreEnd
         }
         $path = stream_get_meta_data($resource)['uri'];
         fwrite($resource, $content);
@@ -341,9 +343,12 @@ class AttachmentHelper implements AttachmentHelperInterface
         if (!$this->validMime($file)) {
             $result = false;
         }
+        // @codeCoverageIgnoreStart
+        // can't seem to reach this point.
         if (true === $result && !$this->validSize($file)) {
             $result = false;
         }
+        // @codeCoverageIgnoreEnd
         if (true === $result && $this->hasFile($file, $model)) {
             $result = false;
         }

app/Helpers/Collection/Balance.php

@@ -26,6 +26,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class Balance.
+ *
+ * @codeCoverageIgnore
  */
 class Balance
 {

app/Helpers/Collection/BalanceEntry.php

@@ -26,6 +26,8 @@ use FireflyIII\Models\Account as AccountModel;
 
 /**
  * Class BalanceEntry.
+ *
+ * @codeCoverageIgnore
  */
 class BalanceEntry
 {

app/Helpers/Collection/BalanceHeader.php

@@ -27,6 +27,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class BalanceHeader.
+ *
+ * @codeCoverageIgnore
  */
 class BalanceHeader
 {

app/Helpers/Collection/BalanceLine.php

@@ -29,6 +29,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class BalanceLine.
+ *
+ * @codeCoverageIgnore
  */
 class BalanceLine
 {

app/Helpers/Collection/Bill.php

@@ -29,6 +29,8 @@ use Log;
 
 /**
  * Class Bill.
+ *
+ * @codeCoverageIgnore
  */
 class Bill
 {

app/Helpers/Collection/BillLine.php

@@ -27,6 +27,8 @@ use FireflyIII\Models\Bill as BillModel;
 
 /**
  * Class BillLine.
+ *
+ * @codeCoverageIgnore
  */
 class BillLine
 {

app/Helpers/Collection/Category.php

@@ -27,6 +27,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class Category.
+ *
+ * @codeCoverageIgnore
  */
 class Category
 {

app/Helpers/Collector/TransactionCollector.php

@@ -52,6 +52,8 @@ use Log;
 
 /**
  * Class TransactionCollector
+ *
+ * @codeCoverageIgnore 
  */
 class TransactionCollector implements TransactionCollectorInterface
 {

app/Helpers/Filter/CountAttachmentsFilter.php

@@ -31,6 +31,7 @@ use Illuminate\Support\Collection;
 
 /**
  * Class CountAttachmentsFilter
+ * @codeCoverageIgnore
  */
 class CountAttachmentsFilter implements FilterInterface
 {

app/Helpers/Filter/EmptyFilter.php

@@ -26,6 +26,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class EmptyFilter.
+ *
+ * @codeCoverageIgnore
  */
 class EmptyFilter implements FilterInterface
 {

app/Helpers/Filter/InternalTransferFilter.php

@@ -32,6 +32,8 @@ use Log;
  * This filter removes any filters that are from A to B or from B to A given a set of
  * account id's (in $parameters) where A and B are mentioned. So transfers between the mentioned
  * accounts will be removed.
+ *
+ * @codeCoverageIgnore
  */
 class InternalTransferFilter implements FilterInterface
 {

app/Helpers/Filter/NegativeAmountFilter.php

@@ -30,6 +30,8 @@ use Log;
  * Class NegativeAmountFilter.
  *
  * This filter removes entries with a negative amount (the original modifier is -1).
+ *
+ * @codeCoverageIgnore
  */
 class NegativeAmountFilter implements FilterInterface
 {

app/Helpers/Filter/OpposingAccountFilter.php

@@ -31,6 +31,8 @@ use Log;
  *
  * This filter is similar to the internal transfer filter but only removes transactions when the opposing account is
  * amongst $parameters (list of account ID's).
+ *
+ * @codeCoverageIgnore
  */
 class OpposingAccountFilter implements FilterInterface
 {

app/Helpers/Filter/PositiveAmountFilter.php

@@ -33,6 +33,8 @@ use Log;
  *
  * This filter removes transactions with either a positive amount ($parameters = 1) or a negative amount
  * ($parameter = -1). This is helpful when a Collection has you with both transactions in a journal.
+ *
+ * @codeCoverageIgnore
  */
 class PositiveAmountFilter implements FilterInterface
 {

app/Helpers/Filter/SplitIndicatorFilter.php

@@ -30,6 +30,8 @@ use Illuminate\Support\Collection;
 
 /**
  * Class SplitIndicatorFilter
+ *
+ * @codeCoverageIgnore
  */
 class SplitIndicatorFilter implements FilterInterface
 {

app/Helpers/Filter/TransactionViewFilter.php

@@ -35,6 +35,8 @@ use Log;
  *
  * This is used in the mass-edit routine.
  *
+ * @codeCoverageIgnore
+ *
  */
 class TransactionViewFilter implements FilterInterface
 {

app/Helpers/Filter/TransferFilter.php

@@ -30,6 +30,8 @@ use Illuminate\Support\Collection;
  * Class TransferFilter.
  *
  * This filter removes any transfers that are in the collection twice (from A to B and from B to A).
+ *
+ * @codeCoverageIgnore
  */
 class TransferFilter implements FilterInterface
 {

tests/Unit/Helpers/Attachments/AttachmentHelperTest.php

@@ -20,14 +20,16 @@
  */
 declare(strict_types=1);
 
-namespace Tests\Unit\Helpers;
+namespace Tests\Unit\Helpers\Attachments;
 
+use Crypt;
 use FireflyIII\Helpers\Attachments\AttachmentHelper;
 use FireflyIII\Models\Attachment;
 use FireflyIII\Models\TransactionJournal;
 use Illuminate\Http\UploadedFile;
 use Illuminate\Support\Facades\Storage;
 use Tests\TestCase;
+use Log;
 
 /**
  * Class AttachmentHelperTest
@@ -38,6 +40,15 @@ use Tests\TestCase;
  */
 class AttachmentHelperTest extends TestCase
 {
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::debug(sprintf('Now in %s.', \get_class($this)));
+    }
+
     /**
      * @covers  \FireflyIII\Helpers\Attachments\AttachmentHelper
      */
@@ -97,6 +108,45 @@ class AttachmentHelperTest extends TestCase
         Storage::disk('upload')->assertExists(sprintf('at-%d.data', $attachments->first()->id));
     }
 
+    /**
+     * @covers  \FireflyIII\Helpers\Attachments\AttachmentHelper
+     */
+    public function testSaveAttachmentFromApi(): void
+    {
+        // mock calls:
+        Crypt::shouldReceive('encrypt')->times(2)->andReturn('Some encrypted content');
+        Storage::fake('upload');
+
+        $path       = public_path('apple-touch-icon.png');
+        $helper     = new AttachmentHelper;
+        $attachment = Attachment::first();
+
+        // call helper
+        $result     = $helper->saveAttachmentFromApi($attachment, file_get_contents($path));
+
+        $this->assertTrue($result);
+
+    }
+
+    /**
+     * @covers  \FireflyIII\Helpers\Attachments\AttachmentHelper
+     */
+    public function testSaveAttachmentFromApiBadMime(): void
+    {
+        // mock calls:
+        Storage::fake('upload');
+
+        $path       = public_path('browserconfig.xml');
+        $helper     = new AttachmentHelper;
+        $attachment = Attachment::first();
+
+        // call helper
+        $result     = $helper->saveAttachmentFromApi($attachment, file_get_contents($path));
+
+        $this->assertFalse($result);
+
+    }
+
     /**
      * Test double file upload. Needs to be after testSave.
      *

tests/Unit/Helpers/Chart/MetaPieChartTest.php

@@ -20,7 +20,7 @@
  */
 declare(strict_types=1);
 
-namespace Tests\Unit\Helpers;
+namespace Tests\Unit\Helpers\Chart;
 
 use Carbon\Carbon;
 use FireflyIII\Helpers\Chart\MetaPieChart;
@@ -35,6 +35,7 @@ use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use Illuminate\Support\Collection;
 use Tests\TestCase;
+use Log;
 
 /**
  * Class MetaPieChartTest
@@ -45,6 +46,15 @@ use Tests\TestCase;
  */
 class MetaPieChartTest extends TestCase
 {
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::debug(sprintf('Now in %s.', \get_class($this)));
+    }
+
     /**
      * @covers \FireflyIII\Helpers\Chart\MetaPieChart
      */

tests/Unit/Helpers/Filter/AmountFilterTest.php

@@ -0,0 +1,69 @@
+<?php
+/**
+ * AmountFilterTest.php
+ * Copyright (c) 2018 thegrumpydictator@gmail.com
+ *
+ * This file is part of Firefly III.
+ *
+ * Firefly III is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Firefly III is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+declare(strict_types=1);
+
+namespace Tests\Unit\Helpers\Filter;
+
+
+use FireflyIII\Helpers\Filter\AmountFilter;
+use FireflyIII\Models\Transaction;
+use Illuminate\Support\Collection;
+use Log;
+use Tests\TestCase;
+
+/**
+ *
+ * Class AmountFilterTest
+ */
+class AmountFilterTest extends TestCase
+{
+    /**
+     *
+     */
+    public function setUp(): void
+    {
+        parent::setUp();
+        Log::debug(sprintf('Now in %s.', \get_class($this)));
+    }
+
+    /**
+     * @covers \FireflyIII\Helpers\Filter\AmountFilter
+     */
+    public function testBasicPositive(): void
+    {
+        $count      = 0;
+        $collection = new Collection;
+        for ($i = 0; $i < 10; $i++) {
+            $amount                          = random_int(-10, 10);
+            $transaction                     = new Transaction;
+            $transaction->transaction_amount = (string)$amount;
+            if ($amount <= 0) {
+                $count++;
+            }
+            $collection->push($transaction);
+        }
+
+        $filter = new AmountFilter(1);
+        $result = $filter->filter($collection);
+        $this->assertCount($count, $result);
+    }
+}