IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3321

Browse Source
This commit is contained in:
James Cole 2020-05-01 17:47:56 +02:00
parent 9d9053d828
commit c561f99de6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@ -142,6 +142,9 @@ trait ModifiesPiggyBanks
*/ */
public function createEvent(PiggyBank $piggyBank, string $amount): PiggyBankEvent public function createEvent(PiggyBank $piggyBank, string $amount): PiggyBankEvent
{ {
if (0 === bccomp('0', $amount)) {
return new PiggyBankEvent;
}
/** @var PiggyBankEvent $event */ /** @var PiggyBankEvent $event */
$event = PiggyBankEvent::create(['date' => Carbon::now(), 'amount' => $amount, 'piggy_bank_id' => $piggyBank->id]); $event = PiggyBankEvent::create(['date' => Carbon::now(), 'amount' => $amount, 'piggy_bank_id' => $piggyBank->id]);
@ -219,11 +222,12 @@ trait ModifiesPiggyBanks
if (1 === bccomp($amount, $max)) { if (1 === bccomp($amount, $max)) {
$amount = $max; $amount = $max;
} }
$difference = bcsub($amount, $repetition->currentamount);
$repetition->currentamount = $amount; $repetition->currentamount = $amount;
$repetition->save(); $repetition->save();
// create event // create event
$this->createEvent($piggyBank, $amount); $this->createEvent($piggyBank, $difference);
return $piggyBank; return $piggyBank;
} }
@ -343,4 +347,4 @@ trait ModifiesPiggyBanks
return true; return true;
} }
} }