IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused exceptions.

Browse Source
This commit is contained in:
James Cole 2023-12-22 07:58:35 +01:00
parent b2bd9301b6
commit c60b5e5c21
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
81 changed files with 12 additions and 531 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.ci/php-cs-fixer/.php-cs-fixer.php
View File

@ -55,7 +55,7 @@ return $config->setRules([
],
],
'statement_indentation' => true,
'type_declaration_spaces' => true,
'type_declaration_spaces' => false,
'cast_spaces' => false,
'binary_operator_spaces' => false,
'void_return' => true,

4
app/Api/V1/Controllers/Chart/AccountController.php
View File

@ -35,8 +35,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Support\Http\Api\ApiSupport;
use FireflyIII\User;
use Illuminate\Http\JsonResponse;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class AccountController
@ -70,8 +68,6 @@ class AccountController extends Controller
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/charts/getChartAccountOverview
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function overview(DateRequest $request): JsonResponse
{

5
app/Api/V1/Controllers/Controller.php
View File

@ -35,8 +35,6 @@ use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Routing\Controller as BaseController;
use League\Fractal\Manager;
use League\Fractal\Serializer\JsonApiSerializer;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Symfony\Component\HttpFoundation\Exception\BadRequestException;
use Symfony\Component\HttpFoundation\ParameterBag;
@ -109,9 +107,6 @@ abstract class Controller extends BaseController
/**
* Method to grab all parameters from the URL.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function getParameters(): ParameterBag
{

22
app/Api/V1/Controllers/Data/Export/ExportController.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Api\V1\Requests\Data\Export\ExportRequest;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Support\Export\ExportDataGenerator;
use Illuminate\Http\Response as LaravelResponse;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ExportController
@ -59,9 +57,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportAccounts
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -76,9 +72,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportBills
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -93,9 +87,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportBudgets
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -110,9 +102,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportCategories
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -127,9 +117,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportPiggies
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -144,9 +132,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportRecurring
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -161,9 +147,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportRules
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -178,9 +162,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportTags
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
@ -195,9 +177,7 @@ class ExportController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportTransactions
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function transactions(ExportRequest $request): LaravelResponse
{
@ -212,8 +192,6 @@ class ExportController extends Controller
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function returnExport(string $key): LaravelResponse
{

12
app/Api/V1/Controllers/System/ConfigurationController.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use FireflyIII\Support\Binder\EitherConfigKey;
use Illuminate\Http\JsonResponse;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ConfigurationController
@ -58,9 +56,7 @@ class ConfigurationController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/configuration/getConfiguration
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function index(): JsonResponse
{
@ -95,9 +91,6 @@ class ConfigurationController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/configuration/getSingleConfiguration
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(string $configKey): JsonResponse
{
@ -128,9 +121,7 @@ class ConfigurationController extends Controller
*
* Update the configuration.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function update(UpdateRequest $request, string $name): JsonResponse
{
@ -157,9 +148,6 @@ class ConfigurationController extends Controller
/**
* Get all config values.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function getDynamicConfiguration(): array
{

5
app/Api/V1/Controllers/System/CronController.php
View File

@ -27,8 +27,6 @@ use FireflyIII\Api\V1\Controllers\Controller;
use FireflyIII\Api\V1\Requests\System\CronRequest;
use FireflyIII\Support\Http\Controllers\CronRunner;
use Illuminate\Http\JsonResponse;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class CronController
@ -40,9 +38,6 @@ class CronController extends Controller
/**
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/about/getCron
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function cron(CronRequest $request): JsonResponse
{

4
app/Api/V2/Controllers/Chart/AccountController.php
View File

@ -36,8 +36,6 @@ use FireflyIII\Support\Http\Api\CleansChartData;
use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class AccountController
@ -76,8 +74,6 @@ class AccountController extends Controller
*
* TODO validate and set user_group_id from request
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)

4
app/Console/Commands/Export/ExportData.php
View File

@ -35,8 +35,6 @@ use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Support\Export\ExportDataGenerator;
use Illuminate\Console\Command;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ExportData
@ -72,8 +70,6 @@ class ExportData extends Command
* Execute the console command.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{

10
app/Console/Commands/Tools/Cron.php
View File

@ -32,8 +32,6 @@ use FireflyIII\Support\Cronjobs\BillWarningCronjob;
use FireflyIII\Support\Cronjobs\ExchangeRatesCronjob;
use FireflyIII\Support\Cronjobs\RecurringCronjob;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class Cron
@ -49,10 +47,6 @@ class Cron extends Command
{--date= : Set the date in YYYY-MM-DD to make Firefly III think that\'s the current date.}
';
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
$date = null;
@ -130,9 +124,7 @@ class Cron extends Command
}
/**
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
private function recurringCronJob(bool $force, ?Carbon $date): void
{
@ -180,8 +172,6 @@ class Cron extends Command
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function billWarningCronJob(bool $force, ?Carbon $date): void
{

6
app/Console/Commands/Upgrade/AccountCurrencies.php
View File

@ -34,8 +34,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use FireflyIII\User;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class AccountCurrencies
@ -90,10 +88,6 @@ class AccountCurrencies extends Command
$this->count = 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/AppendBudgetLimitPeriods.php
View File

@ -26,8 +26,6 @@ namespace FireflyIII\Console\Commands\Upgrade;
use FireflyIII\Console\Commands\ShowsFriendlyMessages;
use FireflyIII\Models\BudgetLimit;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class AppendBudgetLimitPeriods
@ -44,9 +42,6 @@ class AppendBudgetLimitPeriods extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -62,10 +57,6 @@ class AppendBudgetLimitPeriods extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

13
app/Console/Commands/Upgrade/BackToJournals.php
View File

@ -30,8 +30,6 @@ use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal;
use Illuminate\Console\Command;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class BackToJournals
@ -48,9 +46,6 @@ class BackToJournals extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -73,10 +68,6 @@ class BackToJournals extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isMigrated(): bool
{
$configVar = app('fireflyconfig')->get(MigrateToGroups::CONFIG_NAME, false);
@ -84,10 +75,6 @@ class BackToJournals extends Command
return (bool)$configVar->data;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

8
app/Console/Commands/Upgrade/BudgetLimitCurrency.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Models\Budget;
use FireflyIII\Models\BudgetLimit;
use FireflyIII\User;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class BudgetLimitCurrency
@ -48,9 +46,7 @@ class BudgetLimitCurrency extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -91,10 +87,6 @@ class BudgetLimitCurrency extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

8
app/Console/Commands/Upgrade/CCLiabilities.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Models\Account;
use FireflyIII\Models\AccountType;
use Illuminate\Console\Command;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class CCLiabilities
@ -46,9 +44,7 @@ class CCLiabilities extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -87,10 +83,6 @@ class CCLiabilities extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

13
app/Console/Commands/Upgrade/DecryptDatabase.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\Preference;
use Illuminate\Console\Command;
use Illuminate\Contracts\Encryption\DecryptException;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class DecryptDatabase
@ -44,9 +42,6 @@ class DecryptDatabase extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -75,10 +70,6 @@ class DecryptDatabase extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function decryptTable(string $table, array $fields): void
{
if ($this->isDecrypted($table)) {
@ -95,10 +86,6 @@ class DecryptDatabase extends Command
app('fireflyconfig')->set($configName, true);
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isDecrypted(string $table): bool
{
$configName = sprintf('is_decrypted_%s', $table);

8
app/Console/Commands/Upgrade/MigrateAttachments.php
View File

@ -28,8 +28,6 @@ use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\Attachment;
use FireflyIII\Models\Note;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateAttachments
@ -47,9 +45,7 @@ class MigrateAttachments extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -98,10 +94,6 @@ class MigrateAttachments extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/MigrateJournalNotes.php
View File

@ -27,8 +27,6 @@ use FireflyIII\Console\Commands\ShowsFriendlyMessages;
use FireflyIII\Models\Note;
use FireflyIII\Models\TransactionJournalMeta;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateJournalNotes
@ -45,9 +43,6 @@ class MigrateJournalNotes extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -93,10 +88,6 @@ class MigrateJournalNotes extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

15
app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Models\Recurrence;
use FireflyIII\Models\RecurrenceMeta;
use FireflyIII\Models\RecurrenceTransactionMeta;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateRecurrenceMeta
@ -47,9 +45,6 @@ class MigrateRecurrenceMeta extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* * @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -72,22 +67,16 @@ class MigrateRecurrenceMeta extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);
if (null !== $configVar) {
return (bool)$configVar->data;
return (bool) $configVar->data;
}
return false;
}
/**
* */
private function migrateMetaData(): int
{
$count = 0;
@ -102,8 +91,6 @@ class MigrateRecurrenceMeta extends Command
return $count;
}
/**
* */
private function migrateEntry(RecurrenceMeta $meta): int
{
/** @var null|Recurrence $recurrence */

9
app/Console/Commands/Upgrade/MigrateRecurrenceType.php
View File

@ -29,8 +29,6 @@ use FireflyIII\Models\Recurrence;
use FireflyIII\Models\RecurrenceTransaction;
use FireflyIII\Models\TransactionType;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateRecurrenceType
@ -47,9 +45,6 @@ class MigrateRecurrenceType extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -65,10 +60,6 @@ class MigrateRecurrenceType extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/MigrateTagLocations.php
View File

@ -28,8 +28,6 @@ use FireflyIII\Console\Commands\ShowsFriendlyMessages;
use FireflyIII\Models\Location;
use FireflyIII\Models\Tag;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateTagLocations
@ -46,9 +44,6 @@ class MigrateTagLocations extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -63,10 +58,6 @@ class MigrateTagLocations extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

8
app/Console/Commands/Upgrade/MigrateToRules.php
View File

@ -34,8 +34,6 @@ use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use FireflyIII\User;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class MigrateToRules
@ -58,9 +56,7 @@ class MigrateToRules extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -105,10 +101,6 @@ class MigrateToRules extends Command
$this->ruleRepository = app(RuleRepositoryInterface::class);
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php
View File

@ -34,8 +34,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalCLIRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class OtherCurrenciesCorrections
@ -55,9 +53,6 @@ class OtherCurrenciesCorrections extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -91,10 +86,6 @@ class OtherCurrenciesCorrections extends Command
$this->cliRepos = app(JournalCLIRepositoryInterface::class);
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

8
app/Console/Commands/Upgrade/RenameAccountMeta.php
View File

@ -27,8 +27,6 @@ use FireflyIII\Console\Commands\ShowsFriendlyMessages;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\AccountMeta;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class RenameAccountMeta
@ -46,9 +44,7 @@ class RenameAccountMeta extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -89,10 +85,6 @@ class RenameAccountMeta extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

8
app/Console/Commands/Upgrade/TransactionIdentifier.php
View File

@ -30,8 +30,6 @@ use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\Journal\JournalCLIRepositoryInterface;
use Illuminate\Console\Command;
use Illuminate\Database\QueryException;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class TransactionIdentifier
@ -56,9 +54,7 @@ class TransactionIdentifier extends Command
* When either of these are the same amount, FF3 can't keep them apart: +3/-3, +3/-3, +3/-3. This happens more
* often than you would think. So each set gets a number (1,2,3) to keep them apart.
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -105,10 +101,6 @@ class TransactionIdentifier extends Command
$this->count = 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/TransferCurrenciesCorrections.php
View File

@ -32,8 +32,6 @@ use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalCLIRepositoryInterface;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class TransferCurrenciesCorrections
@ -59,9 +57,6 @@ class TransferCurrenciesCorrections extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -114,10 +109,6 @@ class TransferCurrenciesCorrections extends Command
$this->destinationCurrency = null;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/UpgradeLiabilities.php
View File

@ -33,8 +33,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Services\Internal\Support\CreditRecalculateService;
use FireflyIII\User;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class UpgradeLiabilities
@ -49,9 +47,6 @@ class UpgradeLiabilities extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -67,10 +62,6 @@ class UpgradeLiabilities extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

9
app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php
View File

@ -34,8 +34,6 @@ use FireflyIII\Services\Internal\Destroy\TransactionGroupDestroyService;
use FireflyIII\Services\Internal\Support\CreditRecalculateService;
use FireflyIII\User;
use Illuminate\Console\Command;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class UpgradeLiabilitiesEight
@ -50,9 +48,6 @@ class UpgradeLiabilitiesEight extends Command
/**
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -67,10 +62,6 @@ class UpgradeLiabilitiesEight extends Command
return 0;
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function isExecuted(): bool
{
$configVar = app('fireflyconfig')->get(self::CONFIG_NAME, false);

2
app/Factory/TransactionJournalFactory.php
View File

@ -343,8 +343,6 @@ class TransactionJournalFactory
return $journal;
}
/**
* */
private function hashArray(NullArrayObject $row): string
{
$dataRow = $row->getArrayCopy();

6
app/Handlers/Events/VersionCheckEventHandler.php
View File

@ -28,8 +28,6 @@ use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Helpers\Update\UpdateTrait;
use FireflyIII\Models\Configuration;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class VersionCheckEventHandler
@ -42,8 +40,6 @@ class VersionCheckEventHandler
* Checks with GitHub to see if there is a new version.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*
* @deprecated ?
*/
@ -90,8 +86,6 @@ class VersionCheckEventHandler
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function warnToCheckForUpdates(RequestedVersionCheckStatus $event): void
{

8
app/Helpers/Fiscal/FiscalHelper.php
View File

@ -24,8 +24,6 @@ declare(strict_types=1);
namespace FireflyIII\Helpers\Fiscal;
use Carbon\Carbon;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class FiscalHelper.
@ -45,9 +43,6 @@ class FiscalHelper implements FiscalHelperInterface
/**
* @return Carbon date object
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function endOfFiscalYear(Carbon $date): Carbon
{
@ -68,9 +63,6 @@ class FiscalHelper implements FiscalHelperInterface
/**
* @return Carbon date object
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function startOfFiscalYear(Carbon $date): Carbon
{

5
app/Helpers/Update/UpdateTrait.php
View File

@ -24,8 +24,6 @@ declare(strict_types=1);
namespace FireflyIII\Helpers\Update;
use FireflyIII\Services\FireflyIIIOrg\Update\UpdateRequestInterface;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Trait UpdateTrait
@ -36,9 +34,6 @@ trait UpdateTrait
* Returns an array with info on the next release, if any.
* 'message' => 'A new version is available.
* 'level' => 'info' / 'success' / 'error'
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function getLatestRelease(): array
{

4
app/Http/Controllers/Account/CreateController.php
View File

@ -36,8 +36,6 @@ use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Facades\Log;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class CreateController
@ -131,8 +129,6 @@ class CreateController extends Controller
* @return Redirector|RedirectResponse
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function store(AccountFormRequest $request)
{

10
app/Http/Controllers/Account/IndexController.php
View File

@ -33,8 +33,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class IndexController
@ -69,9 +67,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function inactive(Request $request, string $objectType)
{
$inactivePage = true;
@ -124,9 +120,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function index(Request $request, string $objectType)
{
app('log')->debug(sprintf('Now at %s', __METHOD__));

6
app/Http/Controllers/Account/ReconcileController.php
View File

@ -39,8 +39,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ReconcileController.
@ -76,9 +74,7 @@ class ReconcileController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function reconcile(Account $account, Carbon $start = null, Carbon $end = null)
{
if (!$this->isEditableAccount($account)) {

10
app/Http/Controllers/Account/ShowController.php
View File

@ -36,8 +36,6 @@ use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ShowController
@ -76,9 +74,7 @@ class ShowController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function show(Request $request, Account $account, Carbon $start = null, Carbon $end = null)
{
$objectType = config(sprintf('firefly.shortNamesByFullName.%s', $account->accountType->type));
@ -161,9 +157,7 @@ class ShowController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function showAll(Request $request, Account $account)
{
if (!$this->isEditableAccount($account)) {

5
app/Http/Controllers/Admin/ConfigurationController.php
View File

@ -30,8 +30,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Facades\Log;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ConfigurationController.
@ -60,9 +58,6 @@ class ConfigurationController extends Controller
* Show configuration index.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index()
{

5
app/Http/Controllers/Admin/HomeController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Facades\Log;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class HomeController.
@ -55,9 +53,6 @@ class HomeController extends Controller
* Index of the admin.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index()
{

5
app/Http/Controllers/Admin/UpdateController.php
View File

@ -31,8 +31,6 @@ use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class HomeController.
@ -62,9 +60,6 @@ class UpdateController extends Controller
* Show page with update options.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index()
{

5
app/Http/Controllers/Admin/UserController.php
View File

@ -37,8 +37,6 @@ use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class UserController.
@ -153,9 +151,6 @@ class UserController extends Controller
* Show index of user manager.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index()
{

4
app/Http/Controllers/Auth/ForgotPasswordController.php
View File

@ -32,8 +32,6 @@ use Illuminate\Foundation\Auth\SendsPasswordResetEmails;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ForgotPasswordController
@ -100,8 +98,6 @@ class ForgotPasswordController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showLinkRequestForm()
{

4
app/Http/Controllers/Auth/LoginController.php
View File

@ -40,8 +40,6 @@ use Illuminate\Http\Response;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Facades\Log;
use Illuminate\Validation\ValidationException;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class LoginController
@ -173,8 +171,6 @@ class LoginController extends Controller
* @return Application|Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showLoginForm(Request $request)
{

4
app/Http/Controllers/Auth/RegisterController.php
View File

@ -114,9 +114,7 @@ class RegisterController extends Controller
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function showInviteForm(Request $request, string $code)
{
@ -148,9 +146,7 @@ class RegisterController extends Controller
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function showRegistrationForm(Request $request)
{

4
app/Http/Controllers/Auth/ResetPasswordController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Http\Request;
use Illuminate\Support\Facades\Password;
use Illuminate\Validation\ValidationException;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ResetPasswordController
@ -118,8 +116,6 @@ class ResetPasswordController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showResetForm(Request $request, $token = null)
{

4
app/Http/Controllers/Bill/IndexController.php
View File

@ -35,8 +35,6 @@ use Illuminate\Contracts\View\View;
use Illuminate\Foundation\Application;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Symfony\Component\HttpFoundation\ParameterBag;
/**
@ -156,8 +154,6 @@ class IndexController extends Controller
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function getSums(array $bills): array
{

5
app/Http/Controllers/Bill/ShowController.php
View File

@ -41,8 +41,6 @@ use Illuminate\View\View;
use League\Fractal\Manager;
use League\Fractal\Resource\Item;
use League\Fractal\Serializer\DataArraySerializer;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Symfony\Component\HttpFoundation\ParameterBag;
/**
@ -113,9 +111,6 @@ class ShowController extends Controller
* Show a bill.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Bill $bill)
{

6
app/Http/Controllers/Budget/IndexController.php
View File

@ -41,8 +41,6 @@ use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class IndexController
@ -86,9 +84,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function index(Carbon $start = null, Carbon $end = null)
{
$this->abRepository->cleanup();

12
app/Http/Controllers/Budget/ShowController.php
View File

@ -37,8 +37,6 @@ use FireflyIII\Support\Http\Controllers\PeriodOverview;
use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ShowController
@ -76,8 +74,6 @@ class ShowController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function noBudget(Request $request, Carbon $start = null, Carbon $end = null)
{
@ -112,9 +108,6 @@ class ShowController extends Controller
* Shows ALL transactions without a budget.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function noBudgetAll(Request $request)
{
@ -140,9 +133,6 @@ class ShowController extends Controller
* Show a single budget.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Budget $budget)
{
@ -176,8 +166,6 @@ class ShowController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showByBudgetLimit(Request $request, Budget $budget, BudgetLimit $budgetLimit)
{

5
app/Http/Controllers/Category/IndexController.php
View File

@ -31,8 +31,6 @@ use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class IndexController
@ -64,9 +62,6 @@ class IndexController extends Controller
* Show all categories.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Request $request)
{

7
app/Http/Controllers/Category/NoCategoryController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class NoCategoryController
@ -71,8 +69,6 @@ class NoCategoryController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Carbon $start = null, Carbon $end = null)
{
@ -109,9 +105,6 @@ class NoCategoryController extends Controller
* Show all transactions without a category.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showAll(Request $request)
{

7
app/Http/Controllers/Category/ShowController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ShowController
@ -72,8 +70,6 @@ class ShowController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Category $category, Carbon $start = null, Carbon $end = null)
{
@ -114,9 +110,6 @@ class ShowController extends Controller
* Show all transactions within a category.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showAll(Request $request, Category $category)
{

6
app/Http/Controllers/Chart/AccountController.php
View File

@ -40,8 +40,6 @@ use FireflyIII\Support\Http\Controllers\ChartGeneration;
use FireflyIII\Support\Http\Controllers\DateCalculation;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class AccountController.
@ -297,9 +295,7 @@ class AccountController extends Controller
* Shows the balances for all the user's frontpage accounts.
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function frontpage(AccountRepositoryInterface $repository): JsonResponse
{
$start = clone session('start', today(config('app.timezone'))->startOfMonth());

6
app/Http/Controllers/Chart/CategoryController.php
View File

@ -39,8 +39,6 @@ use FireflyIII\Support\Http\Controllers\ChartGeneration;
use FireflyIII\Support\Http\Controllers\DateCalculation;
use Illuminate\Http\JsonResponse;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class CategoryController.
@ -69,8 +67,6 @@ class CategoryController extends Controller
* TODO test method, for category refactor.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function all(Category $category): JsonResponse
{
@ -171,8 +167,6 @@ class CategoryController extends Controller
* TODO test me, for category refactor.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function specificPeriod(Category $category, Carbon $date): JsonResponse
{

6
app/Http/Controllers/DebugController.php
View File

@ -39,8 +39,6 @@ use Illuminate\Support\Facades\Artisan;
use Illuminate\Support\Facades\Log;
use Illuminate\View\View;
use Monolog\Handler\RotatingFileHandler;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class DebugController
@ -259,10 +257,6 @@ class DebugController extends Controller
];
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function getuserInfo(): array
{
$userFlags = $this->getUserFlags();

4
app/Http/Controllers/Export/IndexController.php
View File

@ -32,8 +32,6 @@ use FireflyIII\Support\Export\ExportDataGenerator;
use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Response as LaravelResponse;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class IndexController
@ -64,8 +62,6 @@ class IndexController extends Controller
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function export(): LaravelResponse
{

9
app/Http/Controllers/JavascriptController.php
View File

@ -33,8 +33,6 @@ use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface;
use FireflyIII\Support\Http\Controllers\GetConfigurationData;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class JavascriptController.
@ -45,9 +43,6 @@ class JavascriptController extends Controller
/**
* Show info about accounts.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function accounts(AccountRepositoryInterface $repository): Response
{
@ -97,9 +92,7 @@ class JavascriptController extends Controller
* Show some common variables to be used in scripts.
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function variables(Request $request, AccountRepositoryInterface $repository): Response
{
$account = $repository->find((int)$request->get('account'));

6
app/Http/Controllers/PreferencesController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Routing\Redirector;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class PreferencesController.
@ -65,8 +63,6 @@ class PreferencesController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(AccountRepositoryInterface $repository)
{
@ -174,8 +170,6 @@ class PreferencesController extends Controller
* @return Redirector|RedirectResponse
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function postIndex(Request $request)
{

10
app/Http/Controllers/ProfileController.php
View File

@ -50,8 +50,6 @@ use PragmaRX\Google2FA\Exceptions\IncompatibleWithGoogleAuthenticatorException;
use PragmaRX\Google2FA\Exceptions\InvalidCharactersException;
use PragmaRX\Google2FA\Exceptions\SecretKeyTooShortException;
use PragmaRX\Recovery\Recovery;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ProfileController.
@ -92,8 +90,6 @@ class ProfileController extends Controller
* @throws IncompatibleWithGoogleAuthenticatorException
* @throws InvalidCharactersException
* @throws SecretKeyTooShortException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function code(Request $request): Factory|RedirectResponse|View
{
@ -257,8 +253,6 @@ class ProfileController extends Controller
* Index for profile.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(): Factory|View
{
@ -455,8 +449,6 @@ class ProfileController extends Controller
* @return Redirector|RedirectResponse
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function postCode(TokenFormRequest $request)
{
@ -644,8 +636,6 @@ class ProfileController extends Controller
* TODO duplicate code.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function addToMFAHistory(string $mfaCode): void
{

4
app/Http/Controllers/Recurring/IndexController.php
View File

@ -34,8 +34,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Symfony\Component\HttpFoundation\ParameterBag;
/**
@ -74,8 +72,6 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Request $request)
{

5
app/Http/Controllers/ReportController.php
View File

@ -39,8 +39,6 @@ use Illuminate\Http\RedirectResponse;
use Illuminate\Routing\Redirector;
use Illuminate\Support\Collection;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ReportController.
@ -236,9 +234,6 @@ class ReportController extends Controller
* Show index.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(AccountRepositoryInterface $repository)
{

7
app/Http/Controllers/TagController.php
View File

@ -35,8 +35,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class TagController.
@ -215,8 +213,6 @@ class TagController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Tag $tag, Carbon $start = null, Carbon $end = null)
{
@ -260,9 +256,6 @@ class TagController extends Controller
* Show a single tag over all time.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showAll(Request $request, Tag $tag)
{

6
app/Http/Controllers/Transaction/CreateController.php
View File

@ -33,8 +33,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Contracts\View\View;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class CreateController
@ -98,9 +96,7 @@ class CreateController extends Controller
* @return Factory|View
*
* @throws FireflyException
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
* */
public function create(?string $objectType)
{
app('preferences')->mark();

7
app/Http/Controllers/Transaction/IndexController.php
View File

@ -32,8 +32,6 @@ use FireflyIII\Support\Http\Controllers\PeriodOverview;
use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class IndexController
@ -70,8 +68,6 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Request $request, string $objectType, Carbon $start = null, Carbon $end = null)
{
@ -126,9 +122,6 @@ class IndexController extends Controller
* Index for ALL transactions.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function indexAll(Request $request, string $objectType)
{

5
app/Http/Controllers/TransactionCurrency/IndexController.php
View File

@ -33,8 +33,6 @@ use Illuminate\Contracts\View\Factory;
use Illuminate\Http\Request;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\View\View;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
class IndexController extends Controller
{
@ -64,9 +62,6 @@ class IndexController extends Controller
* Show overview of currencies.
*
* @return Factory|View
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Request $request)
{

2
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@ -84,8 +84,6 @@ trait ModifiesPiggyBanks
return true;
}
/**
* */
public function canAddAmount(PiggyBank $piggyBank, string $amount): bool
{
$today = today(config('app.timezone'));

12
app/Repositories/Tag/OperationsRepository.php
View File

@ -30,8 +30,6 @@ use FireflyIII\Models\TransactionType;
use FireflyIII\User;
use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class OperationsRepository
@ -45,9 +43,6 @@ class OperationsRepository implements OperationsRepositoryInterface
* This method returns a list of all the withdrawal transaction journals (as arrays) set in that period
* which have the specified tag(s) set to them. It's grouped per currency, with as few details in the array
* as possible. Amounts are always negative.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function listExpenses(Carbon $start, Carbon $end, ?Collection $accounts = null, ?Collection $tags = null): array
{
@ -123,9 +118,6 @@ class OperationsRepository implements OperationsRepositoryInterface
* This method returns a list of all the deposit transaction journals (as arrays) set in that period
* which have the specified tag(s) set to them. It's grouped per currency, with as few details in the array
* as possible. Amounts are always positive.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function listIncome(Carbon $start, Carbon $end, ?Collection $accounts = null, ?Collection $tags = null): array
{
@ -211,10 +203,6 @@ class OperationsRepository implements OperationsRepositoryInterface
throw new FireflyException(sprintf('%s is not yet implemented.', __METHOD__));
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function getTags(): Collection
{
$repository = app(TagRepositoryInterface::class);

2
app/Services/Internal/Support/AccountServiceTrait.php
View File

@ -188,7 +188,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* *
* *
* @deprecated
*/
protected function createOBGroup(Account $account, array $data): TransactionGroup

2
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@ -162,8 +162,6 @@ trait RecurringTransactionTrait
}
}
/**
* */
protected function findAccount(array $expectedTypes, ?int $accountId, ?string $accountName): Account
{
$result = null;

5
app/Support/Authentication/RemoteUserGuard.php
View File

@ -31,8 +31,6 @@ use Illuminate\Contracts\Auth\Guard;
use Illuminate\Contracts\Auth\UserProvider;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Http\Request;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class RemoteUserGuard
@ -45,9 +43,6 @@ class RemoteUserGuard implements Guard
/**
* Create a new authentication guard.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function __construct(UserProvider $provider, Application $app)
{

4
app/Support/Cronjobs/BillWarningCronjob.php
View File

@ -27,8 +27,6 @@ use Carbon\Carbon;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Jobs\WarnAboutBills;
use FireflyIII\Models\Configuration;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class BillWarningCronjob
@ -37,8 +35,6 @@ class BillWarningCronjob extends AbstractCronjob
{
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function fire(): void
{

4
app/Support/Cronjobs/RecurringCronjob.php
View File

@ -27,8 +27,6 @@ use Carbon\Carbon;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Jobs\CreateRecurringTransactions;
use FireflyIII\Models\Configuration;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class RecurringCronjob
@ -37,8 +35,6 @@ class RecurringCronjob extends AbstractCronjob
{
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function fire(): void
{

6
app/Support/Export/ExportDataGenerator.php
View File

@ -56,8 +56,6 @@ use Illuminate\Support\Collection;
use League\Csv\CannotInsertRecord;
use League\Csv\Exception;
use League\Csv\Writer;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class ExportDataGenerator
@ -100,9 +98,7 @@ class ExportDataGenerator
}
/**
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public function export(): array
{
@ -871,10 +867,8 @@ class ExportDataGenerator
/**
* @throws CannotInsertRecord
* @throws ContainerExceptionInterface
* @throws Exception
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
private function exportTags(): string
{

10
app/Support/Http/Controllers/CronRunner.php
View File

@ -29,18 +29,12 @@ use FireflyIII\Support\Cronjobs\AutoBudgetCronjob;
use FireflyIII\Support\Cronjobs\BillWarningCronjob;
use FireflyIII\Support\Cronjobs\ExchangeRatesCronjob;
use FireflyIII\Support\Cronjobs\RecurringCronjob;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Trait CronRunner
*/
trait CronRunner
{
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function billWarningCronJob(bool $force, Carbon $date): array
{
/** @var BillWarningCronjob $billWarning */
@ -119,10 +113,6 @@ trait CronRunner
];
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function runRecurring(bool $force, Carbon $date): array
{
/** @var RecurringCronjob $recurring */

4
app/Support/Http/Controllers/GetConfigurationData.php
View File

@ -25,8 +25,6 @@ namespace FireflyIII\Support\Http\Controllers;
use Carbon\Carbon;
use FireflyIII\Exceptions\FireflyException;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Trait GetConfigurationData
@ -79,8 +77,6 @@ trait GetConfigurationData
* Get config for date range.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getDateRangeConfig(): array // get configuration + get preferences.
{

14
app/Support/Http/Controllers/PeriodOverview.php
View File

@ -33,8 +33,6 @@ use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use FireflyIII\Support\CacheProperties;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Trait PeriodOverview.
@ -73,8 +71,6 @@ trait PeriodOverview
* performance reasons.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getAccountPeriodOverview(Account $account, Carbon $start, Carbon $end): array
{
@ -147,8 +143,6 @@ trait PeriodOverview
* Overview for single category. Has been refactored recently.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getCategoryPeriodOverview(Category $category, Carbon $start, Carbon $end): array
{
@ -224,8 +218,6 @@ trait PeriodOverview
* This method has been refactored recently.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getNoBudgetPeriodOverview(Carbon $start, Carbon $end): array
{
@ -277,8 +269,6 @@ trait PeriodOverview
* Show period overview for no category view.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getNoCategoryPeriodOverview(Carbon $theDate): array
{
@ -344,8 +334,6 @@ trait PeriodOverview
* This shows a period overview for a tag. It goes back in time and lists all relevant transactions and sums.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getTagPeriodOverview(Tag $tag, Carbon $start, Carbon $end): array // period overview for tags.
{
@ -415,8 +403,6 @@ trait PeriodOverview
/**
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
protected function getTransactionPeriodOverview(string $transactionType, Carbon $start, Carbon $end): array
{

5
app/Support/Http/Controllers/RequestInformation.php
View File

@ -32,8 +32,6 @@ use FireflyIII\User;
use Illuminate\Contracts\Validation\Validator as ValidatorContract;
use Illuminate\Routing\Route;
use Illuminate\Support\Facades\Validator;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Route as RouteFacade;
/**
@ -77,9 +75,6 @@ trait RequestInformation
/**
* Returns if user has seen demo.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
final protected function hasSeenDemo(): bool // get request info + get preference
{

5
app/Support/Navigation.php
View File

@ -30,8 +30,6 @@ use FireflyIII\Helpers\Fiscal\FiscalHelperInterface;
use FireflyIII\Support\Calendar\Calculator;
use FireflyIII\Support\Calendar\Periodicity;
use Illuminate\Support\Facades\Log;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class Navigation.
@ -395,9 +393,6 @@ class Navigation
/**
* Returns the user's view range and if necessary, corrects the dynamic view
* range to a normal range.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function getViewRange(bool $correct): string
{

6
app/Support/Search/OperatorQuerySearch.php
View File

@ -56,8 +56,6 @@ use Gdbots\QueryParser\Node\Word;
use Gdbots\QueryParser\QueryParser;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class OperatorQuerySearch
@ -2722,10 +2720,6 @@ class OperatorQuerySearch implements SearchInterface
}
}
/**
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
private function parseTagInstructions(): void
{
app('log')->debug('Now in parseTagInstructions()');

4
app/Support/Steam.php
View File

@ -32,8 +32,6 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Support\Http\Api\ExchangeRateConverter;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Log;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
/**
* Class Steam.
@ -730,8 +728,6 @@ class Steam
* Get user's language.
*
* @throws FireflyException
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function getLanguage(): string // get preference
{

2
app/Support/System/OAuthKeys.php
View File

@ -100,9 +100,7 @@ class OAuthKeys
}
/**
* @throws ContainerExceptionInterface
* @throws FireflyException
* @throws NotFoundExceptionInterface
*/
public static function restoreKeysFromDB(): bool
{

5
app/User.php
View File

@ -71,8 +71,6 @@ use Illuminate\Support\Str;
use Laravel\Passport\Client;
use Laravel\Passport\HasApiTokens;
use Laravel\Passport\Token;
use Psr\Container\ContainerExceptionInterface;
use Psr\Container\NotFoundExceptionInterface;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
/**
@ -458,9 +456,6 @@ class User extends Authenticatable
/**
* Route notifications for the Slack channel.
*
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function routeNotificationForSlack(Notification $notification): string
{

2
app/Validation/Api/Data/Bulk/ValidatesBulkTransactionQuery.php
View File

@ -29,8 +29,6 @@ use Illuminate\Validation\Validator;
trait ValidatesBulkTransactionQuery
{
/**
* */
protected function validateTransactionQuery(Validator $validator): void
{
$data = $validator->getData();