From ce5beeaf2c1828d06e4c484202c5affc0da6467d Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 17 Jul 2015 17:35:04 +0200 Subject: [PATCH] Better compare for amounts because floatval can be inaccurate. --- app/Repositories/Journal/JournalRepository.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Repositories/Journal/JournalRepository.php b/app/Repositories/Journal/JournalRepository.php index ab71355313..eebbbf205a 100644 --- a/app/Repositories/Journal/JournalRepository.php +++ b/app/Repositories/Journal/JournalRepository.php @@ -252,13 +252,13 @@ class JournalRepository implements JournalRepositoryInterface // update the from and to transaction. /** @var Transaction $transaction */ foreach ($journal->transactions()->get() as $transaction) { - if (floatval($transaction->amount) < 0) { + if ($transaction->amount < 0) { // this is the from transaction, negative amount: $transaction->amount = $data['amount'] * -1; $transaction->account_id = $fromAccount->id; $transaction->save(); } - if (floatval($transaction->amount) > 0) { + if ($transaction->amount > 0) { $transaction->amount = $data['amount']; $transaction->account_id = $toAccount->id; $transaction->save();