Restore todo's

app/Services/Internal/Support/AccountServiceTrait.php

@@ -100,9 +100,9 @@ trait AccountServiceTrait
     }
 
     /**
-     * Update meta data for account. Depends on type which fields are valid.
+     * Update metadata for account. Depends on type which fields are valid.
      *
-     * See reference nr. 97
+     * TODO this method treats expense accounts and liabilities the same way (tries to save interest)
      *
      * @param Account $account
      * @param array   $data
@@ -525,7 +525,7 @@ trait AccountServiceTrait
     }
 
     /**
-     * See reference nr. 99
+     * TODO refactor to "getfirstjournal"
      *
      * @param TransactionGroup $group
      *
@@ -544,7 +544,7 @@ trait AccountServiceTrait
     }
 
     /**
-     * See reference nr. 98
+     * TODO Rename to getOpposingTransaction
      *
      * @param TransactionJournal $journal
      * @param Account            $account

app/Services/Internal/Support/RecurringTransactionTrait.php

@@ -148,7 +148,7 @@ trait RecurringTransactionTrait
             if (array_key_exists('foreign_amount', $array) && '' === (string) $array['foreign_amount']) {
                 unset($array['foreign_amount']);
             }
-            // See reference nr. 100
+            // TODO typeOverrule. The account validator may have a different opinion on the type of the transaction.
             $transaction = new RecurrenceTransaction(
                 [
                     'recurrence_id'           => $recurrence->id,

app/Services/Internal/Update/AccountUpdateService.php

@@ -35,7 +35,7 @@ use Log;
 
 /**
  * Class AccountUpdateService
- * See reference nr. 90
+ * TODO this service is messy and convoluted.
  */
 class AccountUpdateService
 {

app/Services/Internal/Update/JournalUpdateService.php

@@ -219,7 +219,7 @@ class JournalUpdateService
         $result = $validator->validateSource(['id' => $sourceId]);
         Log::debug(sprintf('hasValidSourceAccount(%d, "%s") will return %s', $sourceId, $sourceName, var_export($result, true)));
 
-        // See reference nr. 95
+        // TODO typeoverrule the account validator may have a different opinion on the transaction type.
 
         // validate submitted info:
         return $result;
@@ -313,7 +313,7 @@ class JournalUpdateService
         $result            = $validator->validateDestination(['id' => $destId]);
         Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true)));
 
-        // See reference nr. 96
+        // TODO typeOverrule: the account validator may have another opinion on the transaction type.
 
         // validate submitted info:
         return $result;

app/Services/Internal/Update/RecurrenceUpdateService.php

@@ -49,7 +49,7 @@ class RecurrenceUpdateService
     /**
      * Updates a recurrence.
      *
-     * See reference nr. 88
+     * TODO if the user updates the type, the accounts must be validated again.
      *
      * @param Recurrence $recurrence
      * @param array      $data
@@ -217,7 +217,7 @@ class RecurrenceUpdateService
     }
 
     /**
-     * See reference nr. 89
+     * TODO this method is very complex.
      *
      * @param Recurrence $recurrence
      * @param array      $transactions