Restore todo's

This commit is contained in:
James Cole
2022-10-30 11:43:17 +01:00
parent e3181e90df
commit d28326cc89
64 changed files with 102 additions and 104 deletions
@@ -35,7 +35,7 @@ use Log;
/**
* Class AccountUpdateService
* See reference nr. 90
* TODO this service is messy and convoluted.
*/
class AccountUpdateService
{
@@ -219,7 +219,7 @@ class JournalUpdateService
$result = $validator->validateSource(['id' => $sourceId]);
Log::debug(sprintf('hasValidSourceAccount(%d, "%s") will return %s', $sourceId, $sourceName, var_export($result, true)));
// See reference nr. 95
// TODO typeoverrule the account validator may have a different opinion on the transaction type.
// validate submitted info:
return $result;
@@ -313,7 +313,7 @@ class JournalUpdateService
$result = $validator->validateDestination(['id' => $destId]);
Log::debug(sprintf('hasValidDestinationAccount(%d, "%s") will return %s', $destId, $destName, var_export($result, true)));
// See reference nr. 96
// TODO typeOverrule: the account validator may have another opinion on the transaction type.
// validate submitted info:
return $result;
@@ -49,7 +49,7 @@ class RecurrenceUpdateService
/**
* Updates a recurrence.
*
* See reference nr. 88
* TODO if the user updates the type, the accounts must be validated again.
*
* @param Recurrence $recurrence
* @param array $data
@@ -217,7 +217,7 @@ class RecurrenceUpdateService
}
/**
* See reference nr. 89
* TODO this method is very complex.
*
* @param Recurrence $recurrence
* @param array $transactions