IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Catch exceptions in FixerIO

Browse Source
This commit is contained in:
James Cole 2017-09-29 15:32:35 +02:00
parent a34d888024
commit d306183c95
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
app/Services/Currency/FixerIO.php
View File

@ -18,6 +18,7 @@ use FireflyIII\Models\TransactionCurrency;
use FireflyIII\User; use FireflyIII\User;
use Log; use Log;
use Requests; use Requests;
use Requests_Exception;
/** /**
* Class FixerIO * Class FixerIO
@ -31,16 +32,26 @@ class FixerIO implements ExchangeRateInterface
public function getRate(TransactionCurrency $fromCurrency, TransactionCurrency $toCurrency, Carbon $date): CurrencyExchangeRate public function getRate(TransactionCurrency $fromCurrency, TransactionCurrency $toCurrency, Carbon $date): CurrencyExchangeRate
{ {
$uri = sprintf('https://api.fixer.io/%s?base=%s&symbols=%s', $date->format('Y-m-d'), $fromCurrency->code, $toCurrency->code); $uri = sprintf('https://api.fixer.io/%s?base=%s&symbols=%s', $date->format('Y-m-d'), $fromCurrency->code, $toCurrency->code);
$result = Requests::get($uri); $statusCode = -1;
$body = '';
try {
$result = Requests::get($uri);
$statusCode = $result->status_code;
$body = $result->body;
} catch (Requests_Exception $e) {
// don't care about error
$body = sprintf('Requests_Exception: %s', $e->getMessage());
}
// Requests_Exception
$rate = 1.0; $rate = 1.0;
$content = null; $content = null;
if ($result->status_code !== 200) { if ($statusCode !== 200) {
Log::error(sprintf('Something went wrong. Received error code %d and body "%s" from FixerIO.', $result->status_code, $result->body)); Log::error(sprintf('Something went wrong. Received error code %d and body "%s" from FixerIO.', $statusCode, $body));
} }
// get rate from body: // get rate from body:
if ($result->status_code === 200) { if ($statusCode === 200) {
$content = json_decode($result->body, true); $content = json_decode($body, true);
} }
if (!is_null($content)) { if (!is_null($content)) {
$code = $toCurrency->code; $code = $toCurrency->code;