diff --git a/app/TransactionRules/Actions/ConvertToDeposit.php b/app/TransactionRules/Actions/ConvertToDeposit.php index 6892c22783..cb4fbd3575 100644 --- a/app/TransactionRules/Actions/ConvertToDeposit.php +++ b/app/TransactionRules/Actions/ConvertToDeposit.php @@ -22,6 +22,7 @@ declare(strict_types=1); namespace FireflyIII\TransactionRules\Actions; + use DB; use FireflyIII\Exceptions\FireflyException; use FireflyIII\Factory\AccountFactory; diff --git a/app/TransactionRules/Actions/ConvertToTransfer.php b/app/TransactionRules/Actions/ConvertToTransfer.php index 03350c696d..c9a4bf1904 100644 --- a/app/TransactionRules/Actions/ConvertToTransfer.php +++ b/app/TransactionRules/Actions/ConvertToTransfer.php @@ -22,11 +22,11 @@ declare(strict_types=1); namespace FireflyIII\TransactionRules\Actions; + use DB; use FireflyIII\Models\Account; use FireflyIII\Models\AccountType; use FireflyIII\Models\RuleAction; -use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionType; use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\User; @@ -55,8 +55,8 @@ class ConvertToTransfer implements ActionInterface */ public function actOnArray(array $journal): bool { - $type = $journal['transaction_type_type']; - $user = User::find($journal['user_id']); + $type = $journal['transaction_type_type']; + $user = User::find($journal['user_id']); if (TransactionType::TRANSFER === $type) { Log::error( sprintf('Journal #%d is already a transfer so cannot be converted (rule #%d).', $journal['transaction_journal_id'], $this->action->rule_id) diff --git a/app/TransactionRules/Actions/ConvertToWithdrawal.php b/app/TransactionRules/Actions/ConvertToWithdrawal.php index 1303ec642c..2781206d7c 100644 --- a/app/TransactionRules/Actions/ConvertToWithdrawal.php +++ b/app/TransactionRules/Actions/ConvertToWithdrawal.php @@ -22,6 +22,7 @@ declare(strict_types=1); namespace FireflyIII\TransactionRules\Actions; + use DB; use FireflyIII\Exceptions\FireflyException; use FireflyIII\Factory\AccountFactory; diff --git a/app/TransactionRules/Actions/DeleteTransaction.php b/app/TransactionRules/Actions/DeleteTransaction.php index c372216f4f..29c9c7739c 100644 --- a/app/TransactionRules/Actions/DeleteTransaction.php +++ b/app/TransactionRules/Actions/DeleteTransaction.php @@ -58,7 +58,7 @@ class DeleteTransaction implements ActionInterface $journal['transaction_journal_id'], $journal['description'] ) ); - $group = TransactionGroup::find($journal['transaction_group_id']); + $group = TransactionGroup::find($journal['transaction_group_id']); $service = app(TransactionGroupDestroyService::class); $service->destroy($group); diff --git a/app/TransactionRules/Actions/LinkToBill.php b/app/TransactionRules/Actions/LinkToBill.php index 8e8726b512..c813ef58eb 100644 --- a/app/TransactionRules/Actions/LinkToBill.php +++ b/app/TransactionRules/Actions/LinkToBill.php @@ -78,6 +78,7 @@ class LinkToBill implements ActionInterface $journal['transaction_journal_id'], $billName ) ); + return false; } } diff --git a/app/TransactionRules/Actions/RemoveAllTags.php b/app/TransactionRules/Actions/RemoveAllTags.php index f373786eec..1bdff35085 100644 --- a/app/TransactionRules/Actions/RemoveAllTags.php +++ b/app/TransactionRules/Actions/RemoveAllTags.php @@ -25,6 +25,7 @@ namespace FireflyIII\TransactionRules\Actions; use DB; use FireflyIII\Models\RuleAction; use Log; + /** * Class RemoveAllTags. */ diff --git a/app/TransactionRules/Actions/SetBudget.php b/app/TransactionRules/Actions/SetBudget.php index 73d032004d..2e149065dd 100644 --- a/app/TransactionRules/Actions/SetBudget.php +++ b/app/TransactionRules/Actions/SetBudget.php @@ -50,7 +50,7 @@ class SetBudget implements ActionInterface */ public function actOnArray(array $journal): bool { - $user = User::find($journal['user_id']); + $user = User::find($journal['user_id']); $search = $this->action->action_value; $budget = $user->budgets()->where('name', $search)->first(); diff --git a/app/TransactionRules/Actions/SetCategory.php b/app/TransactionRules/Actions/SetCategory.php index 4b2f5a6d1e..118d5186b7 100644 --- a/app/TransactionRules/Actions/SetCategory.php +++ b/app/TransactionRules/Actions/SetCategory.php @@ -50,7 +50,7 @@ class SetCategory implements ActionInterface */ public function actOnArray(array $journal): bool { - $user = User::find($journal['user_id']); + $user = User::find($journal['user_id']); $search = $this->action->action_value; if (null === $user) { Log::error(sprintf('Journal has no valid user ID so action SetCategory("%s") cannot be applied', $search), $journal); diff --git a/app/TransactionRules/Actions/UpdatePiggybank.php b/app/TransactionRules/Actions/UpdatePiggybank.php index 84fa7917ea..121da9fd18 100644 --- a/app/TransactionRules/Actions/UpdatePiggybank.php +++ b/app/TransactionRules/Actions/UpdatePiggybank.php @@ -21,7 +21,9 @@ */ declare(strict_types=1); + namespace FireflyIII\TransactionRules\Actions; + use FireflyIII\Models\PiggyBank; use FireflyIII\Models\RuleAction; use FireflyIII\Models\Transaction;