IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

added some comments

Browse Source
This commit is contained in:
Tom van der Werf 2016-10-04 17:50:01 +00:00
parent dc22802dec
commit d7fef45a56
1 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
app/Import/Specifics/IngDescription.php
View File

@ -16,7 +16,9 @@ namespace FireflyIII\Import\Specifics;
* *
* Parses the description from CSV files for Ing bank accounts. * Parses the description from CSV files for Ing bank accounts.
* *
* With Mutation 'InternetBankieren', 'Incasso' and Overschrijving remove Name and IBAN from description * With Mutation 'InternetBankieren', 'Overschrijving', 'Verzamelbetaling' and 'Incasso' the
* Name of Opposing account the Opposing IBAN number are in the Description
* This class will remove them
* Add Name in description by 'Betaalautomaat' so those are easily recognizable * Add Name in description by 'Betaalautomaat' so those are easily recognizable
* *
* @package FireflyIII\Import\Specifics * @package FireflyIII\Import\Specifics
@ -31,7 +33,7 @@ class IngDescription implements SpecificInterface
*/ */
public static function getDescription(): string public static function getDescription(): string
{ {
return 'Fixes Ing descriptions.'; return 'Create better descriptions in ING import files.';
} }
/** /**
@ -39,7 +41,7 @@ class IngDescription implements SpecificInterface
*/ */
public static function getName(): string public static function getName(): string
{ {
return 'Ing description'; return 'ING description';
} }
/** /**
@ -50,56 +52,56 @@ class IngDescription implements SpecificInterface
public function run(array $row): array public function run(array $row): array
{ {
$this->row = $row; $this->row = $row;
if (count($this->row) >= 8) { // check if the array is correct if (count($this->row) >= 8) { // check if the array is correct
switch ($this->row[4]) { //update Decription only for the next Mutations switch ($this->row[4]) { // Get value for the mutation type
case 'GT': // InternetBanieren case 'GT': // InternetBanieren
case 'OV': // OV case 'OV': // Overschrijving
case 'VZ': // Verzamelbetaling case 'VZ': // Verzamelbetaling
case 'IC'://Incasso case 'IC': // Incasso
$this->removeIBANIngDescription(); $this->removeIBANIngDescription();
$this->removeNameIngDescription(); $this->removeNameIngDescription();
break; break;
case 'BA' ://Betaalautomaat case 'BA' : // Betaalautomaat
$this->addNameIngDescription(); $this->addNameIngDescription();
break; break;
} }
} }
//var_dump($this->row);die;
return $this->row; return $this->row;
} }
/** /**
* Parses the current description without the IBAN in the description * Remove IBAN number out of the description
* Default description of Description is: Naam: <OPPOS NAME> Omschrijving: <DESCRIPTION> IBAN: <OPPOS IBAN NR>
* *
* @return always true * @return bool true
*/ */
protected function removeIBANIngDescription() protected function removeIBANIngDescription()
{ {
// Try remove the iban number from the third cell 'IBAN: NL00XXXX0000000 ' // Try replace the iban number with nothing. The IBAN nr is found in the third row
$this->row[8] = preg_replace('/\sIBAN:\s'.$this->row[3].'/', '', $this->row[8]); $this->row[8] = preg_replace('/\sIBAN:\s'.$this->row[3].'/', '', $this->row[8]);
return true; return true;
} }
/** /**
* Parses the current description without the name * Remove name from the description (Remove everything before the description incl the word 'Omschrijving' )
* *
* @return bool always true * @return bool true
*/ */
protected function removeNameIngDescription() protected function removeNameIngDescription()
{ {
// Try remove the name // Try remove everything bevore the 'Omschrijving'
$this->row[8] = preg_replace('/.+Omschrijving: /', '', $this->row[8]); $this->row[8] = preg_replace('/.+Omschrijving: /', '', $this->row[8]);
return true; return true;
} }
/** /**
* Parses the current description without the name and IBAN * Add the Opposing name from cell 1 in the description for Betaalautomaten
* Otherwise the description is only: 'Pasvolgnr:<nr> <date> Transactie:<NR> Term:<nr>'
* *
* @return bool true if the description is GEA/BEA-format, false otherwise * @return bool true
*/ */
protected function addNameIngDescription() protected function addNameIngDescription()
{ {