Code cleanup that (hopefully) matches style CI

This commit is contained in:
James Cole 2020-03-17 14:53:17 +01:00
parent 64462812fc
commit e02e747f1b
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
42 changed files with 221 additions and 219 deletions

View File

@ -92,8 +92,8 @@ class AttachmentController extends Controller
* @param Attachment $attachment * @param Attachment $attachment
* *
* @codeCoverageIgnore * @codeCoverageIgnore
* @return LaravelResponse
* @throws FireflyException * @throws FireflyException
* @return LaravelResponse
*/ */
public function download(Attachment $attachment): LaravelResponse public function download(Attachment $attachment): LaravelResponse
{ {
@ -184,8 +184,8 @@ class AttachmentController extends Controller
* *
* @param AttachmentStoreRequest $request * @param AttachmentStoreRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(AttachmentStoreRequest $request): JsonResponse public function store(AttachmentStoreRequest $request): JsonResponse
{ {

View File

@ -206,8 +206,8 @@ class BillController extends Controller
* *
* @param BillRequest $request * @param BillRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(BillRequest $request): JsonResponse public function store(BillRequest $request): JsonResponse
{ {

View File

@ -182,9 +182,9 @@ class BudgetController extends Controller
* *
* @param BudgetStoreRequest $request * @param BudgetStoreRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* *
* @return JsonResponse
*/ */
public function store(BudgetStoreRequest $request): JsonResponse public function store(BudgetStoreRequest $request): JsonResponse
{ {
@ -206,8 +206,8 @@ class BudgetController extends Controller
* @param BudgetLimitRequest $request * @param BudgetLimitRequest $request
* @param Budget $budget * @param Budget $budget
* *
* @return JsonResponse
* @throws Exception * @throws Exception
* @return JsonResponse
*/ */
public function storeBudgetLimit(BudgetLimitRequest $request, Budget $budget): JsonResponse public function storeBudgetLimit(BudgetLimitRequest $request, Budget $budget): JsonResponse
{ {

View File

@ -156,9 +156,9 @@ class BudgetLimitController extends Controller
* *
* @param BudgetLimitRequest $request * @param BudgetLimitRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* *
* @return JsonResponse
*/ */
public function store(BudgetLimitRequest $request): JsonResponse public function store(BudgetLimitRequest $request): JsonResponse
{ {

View File

@ -146,8 +146,8 @@ class CategoryController extends Controller
* *
* @param CategoryRequest $request * @param CategoryRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(CategoryRequest $request): JsonResponse public function store(CategoryRequest $request): JsonResponse
{ {

View File

@ -302,9 +302,9 @@ class CurrencyController extends Controller
* *
* @param TransactionCurrency $currency * @param TransactionCurrency $currency
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @codeCoverageIgnore * @codeCoverageIgnore
* @return JsonResponse
*/ */
public function delete(TransactionCurrency $currency): JsonResponse public function delete(TransactionCurrency $currency): JsonResponse
{ {
@ -572,8 +572,8 @@ class CurrencyController extends Controller
* *
* @param CurrencyRequest $request * @param CurrencyRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(CurrencyRequest $request): JsonResponse public function store(CurrencyRequest $request): JsonResponse
{ {

View File

@ -69,8 +69,8 @@ class CurrencyExchangeRateController extends Controller
* *
* @param Request $request * @param Request $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function index(Request $request): JsonResponse public function index(Request $request): JsonResponse
{ {

View File

@ -40,6 +40,7 @@ use League\Fractal\Resource\Item;
/** /**
* Class ImportController * Class ImportController
*
* @deprecated * @deprecated
* @codeCoverageIgnore * @codeCoverageIgnore
*/ */

View File

@ -79,9 +79,9 @@ class LinkTypeController extends Controller
* *
* @param LinkType $linkType * @param LinkType $linkType
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @codeCoverageIgnore * @codeCoverageIgnore
* @return JsonResponse
*/ */
public function delete(LinkType $linkType): JsonResponse public function delete(LinkType $linkType): JsonResponse
{ {
@ -151,8 +151,8 @@ class LinkTypeController extends Controller
* *
* @param LinkTypeRequest $request * @param LinkTypeRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(LinkTypeRequest $request): JsonResponse public function store(LinkTypeRequest $request): JsonResponse
{ {
@ -241,8 +241,8 @@ class LinkTypeController extends Controller
* @param LinkTypeRequest $request * @param LinkTypeRequest $request
* @param LinkType $linkType * @param LinkType $linkType
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function update(LinkTypeRequest $request, LinkType $linkType): JsonResponse public function update(LinkTypeRequest $request, LinkType $linkType): JsonResponse
{ {

View File

@ -175,8 +175,8 @@ class PiggyBankController extends Controller
* *
* @param PiggyBankRequest $request * @param PiggyBankRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(PiggyBankRequest $request): JsonResponse public function store(PiggyBankRequest $request): JsonResponse
{ {

View File

@ -149,8 +149,8 @@ class RecurrenceController extends Controller
* *
* @param RecurrenceStoreRequest $request * @param RecurrenceStoreRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(RecurrenceStoreRequest $request): JsonResponse public function store(RecurrenceStoreRequest $request): JsonResponse
{ {
@ -224,9 +224,9 @@ class RecurrenceController extends Controller
} }
/** /**
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @codeCoverageIgnore * @codeCoverageIgnore
* @return JsonResponse
*/ */
public function trigger(): JsonResponse public function trigger(): JsonResponse
{ {

View File

@ -214,8 +214,8 @@ class RuleController extends Controller
* @param RuleTestRequest $request * @param RuleTestRequest $request
* @param Rule $rule * @param Rule $rule
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function testRule(RuleTestRequest $request, Rule $rule): JsonResponse public function testRule(RuleTestRequest $request, Rule $rule): JsonResponse
{ {

View File

@ -246,9 +246,9 @@ class RuleGroupController extends Controller
* @param RuleGroupTestRequest $request * @param RuleGroupTestRequest $request
* @param RuleGroup $group * @param RuleGroup $group
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* *
* @return JsonResponse
*/ */
public function testGroup(RuleGroupTestRequest $request, RuleGroup $group): JsonResponse public function testGroup(RuleGroupTestRequest $request, RuleGroup $group): JsonResponse
{ {
@ -305,8 +305,8 @@ class RuleGroupController extends Controller
* @param RuleGroupTriggerRequest $request * @param RuleGroupTriggerRequest $request
* @param RuleGroup $group * @param RuleGroup $group
* *
* @return JsonResponse
* @throws Exception * @throws Exception
* @return JsonResponse
*/ */
public function triggerGroup(RuleGroupTriggerRequest $request, RuleGroup $group): JsonResponse public function triggerGroup(RuleGroupTriggerRequest $request, RuleGroup $group): JsonResponse
{ {

View File

@ -96,8 +96,8 @@ class SummaryController extends Controller
/** /**
* @param DateRequest $request * @param DateRequest $request
* *
* @return JsonResponse
* @throws Exception * @throws Exception
* @return JsonResponse
*/ */
public function basic(DateRequest $request): JsonResponse public function basic(DateRequest $request): JsonResponse
{ {
@ -317,8 +317,8 @@ class SummaryController extends Controller
* @param Carbon $start * @param Carbon $start
* @param Carbon $end * @param Carbon $end
* *
* @return array
* @throws Exception * @throws Exception
* @return array
*/ */
private function getLeftToSpendInfo(Carbon $start, Carbon $end): array private function getLeftToSpendInfo(Carbon $start, Carbon $end): array
{ {
@ -361,6 +361,7 @@ class SummaryController extends Controller
), ),
]; ];
} }
return $return; return $return;
} }

View File

@ -25,8 +25,8 @@ namespace FireflyIII\Api\V1\Controllers;
use Carbon\Carbon; use Carbon\Carbon;
use FireflyIII\Api\V1\Requests\DateRequest; use FireflyIII\Api\V1\Requests\DateRequest;
use FireflyIII\Api\V1\Requests\TagUpdateRequest;
use FireflyIII\Api\V1\Requests\TagStoreRequest; use FireflyIII\Api\V1\Requests\TagStoreRequest;
use FireflyIII\Api\V1\Requests\TagUpdateRequest;
use FireflyIII\Helpers\Collector\GroupCollectorInterface; use FireflyIII\Helpers\Collector\GroupCollectorInterface;
use FireflyIII\Models\Tag; use FireflyIII\Models\Tag;
use FireflyIII\Repositories\Tag\TagRepositoryInterface; use FireflyIII\Repositories\Tag\TagRepositoryInterface;

View File

@ -302,7 +302,7 @@ class TransactionController extends Controller
$response = [ $response = [
'message' => 'The given data was invalid.', 'message' => 'The given data was invalid.',
'errors' => [ 'errors' => [
'transactions.0.description' => [sprintf('Internal exception: %s', $e->getMessage())] 'transactions.0.description' => [sprintf('Internal exception: %s', $e->getMessage())],
], ],
]; ];

View File

@ -155,8 +155,8 @@ class TransactionLinkController extends Controller
* *
* @param TransactionLinkRequest $request * @param TransactionLinkRequest $request
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function store(TransactionLinkRequest $request): JsonResponse public function store(TransactionLinkRequest $request): JsonResponse
{ {
@ -186,8 +186,8 @@ class TransactionLinkController extends Controller
* @param TransactionLinkRequest $request * @param TransactionLinkRequest $request
* @param TransactionJournalLink $journalLink * @param TransactionJournalLink $journalLink
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @return JsonResponse
*/ */
public function update(TransactionLinkRequest $request, TransactionJournalLink $journalLink): JsonResponse public function update(TransactionLinkRequest $request, TransactionJournalLink $journalLink): JsonResponse
{ {

View File

@ -70,9 +70,9 @@ class UserController extends Controller
* *
* @param User $user * @param User $user
* *
* @return JsonResponse
* @throws FireflyException * @throws FireflyException
* @codeCoverageIgnore * @codeCoverageIgnore
* @return JsonResponse
*/ */
public function delete(User $user): JsonResponse public function delete(User $user): JsonResponse
{ {