IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Various code cleanup.

Browse Source
This commit is contained in:
James Cole
2021-09-18 10:21:29 +02:00
parent 3589c9f60f
commit e829d79589
107 changed files with 225 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/Services/FireflyIIIOrg/Update/UpdateRequest.php
View File

@@ -25,7 +25,6 @@ declare(strict_types=1);
namespace FireflyIII\Services\FireflyIIIOrg\Update;
use Carbon\Carbon;
use Exception;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\GuzzleException;
use JsonException;

1
app/Services/Internal/Destroy/BillDestroyService.php
View File

@@ -25,7 +25,6 @@ namespace FireflyIII\Services\Internal\Destroy;
use Exception;
use FireflyIII\Models\Bill;
use Log;
/**
* @codeCoverageIgnore

1
app/Services/Internal/Destroy/BudgetDestroyService.php
View File

@@ -26,7 +26,6 @@ namespace FireflyIII\Services\Internal\Destroy;
use DB;
use Exception;
use FireflyIII\Models\Budget;
use Log;
/**
* Class BudgetDestroyService

1
app/Services/Internal/Destroy/CategoryDestroyService.php
View File

@@ -26,7 +26,6 @@ namespace FireflyIII\Services\Internal\Destroy;
use DB;
use Exception;
use FireflyIII\Models\Category;
use Log;
/**
* Class CategoryDestroyService

1
app/Services/Internal/Destroy/CurrencyDestroyService.php
View File

@@ -25,7 +25,6 @@ namespace FireflyIII\Services\Internal\Destroy;
use Exception;
use FireflyIII\Models\TransactionCurrency;
use Log;
/**
* Class CurrencyDestroyService

1
app/Services/Internal/Destroy/RecurrenceDestroyService.php
View File

@@ -26,7 +26,6 @@ namespace FireflyIII\Services\Internal\Destroy;
use Exception;
use FireflyIII\Models\Recurrence;
use FireflyIII\Models\RecurrenceTransaction;
use Log;
/**
* @codeCoverageIgnore

1
app/Services/Internal/Support/AccountServiceTrait.php
View File

@@ -39,7 +39,6 @@ use FireflyIII\Models\TransactionGroup;
use FireflyIII\Models\TransactionJournal;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Services\Internal\Destroy\TransactionGroupDestroyService;
use JsonException;
use Log;
use Validator;

1
app/Services/Internal/Support/BillServiceTrait.php
View File

@@ -27,7 +27,6 @@ use Exception;
use FireflyIII\Models\Bill;
use FireflyIII\Models\Note;
use FireflyIII\Models\RuleAction;
use Illuminate\Support\Collection;
use Log;
/**

4
app/Services/Internal/Support/CreditRecalculateService.php
View File

@@ -262,7 +262,7 @@ class CreditRecalculateService
// if it's a credit, we don't care, because sending more money
// to a credit-liability doesn't increase the amount (yet)
if (
in_array($type, [TransactionType::WITHDRAWAL])
$type === TransactionType::WITHDRAWAL
&& (int)$account->id === (int)$transaction->account_id
&& 1 === bccomp($transaction->amount, '0')
&& 'credit' === $direction
@@ -274,7 +274,7 @@ class CreditRecalculateService
// likewise deposit into a credit debt does not change the amount
if (
in_array($type, [TransactionType::DEPOSIT])
$type === TransactionType::DEPOSIT
&& (int)$account->id === (int)$transaction->account_id
&& -1 === bccomp($transaction->amount, '0')
&& 'credit' === $direction

1
app/Services/Internal/Update/AccountUpdateService.php
View File

@@ -79,7 +79,6 @@ class AccountUpdateService
*
* @return Account
* @throws FireflyException
* @throws JsonException
*/
public function update(Account $account, array $data): Account
{

1
app/Services/Internal/Update/GroupUpdateService.php
View File

@@ -122,6 +122,7 @@ class GroupUpdateService
* @param array $transactions
*
* @return array
* @throws DuplicateTransactionException
* @throws FireflyException
*/
private function updateTransactions(TransactionGroup $transactionGroup, array $transactions): array