From eed68b5d95d7bed5460488764895739e5fa6a5d8 Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Fri, 10 Apr 2020 10:47:24 +0200
Subject: [PATCH] Fix some code quality issues.

---
 .../Commands/Correction/CorrectOpeningBalanceCurrencies.php    | 1 +
 app/Console/Commands/Correction/FixLongDescriptions.php        | 1 +
 app/Console/Commands/Correction/FixRecurringTransactions.php   | 1 +
 app/Console/Commands/CreateDatabase.php                        | 1 +
 app/Console/Commands/Export/ExportData.php                     | 1 +
 app/Console/Commands/Integrity/RestoreOAuthKeys.php            | 1 +
 app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php         | 1 +
 app/Console/Commands/Upgrade/MigrateTagLocations.php           | 1 +
 app/Exceptions/DuplicateTransactionException.php               | 1 +
 app/Http/Controllers/Admin/TelemetryController.php             | 1 +
 app/Http/Controllers/Auth/ConfirmPasswordController.php        | 1 +
 app/Http/Controllers/Chart/TagReportController.php             | 2 --
 app/Http/Controllers/Chart/TransactionController.php           | 1 +
 app/Http/Controllers/Export/IndexController.php                | 1 +
 app/Http/Controllers/Profile/DataController.php                | 1 +
 app/Models/AutoBudget.php                                      | 1 +
 app/Models/Location.php                                        | 1 +
 app/Models/Telemetry.php                                       | 1 +
 app/Rules/IsTransferAccount.php                                | 1 +
 app/Rules/LessThanPiggyTarget.php                              | 1 +
 app/Services/FireflyIIIOrg/Update/UpdateRequest.php            | 1 +
 app/Services/FireflyIIIOrg/Update/UpdateRequestInterface.php   | 1 +
 app/Services/Internal/Support/LocationServiceTrait.php         | 1 +
 app/Support/Cronjobs/AutoBudgetCronjob.php                     | 1 +
 app/Support/Export/ExportDataGenerator.php                     | 1 +
 app/Support/Search/AccountSearch.php                           | 1 +
 app/Support/Search/GenericSearchInterface.php                  | 1 +
 app/Support/Search/TransactionSearch.php                       | 1 +
 app/Support/Search/TransferSearch.php                          | 1 +
 app/Support/System/OAuthKeys.php                               | 1 +
 app/Support/Telemetry.php                                      | 1 +
 public/v1/css/daterangepicker.css                              | 3 +--
 32 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/app/Console/Commands/Correction/CorrectOpeningBalanceCurrencies.php b/app/Console/Commands/Correction/CorrectOpeningBalanceCurrencies.php
index 216a364e60..063e40e230 100644
--- a/app/Console/Commands/Correction/CorrectOpeningBalanceCurrencies.php
+++ b/app/Console/Commands/Correction/CorrectOpeningBalanceCurrencies.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * CorrectOpeningBalanceCurrencies.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/Correction/FixLongDescriptions.php b/app/Console/Commands/Correction/FixLongDescriptions.php
index 1cc90566b7..0335b212c5 100644
--- a/app/Console/Commands/Correction/FixLongDescriptions.php
+++ b/app/Console/Commands/Correction/FixLongDescriptions.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * FixLongDescriptions.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/Correction/FixRecurringTransactions.php b/app/Console/Commands/Correction/FixRecurringTransactions.php
index a0a1a6170b..6c83c63e45 100644
--- a/app/Console/Commands/Correction/FixRecurringTransactions.php
+++ b/app/Console/Commands/Correction/FixRecurringTransactions.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * FixRecurringTransactions.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/CreateDatabase.php b/app/Console/Commands/CreateDatabase.php
index 46cd5109ba..f3b55c858b 100644
--- a/app/Console/Commands/CreateDatabase.php
+++ b/app/Console/Commands/CreateDatabase.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 
 /**
diff --git a/app/Console/Commands/Export/ExportData.php b/app/Console/Commands/Export/ExportData.php
index 4ecf0cb1ee..7a18f5ca7e 100644
--- a/app/Console/Commands/Export/ExportData.php
+++ b/app/Console/Commands/Export/ExportData.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * ExportData.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/Integrity/RestoreOAuthKeys.php b/app/Console/Commands/Integrity/RestoreOAuthKeys.php
index 22d1db5cc4..ad7fe3fb42 100644
--- a/app/Console/Commands/Integrity/RestoreOAuthKeys.php
+++ b/app/Console/Commands/Integrity/RestoreOAuthKeys.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * RestoreOAuthKeys.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php b/app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php
index a9a0df3ec3..5bccd92bec 100644
--- a/app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php
+++ b/app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * MigrateRecurrenceMeta.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Console/Commands/Upgrade/MigrateTagLocations.php b/app/Console/Commands/Upgrade/MigrateTagLocations.php
index 94e42e3045..bbada0a41d 100644
--- a/app/Console/Commands/Upgrade/MigrateTagLocations.php
+++ b/app/Console/Commands/Upgrade/MigrateTagLocations.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * MigrateTagLocations.php
  * Copyright (c) 2020 james@firefly-iii.org
diff --git a/app/Exceptions/DuplicateTransactionException.php b/app/Exceptions/DuplicateTransactionException.php
index 2b607ec9a9..760f64af6b 100644
--- a/app/Exceptions/DuplicateTransactionException.php
+++ b/app/Exceptions/DuplicateTransactionException.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * DuplicateTransactionException.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Http/Controllers/Admin/TelemetryController.php b/app/Http/Controllers/Admin/TelemetryController.php
index 74ec3c8058..7aa60cad8d 100644
--- a/app/Http/Controllers/Admin/TelemetryController.php
+++ b/app/Http/Controllers/Admin/TelemetryController.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * TelemetryController.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/app/Http/Controllers/Auth/ConfirmPasswordController.php b/app/Http/Controllers/Auth/ConfirmPasswordController.php
index 535496d7be..3077ad4beb 100644
--- a/app/Http/Controllers/Auth/ConfirmPasswordController.php
+++ b/app/Http/Controllers/Auth/ConfirmPasswordController.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 
 /**
diff --git a/app/Http/Controllers/Chart/TagReportController.php b/app/Http/Controllers/Chart/TagReportController.php
index 9b6f8505fd..ff8a8b1732 100644
--- a/app/Http/Controllers/Chart/TagReportController.php
+++ b/app/Http/Controllers/Chart/TagReportController.php
@@ -450,8 +450,6 @@ class TagReportController extends Controller
         $data = $this->generator->multiCurrencyPieChart($result);
 
         return response()->json($data);
-
-        return response()->json($data);
     }
 
 
diff --git a/app/Http/Controllers/Chart/TransactionController.php b/app/Http/Controllers/Chart/TransactionController.php
index 3db121c097..8f9798e215 100644
--- a/app/Http/Controllers/Chart/TransactionController.php
+++ b/app/Http/Controllers/Chart/TransactionController.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * TransactionController.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/app/Http/Controllers/Export/IndexController.php b/app/Http/Controllers/Export/IndexController.php
index 04464901cc..1626b0756c 100644
--- a/app/Http/Controllers/Export/IndexController.php
+++ b/app/Http/Controllers/Export/IndexController.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * IndexController.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Http/Controllers/Profile/DataController.php b/app/Http/Controllers/Profile/DataController.php
index 12121b4251..a4ded43c29 100644
--- a/app/Http/Controllers/Profile/DataController.php
+++ b/app/Http/Controllers/Profile/DataController.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * DataController.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Models/AutoBudget.php b/app/Models/AutoBudget.php
index f8ba614ddf..3f4c42ee24 100644
--- a/app/Models/AutoBudget.php
+++ b/app/Models/AutoBudget.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * AutoBudget.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/app/Models/Location.php b/app/Models/Location.php
index b8daa02010..4e97b1bd16 100644
--- a/app/Models/Location.php
+++ b/app/Models/Location.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * Location.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Models/Telemetry.php b/app/Models/Telemetry.php
index 223b5d9137..521f4e18c1 100644
--- a/app/Models/Telemetry.php
+++ b/app/Models/Telemetry.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * Telemetry.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/app/Rules/IsTransferAccount.php b/app/Rules/IsTransferAccount.php
index b47c261d6b..851d04e234 100644
--- a/app/Rules/IsTransferAccount.php
+++ b/app/Rules/IsTransferAccount.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * IsTransferAccount.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Rules/LessThanPiggyTarget.php b/app/Rules/LessThanPiggyTarget.php
index d537b3208e..d32fd7ca10 100644
--- a/app/Rules/LessThanPiggyTarget.php
+++ b/app/Rules/LessThanPiggyTarget.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * LessThanPiggyTarget.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Services/FireflyIIIOrg/Update/UpdateRequest.php b/app/Services/FireflyIIIOrg/Update/UpdateRequest.php
index 7457a09e8b..2242f9a36a 100644
--- a/app/Services/FireflyIIIOrg/Update/UpdateRequest.php
+++ b/app/Services/FireflyIIIOrg/Update/UpdateRequest.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * UpdateRequest.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Services/FireflyIIIOrg/Update/UpdateRequestInterface.php b/app/Services/FireflyIIIOrg/Update/UpdateRequestInterface.php
index 49ccc158dd..6f7f7eb095 100644
--- a/app/Services/FireflyIIIOrg/Update/UpdateRequestInterface.php
+++ b/app/Services/FireflyIIIOrg/Update/UpdateRequestInterface.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * UpdateRequestInterface.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Services/Internal/Support/LocationServiceTrait.php b/app/Services/Internal/Support/LocationServiceTrait.php
index b19c5f1a99..5d8ffb21be 100644
--- a/app/Services/Internal/Support/LocationServiceTrait.php
+++ b/app/Services/Internal/Support/LocationServiceTrait.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * LocationServiceTrait.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Cronjobs/AutoBudgetCronjob.php b/app/Support/Cronjobs/AutoBudgetCronjob.php
index 7dba31599c..c4c72827b5 100644
--- a/app/Support/Cronjobs/AutoBudgetCronjob.php
+++ b/app/Support/Cronjobs/AutoBudgetCronjob.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * AutoBudgetCronjob.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/app/Support/Export/ExportDataGenerator.php b/app/Support/Export/ExportDataGenerator.php
index 80264b3ebc..8f2cebe4df 100644
--- a/app/Support/Export/ExportDataGenerator.php
+++ b/app/Support/Export/ExportDataGenerator.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * ExportDataGenerator.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Search/AccountSearch.php b/app/Support/Search/AccountSearch.php
index 9fff5294ea..9eb9aeef64 100644
--- a/app/Support/Search/AccountSearch.php
+++ b/app/Support/Search/AccountSearch.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * AccountSearch.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Search/GenericSearchInterface.php b/app/Support/Search/GenericSearchInterface.php
index c28b0d093f..1ca809d1ca 100644
--- a/app/Support/Search/GenericSearchInterface.php
+++ b/app/Support/Search/GenericSearchInterface.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * GenericSearchInterface.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Search/TransactionSearch.php b/app/Support/Search/TransactionSearch.php
index 2b39fbbb9e..45080812d5 100644
--- a/app/Support/Search/TransactionSearch.php
+++ b/app/Support/Search/TransactionSearch.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * TransactionSearch.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Search/TransferSearch.php b/app/Support/Search/TransferSearch.php
index ef94659131..aff435b65a 100644
--- a/app/Support/Search/TransferSearch.php
+++ b/app/Support/Search/TransferSearch.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * TransferSearch.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/System/OAuthKeys.php b/app/Support/System/OAuthKeys.php
index 057f6add8a..fc6df6b40c 100644
--- a/app/Support/System/OAuthKeys.php
+++ b/app/Support/System/OAuthKeys.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * OAuthKeys.php
  * Copyright (c) 2019 james@firefly-iii.org
diff --git a/app/Support/Telemetry.php b/app/Support/Telemetry.php
index fe458781b2..905ca18233 100644
--- a/app/Support/Telemetry.php
+++ b/app/Support/Telemetry.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 /**
  * Telemetry.php
  * Copyright (c) 2020 thegrumpydictator@gmail.com
diff --git a/public/v1/css/daterangepicker.css b/public/v1/css/daterangepicker.css
index 73f36b0cc9..e9ddc376aa 100755
--- a/public/v1/css/daterangepicker.css
+++ b/public/v1/css/daterangepicker.css
@@ -12,7 +12,7 @@
   left: 20px;
   z-index: 3001;
   display: none;
-  font-family: arial;
+  font-family: sans-serif, Arial;
   font-size: 15px;
   line-height: 1em;
 }
@@ -155,7 +155,6 @@
   font-size: 12px;
   border-radius: 4px;
   border: 1px solid transparent;
-  white-space: nowrap;
   cursor: pointer;
 }