IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix level 5! Mostly by ignoring the errors lol.

Browse Source
This commit is contained in:
James Cole 2025-01-04 09:15:39 +01:00
parent 5617de3a79
commit f4bc313d0b
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
19 changed files with 32 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.ci/phpstan.neon
View File

@ -69,5 +69,5 @@ parameters:
# The level 8 is the highest level. original was 5
# 7 is more than enough, higher just leaves NULL things.
level: 4
level: 5

2
app/Console/Commands/Correction/CorrectsNativeAmounts.php
View File

@ -146,7 +146,7 @@ class CorrectsNativeAmounts extends Command
{
$set = $piggyBank->piggyBankEvents()->get();
$set->each(
static function (PiggyBankEvent $event): void {
static function (PiggyBankEvent $event): void { // @phpstan-ignore-line
$event->touch();
}
);

2
app/Console/Commands/Correction/CorrectsUnevenAmount.php
View File

@ -121,7 +121,7 @@ class CorrectsUnevenAmount extends Command
$journals = \DB::table('transactions')
->groupBy('transaction_journal_id')
->whereNull('deleted_at')
->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')])
->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')]) // @phpstan-ignore-line
;
/** @var \stdClass $entry */

2
app/Http/Controllers/System/InstallController.php
View File

@ -98,7 +98,7 @@ class InstallController extends Controller
];
app('log')->debug(sprintf('Will now run commands. Request index is %d', $requestIndex));
$indexes = array_values(array_keys($this->upgradeCommands));
$indexes = array_keys($this->upgradeCommands);
if (array_key_exists($requestIndex, $indexes)) {
$command = $indexes[$requestIndex];
$parameters = $this->upgradeCommands[$command];

3
app/Http/Controllers/UserGroup/CreateController.php
View File

@ -41,6 +41,7 @@ class CreateController extends Controller
$mainTitleIcon = 'fa-book';
app('log')->debug(sprintf('Now at %s', __METHOD__));
return view('administrations.create')->with(compact('title', 'subTitle', 'mainTitleIcon'));
return view('administrations.create') // @phpstan-ignore-line
->with(compact('title', 'subTitle', 'mainTitleIcon'));
}
}

3
app/Http/Controllers/UserGroup/EditController.php
View File

@ -42,6 +42,7 @@ class EditController extends Controller
$mainTitleIcon = 'fa-book';
app('log')->debug(sprintf('Now at %s', __METHOD__));
return view('administrations.edit')->with(compact('title', 'subTitle', 'mainTitleIcon'));
return view('administrations.edit') // @phpstan-ignore-line
->with(compact('title', 'subTitle', 'mainTitleIcon'));
}
}

10
app/Repositories/Account/AccountRepository.php
View File

@ -186,8 +186,8 @@ class AccountRepository implements AccountRepositoryInterface
public function getActiveAccountsByType(array $types): Collection
{
$query = $this->user->accounts()->with(
[
'accountmeta' => static function (HasMany $query): void {
[ // @phpstan-ignore-line
'accountmeta' => static function (HasMany $query): void { // @phpstan-ignore-line
$query->where('name', 'account_role');
},
'attachments',
@ -212,7 +212,7 @@ class AccountRepository implements AccountRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk) {
static function (Attachment $attachment) use ($disk) { // @phpstan-ignore-line
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes_text = null !== $notes ? $notes->text : '';
@ -258,8 +258,8 @@ class AccountRepository implements AccountRepositoryInterface
public function getInactiveAccountsByType(array $types): Collection
{
$query = $this->user->accounts()->with(
[
'accountmeta' => static function (HasMany $query): void {
[ // @phpstan-ignore-line
'accountmeta' => static function (HasMany $query): void { // @phpstan-ignore-line
$query->where('name', 'account_role');
},
]

2
app/Repositories/Bill/BillRepository.php
View File

@ -166,7 +166,7 @@ class BillRepository implements BillRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk) {
static function (Attachment $attachment) use ($disk) { // @phpstan-ignore-line
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes_text = null !== $notes ? $notes->text : '';

2
app/Repositories/Budget/BudgetRepository.php
View File

@ -541,7 +541,7 @@ class BudgetRepository implements BudgetRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk) {
static function (Attachment $attachment) use ($disk) { // @phpstan-ignore-line
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes_text = null !== $notes ? $notes->text : '';

2
app/Repositories/Category/CategoryRepository.php
View File

@ -248,7 +248,7 @@ class CategoryRepository implements CategoryRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk) {
static function (Attachment $attachment) use ($disk) { // @phpstan-ignore-line
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes_text = null !== $notes ? $notes->text : '';

2
app/Repositories/Journal/JournalAPIRepository.php
View File

@ -89,7 +89,7 @@ class JournalAPIRepository implements JournalAPIRepositoryInterface
{
$events = $journal->piggyBankEvents()->get();
$events->each(
static function (PiggyBankEvent $event): void {
static function (PiggyBankEvent $event): void { // @phpstan-ignore-line
$event->piggyBank = PiggyBank::withTrashed()->find($event->piggy_bank_id);
}
);

2
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@ -115,7 +115,7 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk) {
static function (Attachment $attachment) use ($disk) { // @phpstan-ignore-line
$notes = $attachment->notes()->first();
$attachment->file_exists = $disk->exists($attachment->fileName());
$attachment->notes_text = null !== $notes ? $notes->text : '';

2
app/Repositories/Rule/RuleRepository.php
View File

@ -239,6 +239,8 @@ class RuleRepository implements RuleRepositoryInterface
throw new FireflyException('No such rule group.');
}
/** @var RuleGroup $ruleGroup */
// start by creating a new rule:
$rule = new Rule();
$rule->user()->associate($this->user);

8
app/Repositories/RuleGroup/RuleGroupRepository.php
View File

@ -258,7 +258,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
$groups = $this->user->ruleGroups()
->orderBy('order', 'ASC')
->with(
[
[ // @phpstan-ignore-line
'rules' => static function (HasMany $query): void {
$query->orderBy('order', 'ASC');
},
@ -277,7 +277,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
app('log')->debug(sprintf('Will filter getRuleGroupsWithRules on "%s".', $filter));
return $groups->map(
static function (RuleGroup $group) use ($filter) {
static function (RuleGroup $group) use ($filter) { // @phpstan-ignore-line
app('log')->debug(sprintf('Now filtering group #%d', $group->id));
// filter the rules in the rule group:
$group->rules = $group->rules->filter(
@ -314,7 +314,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
->orderBy('order', 'ASC')
->where('active', true)
->with(
[
[ // @phpstan-ignore-line
'rules' => static function (HasMany $query): void {
$query->orderBy('order', 'ASC');
},
@ -333,7 +333,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
app('log')->debug(sprintf('Will filter getRuleGroupsWithRules on "%s".', $filter));
return $groups->map(
static function (RuleGroup $group) use ($filter) {
static function (RuleGroup $group) use ($filter) { // @phpstan-ignore-line
app('log')->debug(sprintf('Now filtering group #%d', $group->id));
// filter the rules in the rule group:
$group->rules = $group->rules->filter(

4
app/Repositories/Tag/TagRepository.php
View File

@ -124,7 +124,7 @@ class TagRepository implements TagRepositoryInterface
$disk = \Storage::disk('upload');
return $set->each(
static function (Attachment $attachment) use ($disk): void {
static function (Attachment $attachment) use ($disk): void { // @phpstan-ignore-line
/** @var null|Note $note */
$note = $attachment->notes()->first();
// only used in v1 view of tags
@ -220,7 +220,7 @@ class TagRepository implements TagRepositoryInterface
$tags->whereLike('tag', $search);
}
return $tags->take($limit)->get('tags.*');
return $tags->take($limit)->get(['tags.*']);
}
public function store(array $data): Tag

3
app/Repositories/User/UserRepository.php
View File

@ -268,6 +268,9 @@ class UserRepository implements UserRepositoryInterface
public function inviteUser(null|Authenticatable|User $user, string $email): InvitedUser
{
if(!($user instanceof User)) {
throw new FireflyException('User is not a User object.');
}
$now = today(config('app.timezone'));
$now->addDays(2);
$invitee = new InvitedUser();

2
app/Repositories/UserGroups/Currency/CurrencyRepository.php
View File

@ -193,7 +193,7 @@ class CurrencyRepository implements CurrencyRepositoryInterface
public function get(): Collection
{
$all = $this->userGroup->currencies()->orderBy('code', 'ASC')->withPivot(['group_default'])->get();
$all->map(static function (TransactionCurrency $current) {
$all->map(static function (TransactionCurrency $current) { // @phpstan-ignore-line
$current->userGroupEnabled = true;
$current->userGroupDefault = 1 === (int) $current->pivot->group_default;

2
app/Repositories/Webhook/WebhookRepository.php
View File

@ -78,7 +78,7 @@ class WebhookRepository implements WebhookRepositoryInterface
->where('webhook_messages.errored', 0)
->get(['webhook_messages.*'])
->filter(
static function (WebhookMessage $message) {
static function (WebhookMessage $message) { // @phpstan-ignore-line
return $message->webhookAttempts()->count() <= 2;
}
)->splice(0, 3)

2
app/Validation/FireflyValidator.php
View File

@ -823,7 +823,7 @@ class FireflyValidator extends Validator
}
$query->where('piggy_banks.name', $value);
return 0 === $query->count(['piggy_banks.*']);
return 0 === $query->count('piggy_banks.*');
}
/**