IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-01-27 08:46:40 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add limit to object groups #3150

Browse Source
This commit is contained in:
James Cole 2020-07-21 06:30:37 +02:00
parent bb841e66c7
commit f777abdeb1
No known key found for this signature in database
GPG Key ID: B5669F9493CDE38D
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/Api/V1/Controllers/Autocomplete/ObjectGroupController.php
View File

@ -57,7 +57,6 @@ class ObjectGroupController extends Controller
}
/**
* TODO add limit
* @param AutocompleteRequest $request
*
* @return JsonResponse
@ -66,7 +65,7 @@ class ObjectGroupController extends Controller
{
$data = $request->getData();
$return = [];
$result = $this->repository->search($data['query']);
$result = $this->repository->search($data['query'], $data['limit']);
/** @var ObjectGroup $account */
foreach ($result as $objectGroup) {

5
app/Repositories/ObjectGroup/ObjectGroupRepository.php
View File

@ -61,10 +61,11 @@ class ObjectGroupRepository implements ObjectGroupRepositoryInterface
/**
* @param string $query
* @param int $limit
*
* @return Collection
*/
public function search(string $query): Collection
public function search(string $query, int $limit): Collection
{
$dbQuery = $this->user->objectGroups()->orderBy('order', 'ASC')->orderBy('title', 'ASC');
if ('' !== $query) {
@ -77,7 +78,7 @@ class ObjectGroupRepository implements ObjectGroupRepositoryInterface
}
return $dbQuery->get(['object_groups.*']);
return $dbQuery->take($limit)->get(['object_groups.*']);
}
/**

3
app/Repositories/ObjectGroup/ObjectGroupRepositoryInterface.php
View File

@ -39,10 +39,11 @@ interface ObjectGroupRepositoryInterface
/**
* @param string $query
* @param int $limit
*
* @return Collection
*/
public function search(string $query): Collection;
public function search(string $query, int $limit): Collection;
/**
* Delete empty ones.