IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Expand test coverage

Browse Source
This commit is contained in:
James Cole 2017-12-23 22:02:54 +01:00
parent f6096339cb
commit f85bdcebaf
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/Transaction/SingleController.php
View File

@ -443,7 +443,7 @@ class SingleController extends Controller
foreach ($accounts as $account) { foreach ($accounts as $account) {
$type = $account->getMeta('accountRole'); $type = $account->getMeta('accountRole');
if (0 === strlen($type)) { if (0 === strlen($type)) {
$type = 'no_account_type'; $type = 'no_account_type'; // @codeCoverageIgnore
} }
$key = strval(trans('firefly.opt_group_' . $type)); $key = strval(trans('firefly.opt_group_' . $type));
$return[$key][$account->id] = $account->name; $return[$key][$account->id] = $account->name;
@ -463,7 +463,7 @@ class SingleController extends Controller
foreach ($accounts as $account) { foreach ($accounts as $account) {
$type = $account->getMeta('accountRole'); $type = $account->getMeta('accountRole');
if (0 === strlen($type)) { if (0 === strlen($type)) {
$type = 'no_account_type'; $type = 'no_account_type'; // @codeCoverageIgnore
} }
$key = strval(trans('firefly.opt_group_' . $type)); $key = strval(trans('firefly.opt_group_' . $type));
$return[$key][$account->id] = $account->name; $return[$key][$account->id] = $account->name;
@ -482,7 +482,7 @@ class SingleController extends Controller
$count = $this->repository->countTransactions($journal); $count = $this->repository->countTransactions($journal);
if ($count > 2) { if ($count > 2) {
return true; return true; // @codeCoverageIgnore
} }
return false; return false;

4
tests/Feature/Controllers/Transaction/SingleControllerTest.php
View File

@ -75,9 +75,10 @@ class SingleControllerTest extends TestCase
*/ */
public function testCreate() public function testCreate()
{ {
$accounts = $this->user()->accounts()->where('account_type_id',3)->get();
Steam::shouldReceive('phpBytes')->andReturn(2048); Steam::shouldReceive('phpBytes')->andReturn(2048);
$repository = $this->mock(AccountRepositoryInterface::class); $repository = $this->mock(AccountRepositoryInterface::class);
$repository->shouldReceive('getActiveAccountsByType')->once()->withArgs([[AccountType::DEFAULT, AccountType::ASSET]])->andReturn(new Collection); $repository->shouldReceive('getActiveAccountsByType')->once()->withArgs([[AccountType::DEFAULT, AccountType::ASSET]])->andReturn($accounts);
$budgetRepos = $this->mock(BudgetRepositoryInterface::class); $budgetRepos = $this->mock(BudgetRepositoryInterface::class);
$budgetRepos->shouldReceive('getActiveBudgets')->andReturn(new Collection)->once(); $budgetRepos->shouldReceive('getActiveBudgets')->andReturn(new Collection)->once();
$piggyRepos = $this->mock(PiggyBankRepositoryInterface::class); $piggyRepos = $this->mock(PiggyBankRepositoryInterface::class);
@ -124,6 +125,7 @@ class SingleControllerTest extends TestCase
/** /**
* @covers \FireflyIII\Http\Controllers\Transaction\SingleController::edit * @covers \FireflyIII\Http\Controllers\Transaction\SingleController::edit
* @covers \FireflyIII\Http\Controllers\Transaction\SingleController::groupedAccountList * @covers \FireflyIII\Http\Controllers\Transaction\SingleController::groupedAccountList
* @covers \FireflyIII\Http\Controllers\Transaction\SingleController::isSplitJournal
*/ */
public function testEdit() public function testEdit()
{ {