IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed for-loop in favour of "pluck()" aka: RTFM.

Browse Source
This commit is contained in:
James Cole 2015-12-30 09:17:14 +01:00
parent 9f87890ead
commit f99e46bf75
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/Repositories/Category/SingleCategoryRepository.php
View File

@ -110,10 +110,7 @@ class SingleCategoryRepository extends ComponentRepository implements SingleCate
*/
public function earnedInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end)
{
$accountIds = [];
foreach ($accounts as $account) {
$accountIds[] = $account->id;
}
$accountIds = $accounts->pluck('id')->toArray();
$sum
= $category
->transactionjournals()
@ -237,10 +234,7 @@ class SingleCategoryRepository extends ComponentRepository implements SingleCate
*/
public function spentInPeriodForAccounts(Category $category, Collection $accounts, Carbon $start, Carbon $end)
{
$accountIds = [];
foreach ($accounts as $account) {
$accountIds[] = $account->id;
}
$accountIds = $accounts->pluck('id')->toArray();
$sum
= $category

6
app/Repositories/Shared/ComponentRepository.php
View File

@ -39,11 +39,7 @@ class ComponentRepository
return $cache->get(); // @codeCoverageIgnore
}
$ids = [];
/** @var Account $account */
foreach ($accounts as $account) {
$ids[] = $account->id;
}
$ids = $accounts->pluck('id')->toArray();
$entry = $object->transactionjournals()