IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Cleaned up some todo entries [skip ci]

Browse Source
This commit is contained in:
James Cole 2015-01-02 10:01:33 +01:00
parent a6dbd912c6
commit fb58bf1bf5
16 changed files with 3 additions and 268 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/BudgetController.php
View File

@ -99,7 +99,6 @@ class BudgetController extends BaseController
/**
* The index of the budget controller contains all budgets and the current relevant limit repetition.
* TODO move currentRep to the repository.
*
* @return $this
*/

6
app/controllers/GoogleChartController.php
View File

@ -225,7 +225,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO query move to helper.
*
* @return \Illuminate\Http\JsonResponse
* @throws \FireflyIII\Exception\FireflyException
@ -256,7 +255,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO still in use?
*
* @param Budget $budget
* @param LimitRepetition $repetition
@ -290,7 +288,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO still in use?
*
* @param Budget $budget
* @param $year
@ -341,7 +338,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO still in use?
*
* @param Category $component
* @param $year
@ -407,7 +403,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO see reports for better way to do this.
*
* @param $year
*
@ -447,7 +442,6 @@ class GoogleChartController extends BaseController
}
/**
* TODO see reports for better way to do this.
*
* @param $year
*

7
app/lib/FireflyIII/Database/AccountType/AccountType.php
View File

@ -25,7 +25,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function destroy(Eloquent $model)
{
// TODO: Implement destroy() method.
throw new NotImplementedException;
}
@ -37,7 +36,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function store(array $data)
{
// TODO: Implement store() method.
throw new NotImplementedException;
}
@ -50,7 +48,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function update(Eloquent $model, array $data)
{
// TODO: Implement update() method.
throw new NotImplementedException;
}
@ -65,7 +62,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function validate(array $model)
{
// TODO: Implement validate() method.
throw new NotImplementedException;
}
@ -79,7 +75,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -124,7 +119,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function get()
{
// TODO: Implement get() method.
throw new NotImplementedException;
}
@ -136,7 +130,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}
}

3
app/lib/FireflyIII/Database/Bill/Bill.php
View File

@ -142,7 +142,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -156,7 +155,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}
@ -178,7 +176,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}

4
app/lib/FireflyIII/Database/Budget/Budget.php
View File

@ -119,7 +119,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}
@ -143,7 +142,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}
@ -335,7 +333,7 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf
$limit->amount = $amount;
$limit->repeat_freq = 'monthly';
$limit->repeats = 0;
$result = $limit->save();
$limit->save();
\Log::info('ID: ' . $limit->id);
/*
* A newly stored limit also created a limit repetition.

3
app/lib/FireflyIII/Database/Category/Category.php
View File

@ -108,7 +108,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -122,7 +121,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}
@ -144,7 +142,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}

1
app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php
View File

@ -67,7 +67,6 @@ class PiggyBankShared
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}

6
app/lib/FireflyIII/Database/Transaction/Transaction.php
View File

@ -28,7 +28,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function destroy(Eloquent $model)
{
// TODO: Implement destroy() method.
throw new NotImplementedException;
}
@ -68,7 +67,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function update(Eloquent $model, array $data)
{
// TODO: Implement update() method.
throw new NotImplementedException;
}
@ -103,7 +101,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -117,7 +114,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}
@ -129,7 +125,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function get()
{
// TODO: Implement get() method.
throw new NotImplementedException;
}
@ -141,7 +136,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}
}

3
app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php
View File

@ -98,7 +98,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -112,7 +111,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}
@ -134,7 +132,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas
*/
public function getByIds(array $objectIds)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}

1
app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php
View File

@ -390,7 +390,6 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C
*/
public function findByWhat($what)
{
// TODO: Implement findByWhat() method.
throw new NotImplementedException;
}

7
app/lib/FireflyIII/Database/TransactionType/TransactionType.php
View File

@ -27,7 +27,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function destroy(Eloquent $model)
{
// TODO: Implement destroy() method.
throw new NotImplementedException;
}
@ -39,7 +38,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function store(array $data)
{
// TODO: Implement store() method.
throw new NotImplementedException;
}
@ -52,7 +50,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function update(Eloquent $model, array $data)
{
// TODO: Implement update() method.
throw new NotImplementedException;
}
@ -67,7 +64,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function validate(array $model)
{
// TODO: Implement validate() method.
throw new NotImplementedException;
}
@ -81,7 +77,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function find($objectId)
{
// TODO: Implement find() method.
throw new NotImplementedException;
}
@ -115,7 +110,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function get()
{
// TODO: Implement get() method.
throw new NotImplementedException;
}
@ -127,7 +121,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface
*/
public function getByIds(array $ids)
{
// TODO: Implement getByIds() method.
throw new NotImplementedException;
}
}

2
app/lib/FireflyIII/Report/Report.php
View File

@ -10,8 +10,6 @@ use Illuminate\Database\Query\Builder;
use Illuminate\Database\Query\JoinClause;
use Illuminate\Support\Collection;
// todo add methods to interface
/**
* Class Report
*

2
app/lib/FireflyIII/Shared/Toolkit/Amount.php
View File

@ -145,4 +145,4 @@ class Amount
return $currency->code;
}
}
}

222
app/tests/PiggybankPartTest.php
View File

@ -1,222 +0,0 @@
<?php
use FireflyIII\Collection\PiggyBankPart;
/**
* Generated by PHPUnit_SkeletonGenerator on 2014-12-20 at 06:56:52.
*/
class PiggyBankPartTest extends \PHPUnit_Framework_TestCase
{
/**
* @var PiggyBankPart
*/
protected $object;
/**
* Sets up the fixture, for example, opens a network connection.
* This method is called before a test is executed.
*/
protected function setUp()
{
$this->object = new PiggyBankPart;
}
/**
* Tears down the fixture, for example, closes a network connection.
* This method is called after a test is executed.
*/
protected function tearDown()
{
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getReminder
* @todo Implement testGetReminder().
*/
public function testGetReminder()
{
$this->object->getReminder();
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setReminder
* @todo Implement testSetReminder().
*/
public function testSetReminder()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getStartdate
* @todo Implement testGetStartdate().
*/
public function testGetStartdate()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setStartdate
* @todo Implement testSetStartdate().
*/
public function testSetStartdate()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getTargetdate
* @todo Implement testGetTargetdate().
*/
public function testGetTargetdate()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setTargetdate
* @todo Implement testSetTargetdate().
*/
public function testSetTargetdate()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getRepetition
* @todo Implement testGetRepetition().
*/
public function testGetRepetition()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setRepetition
* @todo Implement testSetRepetition().
*/
public function testSetRepetition()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::hasReminder
* @todo Implement testHasReminder().
*/
public function testHasReminder()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::percentage
* @todo Implement testPercentage().
*/
public function testPercentage()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getCurrentamount
* @todo Implement testGetCurrentamount().
*/
public function testGetCurrentamount()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setCurrentamount
* @todo Implement testSetCurrentamount().
*/
public function testSetCurrentamount()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getCumulativeAmount
* @todo Implement testGetCumulativeAmount().
*/
public function testGetCumulativeAmount()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setCumulativeAmount
* @todo Implement testSetCumulativeAmount().
*/
public function testSetCumulativeAmount()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::getAmountPerBar
* @todo Implement testGetAmountPerBar().
*/
public function testGetAmountPerBar()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
/**
* @covers FireflyIII\Collection\PiggyBankPart::setAmountPerBar
* @todo Implement testSetAmountPerBar().
*/
public function testSetAmountPerBar()
{
// Remove the following lines when you implement this test.
$this->markTestIncomplete(
'This test has not been implemented yet.'
);
}
}

1
app/views/repeatedExpense/index.blade.php
View File

@ -9,7 +9,6 @@
</div>
</div>
<!-- TODO create update and destroy -->
@foreach($expenses as $entry)
<div class="row">

2
bootstrap/start.php
View File

@ -97,5 +97,5 @@ Event::subscribe('FireflyIII\Event\TransactionJournal');
// set very tight rules on all models
// create custom uniquely rules.
// TODO add "Create new X" button to any list there is: categories, accounts, piggies, etc.
// TODO Install PHP5 and code thing and create very small methods.
// Install PHP5 and code thing and create very small methods.
return $app;