IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix phpstan warnings

Browse Source
This commit is contained in:
James Cole 2025-01-03 15:53:10 +01:00
parent d95f3ca59f
commit fe4d139817
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
173 changed files with 374 additions and 360 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
.ci/phpstan.neon
View File

@ -1,11 +1,22 @@
parameters:
scanFiles:
- ../_ide_helper_models.php
- ../_ide_helper.php
paths:
- ../app
- ../database
- ../routes
- ../config
- ../bootstrap/app.php
universalObjectCratesClasses:
- Illuminate\Database\Eloquent\Model
# TODO: slowly remove these parameters and fix the issues found.
reportUnmatchedIgnoredErrors: false
ignoreErrors:
# TODO: slowly remove these exceptions and fix the issues found.
# - '#Dynamic call to static method#' # all the Laravel ORM things depend on this.
- '#Dynamic call to static method#' # all the Laravel ORM things depend on this.
- identifier: varTag.nativeType
- identifier: varTag.type
# - '#Control structures using switch should not be used.#' # switch is fine in some cases.
# - '#with no value type specified in iterable type array#' # remove this rule when all other issues are solved.
# - '#has no value type specified in iterable type array#' # remove this rule when all other issues are solved.
@ -48,14 +59,9 @@ parameters:
# message: '#Either catch a more specific exception#'
# paths:
# - ../app/Support/Form/FormSupport.php
paths:
- ../app
- ../database
- ../routes
- ../config
- ../bootstrap/app.php
# The level 8 is the highest level. original was 5
# 7 is more than enough, higher just leaves NULL things.
level: 1
level: 2

16
app/Api/V1/Controllers/Data/Export/ExportController.php
View File

@ -59,7 +59,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function accounts(ExportRequest $request): LaravelResponse
{
@ -100,7 +100,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function bills(ExportRequest $request): LaravelResponse
{
@ -115,7 +115,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function budgets(ExportRequest $request): LaravelResponse
{
@ -130,7 +130,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function categories(ExportRequest $request): LaravelResponse
{
@ -145,7 +145,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function piggyBanks(ExportRequest $request): LaravelResponse
{
@ -160,7 +160,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function recurring(ExportRequest $request): LaravelResponse
{
@ -175,7 +175,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function rules(ExportRequest $request): LaravelResponse
{
@ -190,7 +190,7 @@ class ExportController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function tags(ExportRequest $request): LaravelResponse
{

2
app/Api/V1/Controllers/Models/BudgetLimit/ShowController.php
View File

@ -100,7 +100,7 @@ class ShowController extends Controller
*
* Display a listing of the budget limits for this budget.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function indexAll(SameDateRequest $request): JsonResponse
{

2
app/Api/V1/Controllers/Models/Rule/ExpressionController.php
View File

@ -37,7 +37,7 @@ class ExpressionController extends Controller
* This endpoint is documented at:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/rules/validateExpression
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateExpression(ValidateExpressionRequest $request): JsonResponse
{

2
app/Api/V2/Controllers/Chart/CategoryController.php
View File

@ -71,7 +71,7 @@ class CategoryController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function dashboard(DateRequest $request): JsonResponse
{

2
app/Api/V2/Controllers/Controller.php
View File

@ -74,7 +74,7 @@ class Controller extends BaseController
* TODO duplicate from V1 controller
* Method to grab all parameters from the URL.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
private function getParameters(): ParameterBag
{

4
app/Api/V2/Controllers/Model/Bill/SumController.php
View File

@ -58,7 +58,7 @@ class SumController extends Controller
*
* TODO see autocomplete/accountcontroller for list.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function paid(DateRequest $request): JsonResponse
{
@ -74,7 +74,7 @@ class SumController extends Controller
*
* TODO see autocomplete/accountcontroller for list.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function unpaid(DateRequest $request): JsonResponse
{

4
app/Api/V2/Controllers/Summary/BasicController.php
View File

@ -95,7 +95,7 @@ class BasicController extends Controller
*
* @throws \Exception
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function basic(DateRequest $request): JsonResponse
{
@ -223,7 +223,7 @@ class BasicController extends Controller
}
/**
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
private function getLeftToSpendInfo(Carbon $start, Carbon $end): array
{

2
app/Console/Commands/Upgrade/UpgradesToGroups.php
View File

@ -185,7 +185,7 @@ class UpgradesToGroups extends Command
}
/**
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
private function generateTransaction(TransactionJournal $journal, Transaction $transaction): array
{

2
app/Events/TriggeredAuditLog.php
View File

@ -43,7 +43,7 @@ class TriggeredAuditLog extends Event
/**
* Create a new event instance.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function __construct(Model $changer, Model $auditable, string $field, mixed $before, mixed $after)
{

2
app/Exceptions/GracefulNotFoundHandler.php
View File

@ -48,7 +48,7 @@ class GracefulNotFoundHandler extends ExceptionHandler
*
* @throws \Throwable
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*/
public function render($request, \Throwable $e): Response
{

4
app/Exceptions/Handler.php
View File

@ -78,8 +78,8 @@ class Handler extends ExceptionHandler
*
* @throws \Throwable
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*/
public function render($request, \Throwable $e): Response
{

2
app/Factory/RecurrenceFactory.php
View File

@ -54,7 +54,7 @@ class RecurrenceFactory
/**
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
public function create(array $data): Recurrence
{

2
app/Factory/TransactionFactory.php
View File

@ -218,7 +218,7 @@ class TransactionFactory
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function setUser(User $user): void
{

2
app/Factory/TransactionJournalFactory.php
View File

@ -151,7 +151,7 @@ class TransactionJournalFactory
* @throws DuplicateTransactionException
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
private function createJournal(NullArrayObject $row): ?TransactionJournal
{

2
app/Handlers/Events/UserEventHandler.php
View File

@ -110,7 +110,7 @@ class UserEventHandler
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function createExchangeRates(RegisteredUser $event): void
{

6
app/Helpers/Collector/Extensions/AttachmentCollection.php
View File

@ -124,7 +124,7 @@ trait AttachmentCollection
*
* @return bool
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
$filter = static function (array $object) use ($name): bool {
/** @var array $transaction */
@ -159,7 +159,7 @@ trait AttachmentCollection
*
* @return bool
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
$filter = static function (array $object) use ($name): bool {
/** @var array $transaction */
@ -194,7 +194,7 @@ trait AttachmentCollection
*
* @return bool
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
$filter = static function (array $object) use ($name): bool {
/** @var array $transaction */

2
app/Http/Controllers/Account/EditController.php
View File

@ -71,7 +71,7 @@ class EditController extends Controller
/**
* Edit account overview. It's complex, but it just has a lot of if/then/else.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*
* @return Factory|Redirector|RedirectResponse|View
*/

2
app/Http/Controllers/Auth/LoginController.php
View File

@ -163,7 +163,7 @@ class LoginController extends Controller
/**
* Get the failed login response instance.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*
* @throws ValidationException
*/

2
app/Http/Controllers/Chart/BudgetController.php
View File

@ -483,7 +483,7 @@ class BudgetController extends Controller
*
* Suppress warning because this method will be replaced by API calls.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function period(Budget $budget, TransactionCurrency $currency, Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{

2
app/Http/Controllers/Chart/ExpenseReportController.php
View File

@ -69,7 +69,7 @@ class ExpenseReportController extends Controller
*
* TODO this chart is not multi currency aware.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse
{

2
app/Http/Controllers/Chart/ReportController.php
View File

@ -133,7 +133,7 @@ class ReportController extends Controller
/**
* Shows income and expense, debit/credit: operations.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function operations(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{

4
app/Http/Controllers/Json/RecurrenceController.php
View File

@ -60,8 +60,8 @@ class RecurrenceController extends Controller
/**
* Shows all events for a repetition. Used in calendar.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*
* @throws FireflyException
*/

4
app/Http/Controllers/PreferencesController.php
View File

@ -211,8 +211,8 @@ class PreferencesController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
public function postIndex(PreferencesRequest $request)
{

2
app/Http/Controllers/Recurring/CreateController.php
View File

@ -124,7 +124,7 @@ class CreateController extends Controller
/**
* @return Factory|\Illuminate\Contracts\View\View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function createFromJournal(Request $request, TransactionJournal $journal)
{

4
app/Http/Controllers/Report/CategoryController.php
View File

@ -156,7 +156,7 @@ class CategoryController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function accounts(Collection $accounts, Collection $categories, Carbon $start, Carbon $end)
{
@ -358,7 +358,7 @@ class CategoryController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function categories(Collection $accounts, Collection $categories, Carbon $start, Carbon $end)
{

2
app/Http/Controllers/Report/DoubleController.php
View File

@ -165,7 +165,7 @@ class DoubleController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function operations(Collection $accounts, Collection $double, Carbon $start, Carbon $end)
{

6
app/Http/Controllers/Report/TagController.php
View File

@ -59,7 +59,7 @@ class TagController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function accountPerTag(Collection $accounts, Collection $tags, Carbon $start, Carbon $end)
{
@ -153,7 +153,7 @@ class TagController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function accounts(Collection $accounts, Collection $tags, Carbon $start, Carbon $end)
{
@ -355,7 +355,7 @@ class TagController extends Controller
/**
* @return Factory|View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function tags(Collection $accounts, Collection $tags, Carbon $start, Carbon $end)
{

2
app/Http/Middleware/Authenticate.php
View File

@ -76,7 +76,7 @@ class Authenticate
* @throws FireflyException
* @throws AuthenticationException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
protected function authenticate($request, array $guards)
{

2
app/Http/Requests/RecurrenceFormRequest.php
View File

@ -52,7 +52,7 @@ class RecurrenceFormRequest extends FormRequest
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function getAll(): array
{

3
app/Models/UserGroup.php
View File

@ -26,6 +26,7 @@ namespace FireflyIII\Models;
use FireflyIII\Enums\UserRoleEnum;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
use FireflyIII\Support\Models\ReturnsIntegerIdTrait;
use FireflyIII\User;
use Illuminate\Database\Eloquent\Model;
@ -151,7 +152,7 @@ class UserGroup extends Model
*/
public function piggyBanks(): HasManyThrough
{
throw new FireflyException('This user group method is EOL.');
return $this->hasManyThrough( PiggyBank::class, Account::class);
}
public function recurrences(): HasMany

12
app/Notifications/Admin/UnknownUserLoginAttempt.php
View File

@ -48,7 +48,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -57,7 +57,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(OwnerNotifiable $notifiable): MailMessage
{
@ -73,7 +73,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(OwnerNotifiable $notifiable): Message
{
@ -87,7 +87,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(OwnerNotifiable $notifiable): PushoverMessage
{
@ -97,7 +97,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(OwnerNotifiable $notifiable): SlackMessage
{
@ -107,7 +107,7 @@ class UnknownUserLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

12
app/Notifications/Admin/UserInvitation.php
View File

@ -55,7 +55,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -64,7 +64,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(OwnerNotifiable $notifiable)
{
@ -81,7 +81,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(OwnerNotifiable $notifiable): Message
{
@ -96,7 +96,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(OwnerNotifiable $notifiable): PushoverMessage
{
@ -108,7 +108,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(OwnerNotifiable $notifiable)
{
@ -118,7 +118,7 @@ class UserInvitation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

12
app/Notifications/Admin/UserRegistration.php
View File

@ -55,7 +55,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -64,7 +64,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(OwnerNotifiable $notifiable)
{
@ -80,7 +80,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(OwnerNotifiable $notifiable): Message
{
@ -95,7 +95,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(OwnerNotifiable $notifiable): PushoverMessage
{
@ -107,7 +107,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(OwnerNotifiable $notifiable)
{
@ -115,7 +115,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

12
app/Notifications/Admin/VersionCheckResult.php
View File

@ -50,7 +50,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -59,7 +59,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(OwnerNotifiable $notifiable)
{
@ -70,7 +70,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(OwnerNotifiable $notifiable): Message
{
@ -85,7 +85,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(OwnerNotifiable $notifiable): PushoverMessage
{
@ -97,7 +97,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(OwnerNotifiable $notifiable)
{
@ -109,7 +109,7 @@ class VersionCheckResult extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

10
app/Notifications/Security/DisabledMFANotification.php
View File

@ -48,7 +48,7 @@ class DisabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class DisabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -82,7 +82,7 @@ class DisabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class DisabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -102,7 +102,7 @@ class DisabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

10
app/Notifications/Security/EnabledMFANotification.php
View File

@ -48,7 +48,7 @@ class EnabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class EnabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -82,7 +82,7 @@ class EnabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class EnabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -102,7 +102,7 @@ class EnabledMFANotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

10
app/Notifications/Security/MFABackupFewLeftNotification.php
View File

@ -50,7 +50,7 @@ class MFABackupFewLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -59,7 +59,7 @@ class MFABackupFewLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -84,7 +84,7 @@ class MFABackupFewLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -94,7 +94,7 @@ class MFABackupFewLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -104,7 +104,7 @@ class MFABackupFewLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

10
app/Notifications/Security/MFABackupNoLeftNotification.php
View File

@ -48,7 +48,7 @@ class MFABackupNoLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class MFABackupNoLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -82,7 +82,7 @@ class MFABackupNoLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class MFABackupNoLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -102,7 +102,7 @@ class MFABackupNoLeftNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/Security/MFAManyFailedAttemptsNotification.php
View File

@ -56,7 +56,7 @@ class MFAManyFailedAttemptsNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -81,7 +81,7 @@ class MFAManyFailedAttemptsNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -91,7 +91,7 @@ class MFAManyFailedAttemptsNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -101,7 +101,7 @@ class MFAManyFailedAttemptsNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

10
app/Notifications/Security/MFAUsedBackupCodeNotification.php
View File

@ -48,7 +48,7 @@ class MFAUsedBackupCodeNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class MFAUsedBackupCodeNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -82,7 +82,7 @@ class MFAUsedBackupCodeNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class MFAUsedBackupCodeNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -102,7 +102,7 @@ class MFAUsedBackupCodeNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

10
app/Notifications/Security/NewBackupCodesNotification.php
View File

@ -48,7 +48,7 @@ class NewBackupCodesNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class NewBackupCodesNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -82,7 +82,7 @@ class NewBackupCodesNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class NewBackupCodesNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -102,7 +102,7 @@ class NewBackupCodesNotification extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/Security/UserFailedLoginAttempt.php
View File

@ -54,7 +54,7 @@ class UserFailedLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -79,7 +79,7 @@ class UserFailedLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -89,7 +89,7 @@ class UserFailedLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -99,7 +99,7 @@ class UserFailedLoginAttempt extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

6
app/Notifications/Test/OwnerTestNotificationEmail.php
View File

@ -44,7 +44,7 @@ class OwnerTestNotificationEmail extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -53,7 +53,7 @@ class OwnerTestNotificationEmail extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(OwnerNotifiable $notifiable)
{
@ -66,7 +66,7 @@ class OwnerTestNotificationEmail extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

6
app/Notifications/Test/OwnerTestNotificationNtfy.php
View File

@ -48,7 +48,7 @@ class OwnerTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*
* @param mixed $notifiable
*/
@ -59,7 +59,7 @@ class OwnerTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(OwnerNotifiable $notifiable): Message
{
@ -74,7 +74,7 @@ class OwnerTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

6
app/Notifications/Test/OwnerTestNotificationPushover.php
View File

@ -48,7 +48,7 @@ class OwnerTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -57,7 +57,7 @@ class OwnerTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(OwnerNotifiable $notifiable): PushoverMessage
{
@ -69,7 +69,7 @@ class OwnerTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

6
app/Notifications/Test/OwnerTestNotificationSlack.php
View File

@ -46,7 +46,7 @@ class OwnerTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(OwnerNotifiable $notifiable)
{
@ -55,7 +55,7 @@ class OwnerTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(OwnerNotifiable $notifiable)
{
@ -64,7 +64,7 @@ class OwnerTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(OwnerNotifiable $notifiable)
{

4
app/Notifications/Test/UserTestNotificationEmail.php
View File

@ -44,7 +44,7 @@ class UserTestNotificationEmail extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -63,7 +63,7 @@ class UserTestNotificationEmail extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

6
app/Notifications/Test/UserTestNotificationNtfy.php
View File

@ -48,7 +48,7 @@ class UserTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class UserTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toNtfy(User $user): Message
{
@ -72,7 +72,7 @@ class UserTestNotificationNtfy extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $user)
{

6
app/Notifications/Test/UserTestNotificationPushover.php
View File

@ -48,7 +48,7 @@ class UserTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -57,7 +57,7 @@ class UserTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -69,7 +69,7 @@ class UserTestNotificationPushover extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

6
app/Notifications/Test/UserTestNotificationSlack.php
View File

@ -46,7 +46,7 @@ class UserTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $user)
{
@ -55,7 +55,7 @@ class UserTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $user)
{
@ -64,7 +64,7 @@ class UserTestNotificationSlack extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $user)
{

10
app/Notifications/User/BillReminder.php
View File

@ -54,7 +54,7 @@ class BillReminder extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -63,7 +63,7 @@ class BillReminder extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -95,7 +95,7 @@ class BillReminder extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -105,7 +105,7 @@ class BillReminder extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -122,7 +122,7 @@ class BillReminder extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/User/NewAccessToken.php
View File

@ -52,7 +52,7 @@ class NewAccessToken extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -79,7 +79,7 @@ class NewAccessToken extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -89,7 +89,7 @@ class NewAccessToken extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -97,7 +97,7 @@ class NewAccessToken extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/User/RuleActionFailed.php
View File

@ -57,7 +57,7 @@ class RuleActionFailed extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -76,7 +76,7 @@ class RuleActionFailed extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -84,7 +84,7 @@ class RuleActionFailed extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -101,7 +101,7 @@ class RuleActionFailed extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

6
app/Notifications/User/TransactionCreation.php
View File

@ -44,7 +44,7 @@ class TransactionCreation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -53,7 +53,7 @@ class TransactionCreation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -64,7 +64,7 @@ class TransactionCreation extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/User/UserLogin.php
View File

@ -50,7 +50,7 @@ class UserLogin extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -79,7 +79,7 @@ class UserLogin extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -92,7 +92,7 @@ class UserLogin extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{
@ -103,7 +103,7 @@ class UserLogin extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

8
app/Notifications/User/UserNewPassword.php
View File

@ -51,7 +51,7 @@ class UserNewPassword extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -60,7 +60,7 @@ class UserNewPassword extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -86,7 +86,7 @@ class UserNewPassword extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toPushover(User $notifiable): PushoverMessage
{
@ -94,7 +94,7 @@ class UserNewPassword extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toSlack(User $notifiable)
{

6
app/Notifications/User/UserRegistration.php
View File

@ -39,7 +39,7 @@ class UserRegistration extends Notification
public function __construct() {}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toArray(User $notifiable)
{
@ -48,7 +48,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function toMail(User $notifiable)
{
@ -59,7 +59,7 @@ class UserRegistration extends Notification
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function via(User $notifiable)
{

2
app/Providers/AuthServiceProvider.php
View File

@ -42,7 +42,7 @@ class AuthServiceProvider extends ServiceProvider
/**
* Register any authentication / authorization services.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function boot(): void
{

2
app/Providers/BudgetServiceProvider.php
View File

@ -55,7 +55,7 @@ class BudgetServiceProvider extends ServiceProvider
/**
* Register the application services.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function register(): void
{

2
app/Providers/FireflyServiceProvider.php
View File

@ -98,7 +98,7 @@ class FireflyServiceProvider extends ServiceProvider
/**
* Register stuff.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function register(): void
{

16
app/Repositories/Account/OperationsRepository.php
View File

@ -122,7 +122,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpenses(
Carbon $start,
@ -137,8 +137,8 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
private function getTransactionsForSum(
string $type,
@ -223,7 +223,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpensesByDestination(
Carbon $start,
@ -245,7 +245,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpensesBySource(
Carbon $start,
@ -260,7 +260,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncome(
Carbon $start,
@ -275,7 +275,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncomeByDestination(
Carbon $start,
@ -290,7 +290,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncomeBySource(
Carbon $start,

12
app/Repositories/Account/OperationsRepositoryInterface.php
View File

@ -54,7 +54,7 @@ interface OperationsRepositoryInterface
/**
* Sum of withdrawal journals in period for a set of accounts, grouped per currency. Amounts are always negative.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpenses(
Carbon $start,
@ -68,7 +68,7 @@ interface OperationsRepositoryInterface
* Sum of withdrawal journals in period for a set of accounts, grouped per destination / currency. Amounts are
* always negative.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpensesByDestination(
Carbon $start,
@ -82,7 +82,7 @@ interface OperationsRepositoryInterface
* Sum of withdrawal journals in period for a set of accounts, grouped per source / currency. Amounts are always
* negative.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpensesBySource(
Carbon $start,
@ -95,7 +95,7 @@ interface OperationsRepositoryInterface
/**
* Sum of income journals in period for a set of accounts, grouped per currency. Amounts are always positive.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncome(
Carbon $start,
@ -109,7 +109,7 @@ interface OperationsRepositoryInterface
* Sum of income journals in period for a set of accounts, grouped per destination + currency. Amounts are always
* positive.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncomeByDestination(
Carbon $start,
@ -123,7 +123,7 @@ interface OperationsRepositoryInterface
* Sum of income journals in period for a set of accounts, grouped per source + currency. Amounts are always
* positive.
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumIncomeBySource(
Carbon $start,

2
app/Repositories/Budget/BudgetRepository.php
View File

@ -721,7 +721,7 @@ class BudgetRepository implements BudgetRepositoryInterface
/**
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
public function store(array $data): Budget
{

2
app/Repositories/Budget/OperationsRepository.php
View File

@ -203,7 +203,7 @@ class OperationsRepository implements OperationsRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpenses(
Carbon $start,

2
app/Repositories/Budget/OperationsRepositoryInterface.php
View File

@ -57,7 +57,7 @@ interface OperationsRepositoryInterface
public function setUser(null|Authenticatable|User $user): void;
/**
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings("PHPMD.ExcessiveParameterList")
*/
public function sumExpenses(
Carbon $start,

2
app/Repositories/UserGroup/UserGroupRepository.php
View File

@ -203,7 +203,7 @@ class UserGroupRepository implements UserGroupRepositoryInterface
}
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*
* @throws FireflyException
*/

2
app/Rules/Admin/IsValidDiscordUrl.php
View File

@ -34,7 +34,7 @@ class IsValidDiscordUrl implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/Admin/IsValidSlackOrDiscordUrl.php
View File

@ -34,7 +34,7 @@ class IsValidSlackOrDiscordUrl implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/Admin/IsValidSlackUrl.php
View File

@ -34,7 +34,7 @@ class IsValidSlackUrl implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsAssetAccountId.php
View File

@ -34,7 +34,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class IsAssetAccountId implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsBoolean.php
View File

@ -32,7 +32,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class IsBoolean implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsDateOrTime.php
View File

@ -35,7 +35,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class IsDateOrTime implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsDefaultUserGroupName.php
View File

@ -42,7 +42,7 @@ class IsDefaultUserGroupName implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsDuplicateTransaction.php
View File

@ -36,7 +36,7 @@ class IsDuplicateTransaction implements ValidationRule
private string $value;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsFilterValueIn.php
View File

@ -38,7 +38,7 @@ class IsFilterValueIn implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsTransferAccount.php
View File

@ -35,7 +35,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class IsTransferAccount implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidActionExpression.php
View File

@ -36,7 +36,7 @@ class IsValidActionExpression implements ValidationRule
*
* @param \Closure(string): PotentiallyTranslatedString $fail
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidAmount.php
View File

@ -34,7 +34,7 @@ class IsValidAmount implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidAttachmentModel.php
View File

@ -68,7 +68,7 @@ class IsValidAttachmentModel implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidBulkClause.php
View File

@ -47,7 +47,7 @@ class IsValidBulkClause implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidDateRange.php
View File

@ -32,7 +32,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class IsValidDateRange implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidPositiveAmount.php
View File

@ -34,7 +34,7 @@ class IsValidPositiveAmount implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/IsValidZeroOrMoreAmount.php
View File

@ -34,7 +34,7 @@ class IsValidZeroOrMoreAmount implements ValidationRule
use ValidatesAmountsTrait;
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/LessThanPiggyTarget.php
View File

@ -40,7 +40,7 @@ class LessThanPiggyTarget implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/UniqueAccountNumber.php
View File

@ -70,7 +70,7 @@ class UniqueAccountNumber implements ValidationRule
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/UniqueIban.php
View File

@ -85,7 +85,7 @@ class UniqueIban implements ValidationRule
* @param string $attribute
* @param mixed $value
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function passes($attribute, $value): bool
{

2
app/Rules/ValidJournals.php
View File

@ -33,7 +33,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class ValidJournals implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/ValidRecurrenceRepetitionType.php
View File

@ -34,7 +34,7 @@ class ValidRecurrenceRepetitionType implements ValidationRule
/**
* Determine if the validation rule passes.
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Rules/ValidRecurrenceRepetitionValue.php
View File

@ -33,7 +33,7 @@ use Illuminate\Contracts\Validation\ValidationRule;
class ValidRecurrenceRepetitionValue implements ValidationRule
{
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(string $attribute, mixed $value, \Closure $fail): void
{

2
app/Services/Internal/Support/AccountServiceTrait.php
View File

@ -90,7 +90,7 @@ trait AccountServiceTrait
/**
* Update metadata for account. Depends on type which fields are valid.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*
* TODO this method treats expense accounts and liabilities the same way (tries to save interest)
*/

6
app/Services/Internal/Support/CreditRecalculateService.php
View File

@ -236,9 +236,9 @@ class CreditRecalculateService
/**
* A complex and long method, but rarely used luckily.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
* @SuppressWarnings("PHPMD.NPathComplexity")
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*/
private function processTransaction(Account $account, string $direction, Transaction $transaction, string $leftOfDebt): string
{

2
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@ -91,7 +91,7 @@ trait RecurringTransactionTrait
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
protected function createTransactions(Recurrence $recurrence, array $transactions): void
{

2
app/Services/Internal/Update/BillUpdateService.php
View File

@ -131,7 +131,7 @@ class BillUpdateService
}
/**
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
*/
private function updateBillProperties(Bill $bill, array $data): Bill
{

4
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@ -250,8 +250,8 @@ class RecurrenceUpdateService
/**
* It's a complex method but nothing surprising.
*
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings("PHPMD.NPathComplexity")
* @SuppressWarnings("PHPMD.CyclomaticComplexity")
*/
private function updateCombination(Recurrence $recurrence, array $combination): void
{

2
app/Services/Webhook/StandardWebhookSender.php
View File

@ -49,7 +49,7 @@ class StandardWebhookSender implements WebhookSenderInterface
/**
* @throws GuzzleException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings("PHPMD.ExcessiveMethodLength")
*/
public function send(): void
{

4
app/Support/Authentication/RemoteUserGuard.php
View File

@ -137,7 +137,7 @@ class RemoteUserGuard implements Guard
}
/**
* @SuppressWarnings(PHPMD.ShortMethodName)
* @SuppressWarnings("PHPMD.ShortMethodName")
*/
public function id(): null|int|string
{
@ -160,7 +160,7 @@ class RemoteUserGuard implements Guard
/**
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validate(array $credentials = []): bool
{

8
app/Support/Authentication/RemoteUserProvider.php
View File

@ -47,7 +47,7 @@ class RemoteUserProvider implements UserProvider
/**
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function retrieveByCredentials(array $credentials): ?Authenticatable
{
@ -95,7 +95,7 @@ class RemoteUserProvider implements UserProvider
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function retrieveByToken($identifier, $token): ?Authenticatable
{
@ -105,7 +105,7 @@ class RemoteUserProvider implements UserProvider
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*
* @param mixed $token
*
@ -121,7 +121,7 @@ class RemoteUserProvider implements UserProvider
/**
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public function validateCredentials(Authenticatable $user, array $credentials): bool
{

2
app/Support/Binder/DynamicConfigKey.php
View File

@ -43,7 +43,7 @@ class DynamicConfigKey
/**
* @throws NotFoundHttpException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public static function routeBinder(string $value, Route $route): string
{

2
app/Support/Binder/EitherConfigKey.php
View File

@ -62,7 +62,7 @@ class EitherConfigKey
/**
* @throws NotFoundHttpException
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @SuppressWarnings("PHPMD.UnusedFormalParameter")
*/
public static function routeBinder(string $value, Route $route): string
{

Some files were not shown because too many files have changed in this diff Show More