IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Switch opening balance.

Browse Source
This commit is contained in:
James Cole 2023-01-08 19:47:39 +01:00
parent d90321aa1e
commit fe9620a438
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/Console/Commands/Upgrade/UpgradeLiabilitiesEight.php
View File

@ -26,6 +26,7 @@ namespace FireflyIII\Console\Commands\Upgrade;
use FireflyIII\Exceptions\FireflyException; use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\Account; use FireflyIII\Models\Account;
use FireflyIII\Models\Transaction;
use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType; use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\Repositories\Account\AccountRepositoryInterface;
@ -145,6 +146,7 @@ class UpgradeLiabilitiesEight extends Command
} }
if ('credit' === $direction && $this->hasBadOpening($account)) { if ('credit' === $direction && $this->hasBadOpening($account)) {
$this->deleteCreditTransaction($account); $this->deleteCreditTransaction($account);
$this->reverseOpeningBalance($account);
$this->line(sprintf('Fixed correct bad opening for liability #%d ("%s")', $account->id, $account->name)); $this->line(sprintf('Fixed correct bad opening for liability #%d ("%s")', $account->id, $account->name));
} }
Log::debug(sprintf('Done upgrading liability #%d ("%s")', $account->id, $account->name)); Log::debug(sprintf('Done upgrading liability #%d ("%s")', $account->id, $account->name));
@ -210,4 +212,33 @@ class UpgradeLiabilitiesEight extends Command
return true; return true;
} }
/**
* @param Account $account
* @return void
*/
private function reverseOpeningBalance(Account $account): void
{
$openingBalanceType = TransactionType::whereType(TransactionType::OPENING_BALANCE)->first();
/** @var TransactionJournal $openingJournal */
$openingJournal = TransactionJournal::leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id')
->where('transactions.account_id', $account->id)
->where('transaction_journals.transaction_type_id', $openingBalanceType->id)
->first(['transaction_journals.*']);
/** @var Transaction $source */
$source = $openingJournal->transactions()->where('amount', '<', 0)->first();
/** @var Transaction $dest */
$dest = $openingJournal->transactions()->where('amount', '>', 0)->first();
if($source && $dest) {
$sourceId = $source->account_id;
$destId = $dest->account_id;
$dest->account_id = $sourceId;
$source->account_id = $destId;
$source->save();
$dest->save();
Log::debug(sprintf('Opening balance transaction journal #%d reversed.', $openingJournal->id));
return;
}
Log::warning('Did not find opening balance.');
}
} }