diff --git a/addons/stock/models/stock_move_line.py b/addons/stock/models/stock_move_line.py
index 5b5812cdb6..9f5d02ec89 100644
--- a/addons/stock/models/stock_move_line.py
+++ b/addons/stock/models/stock_move_line.py
@@ -619,16 +619,17 @@ class StockMoveLine(models.Model):
# As the move's state is not computed over the move lines, we'll have to manually
# recompute the moves which we adapted their lines.
move_to_recompute_state = self.env['stock.move']
+ to_unlink_candidates = set()
rounding = self.product_uom_id.rounding
for candidate in outdated_candidates:
if float_compare(candidate.product_qty, quantity, precision_rounding=rounding) <= 0:
quantity -= candidate.product_qty
- move_to_recompute_state |= candidate.move_id
if candidate.qty_done:
+ move_to_recompute_state |= candidate.move_id
candidate.product_uom_qty = 0.0
else:
- candidate.unlink()
+ to_unlink_candidates.add(candidate.id)
if float_is_zero(quantity, precision_rounding=rounding):
break
else:
@@ -640,6 +641,7 @@ class StockMoveLine(models.Model):
candidate.product_uom_qty = self.product_id.uom_id._compute_quantity(quantity_split, candidate.product_uom_id, rounding_method='HALF-UP')
move_to_recompute_state |= candidate.move_id
break
+ self.env['stock.move.line'].browse(to_unlink_candidates).unlink()
move_to_recompute_state._recompute_state()
def _should_bypass_reservation(self, location):
diff --git a/addons/stock/static/src/js/report_stock_forecasted.js b/addons/stock/static/src/js/report_stock_forecasted.js
index 800bb0a5cb..1584c06af5 100644
--- a/addons/stock/static/src/js/report_stock_forecasted.js
+++ b/addons/stock/static/src/js/report_stock_forecasted.js
@@ -26,7 +26,7 @@ const ReplenishReport = clientAction.extend({
if (this.context.warehouse) {
this.active_warehouse = {id: this.context.warehouse};
}
- this.report_url += `?context=${JSON.stringify(this.context)}`;
+ this.report_url += `?context=${JSON.stringify(this.context)}&force_context_lang=1`;
this._title = action.name;
},
diff --git a/addons/stock_account/models/account_move.py b/addons/stock_account/models/account_move.py
index ef4a19aa97..05b230f82b 100644
--- a/addons/stock_account/models/account_move.py
+++ b/addons/stock_account/models/account_move.py
@@ -34,7 +34,7 @@ class AccountMove(models.Model):
for copy_vals in res:
if 'line_ids' in copy_vals:
copy_vals['line_ids'] = [line_vals for line_vals in copy_vals['line_ids']
- if line_vals[0] != 0 or not line_vals[2]['is_anglo_saxon_line']]
+ if line_vals[0] != 0 or not line_vals[2].get('is_anglo_saxon_line')]
return res
diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py
index 48746fa50d..c5b3a244de 100644
--- a/addons/web/controllers/main.py
+++ b/addons/web/controllers/main.py
@@ -2046,7 +2046,7 @@ class ReportController(http.Controller):
# Ignore 'lang' here, because the context in data is the one from the webclient *but* if
# the user explicitely wants to change the lang, this mechanism overwrites it.
data['context'] = json.loads(data['context'])
- if data['context'].get('lang'):
+ if data['context'].get('lang') and not data.get('force_context_lang'):
del data['context']['lang']
context.update(data['context'])
if converter == 'html':
diff --git a/addons/web/static/src/js/fields/basic_fields.js b/addons/web/static/src/js/fields/basic_fields.js
index 603804edd8..fc5d191da8 100644
--- a/addons/web/static/src/js/fields/basic_fields.js
+++ b/addons/web/static/src/js/fields/basic_fields.js
@@ -647,6 +647,31 @@ var FieldDateRange = InputField.extend({
}
this._super.apply(this, arguments);
},
+
+ //--------------------------------------------------------------------------
+ // Public
+ //--------------------------------------------------------------------------
+
+ /**
+ * Field widget is valid if value entered can convered to date/dateime value
+ * while parsing input value to date/datetime throws error then widget considered
+ * invalid
+ *
+ * @override
+ */
+ isValid: function () {
+ const value = this.mode === "readonly" ? this.value : this.$input.val();
+ try {
+ return field_utils.parse[this.formatType](value, this.field, { timezone: true }) || true;
+ } catch (error) {
+ return false;
+ }
+ },
+
+ //--------------------------------------------------------------------------
+ // Private
+ //--------------------------------------------------------------------------
+
/**
* Return the date written in the input, in UTC.
*
@@ -654,7 +679,14 @@ var FieldDateRange = InputField.extend({
* @returns {Moment|false}
*/
_getValue: function () {
- return field_utils.parse[this.formatType](this.$input.val(), this.field, { timezone: true });
+ try {
+ // user may enter manual value in input and it may not be parsed as date/datetime value
+ this.removeInvalidClass();
+ return field_utils.parse[this.formatType](this.$input.val(), this.field, { timezone: true });
+ } catch (error) {
+ this.setInvalidClass();
+ return false;
+ }
},
//--------------------------------------------------------------------------
diff --git a/addons/web/static/src/js/views/list/list_editable_renderer.js b/addons/web/static/src/js/views/list/list_editable_renderer.js
index 9aa6e1bba5..fe91d59910 100644
--- a/addons/web/static/src/js/views/list/list_editable_renderer.js
+++ b/addons/web/static/src/js/views/list/list_editable_renderer.js
@@ -1837,6 +1837,12 @@ ListRenderer.include({
return;
}
+ // ignore click if search facet is removed as it will re-render whole
+ // listview again
+ if ($(event.target).hasClass('o_facet_remove')) {
+ return;
+ }
+
this.unselectRow();
},
});
diff --git a/addons/web/static/src/scss/list_view.scss b/addons/web/static/src/scss/list_view.scss
index 734f5053a4..8f57209e2e 100644
--- a/addons/web/static/src/scss/list_view.scss
+++ b/addons/web/static/src/scss/list_view.scss
@@ -261,7 +261,9 @@
.o_data_row.o_selected_row > .o_data_cell:not(.o_readonly_modifier):not(.o_invisible_modifier) {
position: relative; // for o_field_translate
- background-color: white;
+ &:not(.o_handle_cell) {
+ background-color: white;
+ }
.o_input {
border: none;
padding: 0;
diff --git a/addons/web/static/tests/fields/basic_fields_tests.js b/addons/web/static/tests/fields/basic_fields_tests.js
index 83b38f61f2..138047e6f7 100644
--- a/addons/web/static/tests/fields/basic_fields_tests.js
+++ b/addons/web/static/tests/fields/basic_fields_tests.js
@@ -3531,6 +3531,49 @@ QUnit.module('basic_fields', {
form.destroy();
});
+ QUnit.test('Daterange field manually input wrong value should show toaster', async function (assert) {
+ assert.expect(5);
+
+ this.data.partner.fields.date_end = { string: 'Date End', type: 'date' };
+ this.data.partner.records[0].date_end = '2017-02-08';
+
+ const form = await createView({
+ View: FormView,
+ model: 'partner',
+ data: this.data,
+ arch: `
+
`,
+ interceptsPropagate: {
+ call_service: function (ev) {
+ if (ev.data.service === 'notification') {
+ assert.strictEqual(ev.data.method, 'notify');
+ assert.strictEqual(ev.data.args[0].title, 'Invalid fields:');
+ assert.strictEqual(ev.data.args[0].message, '
');
+ }
+ }
+ },
+ });
+
+ await testUtils.fields.editInput(form.$('.o_field_date_range:first'), 'blabla');
+ // click outside daterange field
+ await testUtils.dom.click(form.$el);
+ assert.hasClass(form.$('input[name=date]'), 'o_field_invalid',
+ "date field should be displayed as invalid");
+ // update input date with right value
+ await testUtils.fields.editInput(form.$('.o_field_date_range:first'), '02/08/2017');
+ assert.doesNotHaveClass(form.$('input[name=date]'), 'o_field_invalid',
+ "date field should not be displayed as invalid now");
+
+ // again enter wrong value and try to save should raise invalid fields value
+ await testUtils.fields.editInput(form.$('.o_field_date_range:first'), 'blabla');
+ await testUtils.form.clickSave(form);
+
+ form.destroy();
+ });
+
QUnit.module('FieldDate');
QUnit.test('date field: toggle datepicker [REQUIRE FOCUS]', async function (assert) {
diff --git a/addons/web/static/tests/views/list_tests.js b/addons/web/static/tests/views/list_tests.js
index f9745a13bb..39e4b45751 100644
--- a/addons/web/static/tests/views/list_tests.js
+++ b/addons/web/static/tests/views/list_tests.js
@@ -9931,6 +9931,53 @@ QUnit.module('Views', {
list.destroy();
});
+ QUnit.test('removing a groupby while adding a line from list', async function (assert) {
+ assert.expect(1);
+
+ let checkUnselectRow = false;
+ testUtils.mock.patch(ListRenderer, {
+ unselectRow(options = {}) {
+ if (checkUnselectRow) {
+ assert.step('unselectRow');
+ }
+ return this._super(...arguments);
+ },
+ });
+
+ const list = await createView({
+ View: ListView,
+ model: 'foo',
+ data: this.data,
+ arch: `
+
+
+
+
+ `,
+ archs: {
+ 'foo,false,search': `
+
+
+
+
+
+
+ `,
+ },
+ });
+
+ await cpHelpers.toggleGroupByMenu(list);
+ await cpHelpers.toggleMenuItem(list, 0);
+ // expand group
+ await testUtils.dom.click(list.el.querySelector('th.o_group_name'));
+ await testUtils.dom.click(list.el.querySelector('td.o_group_field_row_add a'));
+ checkUnselectRow = true;
+ await testUtils.dom.click($('.o_searchview_facet .o_facet_remove'));
+ assert.verifySteps([]);
+ testUtils.mock.unpatch(ListRenderer);
+ list.destroy();
+ });
+
QUnit.test('cell-level keyboard navigation in editable grouped list', async function (assert) {
assert.expect(56);