From 014a0bf8a2455f4506457f2a21a7260b96866260 Mon Sep 17 00:00:00 2001 From: Joshua Sled Date: Tue, 2 May 2006 00:11:49 +0000 Subject: [PATCH] Bug#340358: mem/string-handling crasher fix. git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@13894 57a11ea4-9604-0410-9ed3-97b8803252fd --- ChangeLog | 6 ++++++ src/register/register-gnome/pricecell-gnome.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 909ee94cc7..ca9e220787 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-05-01 Joshua Sled + + * src/register/register-gnome/pricecell-gnome.c + (gnc_price_cell_direct_update): null-terminate strings we traffic + in, leading to less crashes! :( Bug#340358. + 2006-04-30 David Hampton * src/gnome/reconcile-list.c: Patch from Mike Alexander to fix the diff --git a/src/register/register-gnome/pricecell-gnome.c b/src/register/register-gnome/pricecell-gnome.c index 74b064589c..34d4111d0d 100644 --- a/src/register/register-gnome/pricecell-gnome.c +++ b/src/register/register-gnome/pricecell-gnome.c @@ -127,7 +127,8 @@ gnc_price_cell_direct_update (BasicCell *bcell, end = MAX(*start_selection, *end_selection); /* length in bytes, not chars. do not use g_utf8_strlen. */ - buf = malloc(strlen(bcell->value)); + buf = malloc(strlen(bcell->value)+1); + memset(buf, 0, strlen(bcell->value)+1); g_utf8_strncpy(buf, bcell->value, start); g_string_append(newval_gs, buf); g_free(buf);