diff --git a/ChangeLog b/ChangeLog index 93b1c296b2..82fc220ab5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2005-12-04 David Hampton + + * src/gnome-utils/test/test-gnc-recurrence.c: + * src/engine/test-core/test-engine-stuff.c: + * src/engine/gnc-associate-account.c: + * lib/libqof/qof/qofquery.c: Don't ignore the return value of glib + list functions. This will likely become a warning in future + version of glib, which translates to an error for gnucash since it + compiles with the -Werror flag. + 2005-12-04 Derek Atkins * macros/autogen.sh: don't warn the user about running diff --git a/lib/libqof/qof/qofquery.c b/lib/libqof/qof/qofquery.c index fbfc1c0bc7..02f2366584 100644 --- a/lib/libqof/qof/qofquery.c +++ b/lib/libqof/qof/qofquery.c @@ -1243,8 +1243,8 @@ void qof_query_set_book (QofQuery *q, QofBook *book) if (g_list_index (q->books, book) == -1) q->books = g_list_prepend (q->books, book); - g_slist_prepend (slist, QOF_PARAM_GUID); - g_slist_prepend (slist, QOF_PARAM_BOOK); + slist = g_slist_prepend (slist, QOF_PARAM_GUID); + slist = g_slist_prepend (slist, QOF_PARAM_BOOK); qof_query_add_guid_match (q, slist, qof_book_get_guid(book), QOF_QUERY_AND); } diff --git a/src/engine/gnc-associate-account.c b/src/engine/gnc-associate-account.c index e6965527ea..1e16239e6d 100644 --- a/src/engine/gnc-associate-account.c +++ b/src/engine/gnc-associate-account.c @@ -172,7 +172,7 @@ de_kvp_account_list(KvpValue *kvpd_list, QofBook *book) GList *expense_acc_list= NULL; for(; guid_account_list; guid_account_list=g_list_next(guid_account_list)) { - g_list_prepend(expense_acc_list, + expense_acc_list = g_list_prepend(expense_acc_list, xaccAccountLookup(guid_account_list->data, book)); } @@ -382,7 +382,7 @@ gnc_tracking_find_all_income_accounts(Account *stock_account) for(i = 0; i < GNC_TR_EXP_N_CATEGORIES; i++) { - g_list_concat(complete_list, + complete_list = g_list_concat(complete_list, gnc_tracking_find_expense_accounts(stock_account, i)); } diff --git a/src/engine/test-core/test-engine-stuff.c b/src/engine/test-core/test-engine-stuff.c index e0141d27c8..8ab3137440 100644 --- a/src/engine/test-core/test-engine-stuff.c +++ b/src/engine/test-core/test-engine-stuff.c @@ -1456,7 +1456,7 @@ get_random_guids(int max) num_guids = get_random_int_in_range (1, max); while (num_guids-- > 0) - g_list_prepend (guids, get_random_guid ()); + guids = g_list_prepend (guids, get_random_guid ()); return guids; } diff --git a/src/gnome-utils/test/test-gnc-recurrence.c b/src/gnome-utils/test/test-gnc-recurrence.c index e6589055c3..8386c6484e 100644 --- a/src/gnome-utils/test/test-gnc-recurrence.c +++ b/src/gnome-utils/test/test-gnc-recurrence.c @@ -55,7 +55,7 @@ static void show_gnc_recurrence() rw = GNC_RECURRENCE(gnc_recurrence_new()); r = g_new(Recurrence, 1); - g_list_append(rl, r); + rl = g_list_append(rl, r); g_date_set_dmy(&d, 17, 4, 2005); recurrenceSet(r, 1, PERIOD_WEEK, &d);