IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 798262 - Scheduled transactions with blank amounts do not get created.

Browse Source 
Handle template transactions that don't have any splits with empty credit
and debit strings and those having no set transaction account.

Set the concrete transaction commodity to the first found of:
The template transaction's commodity
The commodity of the first split with a credit or debit string
The commodity of the first split.
This commit is contained in:
John Ralls 2022-08-14 15:31:46 -07:00
parent 410db42df0
commit 087501d316
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libgnucash/app-utils/gnc-sx-instance-model.c
View File

@ -1206,7 +1206,8 @@ static gnc_commodity*
get_transaction_currency(SxTxnCreationData *creation_data,
SchedXaction *sx, Transaction *template_txn)
{
gnc_commodity *first_currency = NULL, *first_cmdty = NULL;
gnc_commodity *first_currency = NULL, *first_cmdty = NULL,
*fallback_cmdty = NULL;
gboolean err_flag = FALSE, txn_cmdty_in_splits = FALSE;
gnc_commodity *txn_cmdty = xaccTransGetCurrency (template_txn);
GList* txn_splits = xaccTransGetSplitList (template_txn);
@ -1234,6 +1235,9 @@ get_transaction_currency(SxTxnCreationData *creation_data,
/* Don't consider the commodity of a transaction that has
* neither a credit nor a debit formula. */
if (!fallback_cmdty)
fallback_cmdty = xaccAccountGetCommodity (split_account);
if (split_is_marker(t_split))
continue;
@ -1256,9 +1260,11 @@ get_transaction_currency(SxTxnCreationData *creation_data,
if (first_currency &&
(!txn_cmdty_in_splits || !gnc_commodity_is_currency (txn_cmdty)))
return first_currency;
if (!txn_cmdty_in_splits)
if (!txn_cmdty_in_splits && first_cmdty)
return first_cmdty;
return txn_cmdty;
if (txn_cmdty)
return txn_cmdty;
return fallback_cmdty;
}
static gboolean