IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2024-11-26 02:40:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

[io-gncxml-v2.cpp] plug g_strdup leak

Browse Source
This commit is contained in:
Christopher Lam 2023-07-01 11:43:27 +08:00
parent c313c3dedf
commit 0d326fa100
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libgnucash/backend/xml/io-gncxml-v2.cpp
View File

@ -872,11 +872,11 @@ static gboolean
write_counts (FILE* out, ...)
{
va_list ap;
char* type;
const char* type;
gboolean success = TRUE;
va_start (ap, out);
type = g_strdup (va_arg (ap, char*));
type = va_arg (ap, char*);
while (success && type)
{
@ -885,6 +885,7 @@ write_counts (FILE* out, ...)
if (amount != 0)
{
#if GNUCASH_REALLY_BUILD_AN_XML_TREE_ON_OUTPUT
char *type_dup = g_strdup (type);
char* val;
xmlNodePtr node;
@ -896,10 +897,10 @@ write_counts (FILE* out, ...)
* This is invalid xml because the namespace isn't
* declared in the tag itself. This should be changed to
* 'type' at some point. */
xmlSetProp (node, BAD_CAST "cd:type", checked_char_cast (type));
xmlSetProp (node, BAD_CAST "cd:type", checked_char_cast (type_dup));
xmlNodeAddContent (node, checked_char_cast (val));
g_free (val);
g_free (type);
g_free (type_dup);
xmlElemDump (out, NULL, node);
xmlFreeNode (node);