IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

C++ - use more expressive std::accumulate algo rather than std::for_each

Browse Source 
It encapsulates the custom string concatenation bits into a
lambda called "add_bullet_item" and streamlines the logic
of when to add what to the summary.
This commit is contained in:
Geert Janssens 2022-12-30 19:20:43 +01:00
parent 4ae15e675c
commit 0ed0be4ef2
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
gnucash/gnome/assistant-stock-transaction.cpp
View File

@ -899,20 +899,24 @@ to ensure proper recording."), new_date_str, last_split_date_str);
// generate final summary message. Collates a header, the errors
// and warnings. Then allow completion if errors is empty.
auto header = errors.empty() ?
N_("No errors found. Click Apply to create transaction.") :
N_("The following errors must be fixed:");
auto summary = std::string { _(header) };
auto summary_add = [&summary](auto a) { summary += "\n• "; summary += a; };
std::for_each (errors.begin(), errors.end(), summary_add);
auto add_bullet_item = [](std::string& a, std::string& b)->std::string { return std::move(a) + "\n• " + b; };
auto summary = std::string{};
if (errors.empty())
std::for_each (infos.begin(), infos.end(), summary_add);
{
summary = _("No errors found. Click Apply to create transaction.");
summary = std::accumulate (infos.begin(), infos.end(), std::move (summary), add_bullet_item);
}
else
{
summary = _("The following errors must be fixed:");
summary = std::accumulate (errors.begin(), errors.end(), std::move (summary), add_bullet_item);
}
if (!warnings.empty())
{
auto warnings_header = N_ ("The following warnings exist:");
summary += "\n\n";
summary += _(warnings_header);
std::for_each (warnings.begin(), warnings.end(), summary_add);
summary += _("The following warnings exist:");
summary = std::accumulate (warnings.begin(), warnings.end(), std::move (summary), add_bullet_item);
}
gtk_label_set_text (GTK_LABEL (info->finish_summary), summary.c_str());
gtk_assistant_set_page_complete (GTK_ASSISTANT (info->window),