IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use more significant digits for SX function returns.

Browse Source 
gnc_sxed_check_consistent() was failing to balance mortgage payments with
large payments or small interest amounts because of rounding errors with
only 6 significant digits. Using 18 causes values < 1 to overflow, so I
compromised on 12.

Also log an error and return NULL if there's an overflow, since the value
won't be useful.
This commit is contained in:
John Ralls 2014-06-08 13:43:10 -07:00
parent 8c89c1357e
commit 0fc71ed4c7
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/app-utils/gnc-exp-parser.c
View File

@ -339,7 +339,15 @@ func_op(const char *fname, int argc, void **argv)
result = g_new0( gnc_numeric, 1 );
*result = double_to_gnc_numeric( scm_to_double(scmTmp),
GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS(6) | GNC_HOW_RND_ROUND_HALF_UP );
GNC_HOW_DENOM_SIGFIGS(12) | GNC_HOW_RND_ROUND_HALF_UP );
if (gnc_numeric_check (*result) != GNC_ERROR_OK)
{
PERR("Attempt to convert %f to GncNumeric Failed: %s",
scm_to_double(scmTmp),
gnc_numeric_errorCode_to_string (gnc_numeric_check (*result)));
g_free (result);
return NULL;
}
/* FIXME: cleanup scmArgs = scm_list, cons'ed cells? */
return (void*)result;
}