From 0ff9eba94f0d273ec11e4e19da42019bdc6cc802 Mon Sep 17 00:00:00 2001 From: Geert Janssens Date: Wed, 28 Jan 2015 17:00:21 +0100 Subject: [PATCH] Bug 727647 - "gncInvoiceGetTotal" is not read-only function? The root cause is in gncRecomputeValues. This function only alters runtime cached values so it should not trigger a book dirty action (mark_entry). --- src/engine/gncEntry.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/engine/gncEntry.c b/src/engine/gncEntry.c index f4c17863f5..72458290ed 100644 --- a/src/engine/gncEntry.c +++ b/src/engine/gncEntry.c @@ -1327,7 +1327,6 @@ gncEntryRecomputeValues (GncEntry *entry) /* Determine the commodity denominator */ denom = get_entry_commodity_denom (entry); - gncEntryBeginEdit (entry); /* Compute the invoice values */ gncEntryComputeValue (entry->quantity, entry->i_price, (entry->i_taxable ? entry->i_tax_table : NULL), @@ -1360,8 +1359,6 @@ gncEntryRecomputeValues (GncEntry *entry) entry->b_tax_value_rounded = gnc_numeric_convert (entry->b_tax_value, denom, GNC_HOW_RND_ROUND_HALF_UP); entry->values_dirty = FALSE; - mark_entry (entry); - gncEntryCommitEdit (entry); } /* The "Int" functions below are for internal use only.