IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 747795 - Attached file not found.

Browse Source 
MSWin only. ShellExecuteW("open") doesn't decode http escapes on file:
IRIs.
This commit is contained in:
John Ralls 2015-07-11 11:20:56 -07:00
parent 211b923cd7
commit 2137cb6d38
1 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/gnome-utils/gnc-gnome-utils.c
View File

@ -430,19 +430,31 @@ gnc_launch_assoc (const char *uri)
void void
gnc_launch_assoc (const char *uri) gnc_launch_assoc (const char *uri)
{ {
wchar_t *winuri = (wchar_t *)g_utf8_to_utf16(uri, -1, NULL, NULL, NULL); wchar_t *winuri = NULL;
wchar_t *wincmd = (wchar_t *)g_utf8_to_utf16("open", -1, NULL, NULL, NULL); /* ShellExecuteW open doesn't decode http escapes if it's passed a
* file URI so we have to do it. */
if (strcmp (g_uri_parse_scheme(uri), "file") == 0)
{
gchar *filename = g_filename_from_uri (uri, NULL, NULL);
winuri = (wchar_t *)g_utf8_to_utf16(filename, -1, NULL, NULL, NULL);
}
else
winuri = (wchar_t *)g_utf8_to_utf16(uri, -1, NULL, NULL, NULL);
if (winuri) if (winuri)
{ {
if ((INT_PTR)ShellExecuteW(NULL, wincmd, winuri, NULL, NULL, SW_SHOWNORMAL) <= 32) wchar_t *wincmd = (wchar_t *)g_utf8_to_utf16("open", -1,
{ NULL, NULL, NULL);
const gchar *message = if ((INT_PTR)ShellExecuteW(NULL, wincmd, winuri,
_("GnuCash could not find the associated file."); NULL, NULL, SW_SHOWNORMAL) <= 32)
gnc_error_dialog(NULL, "%s", message); {
} const gchar *message =
g_free (winuri); _("GnuCash could not find the associated file");
gnc_error_dialog(NULL, "%s: %s", message, uri);
}
g_free (wincmd);
g_free (winuri);
} }
g_free (wincmd);
} }
#else #else