IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add additional check before creating splits or transactions

Browse Source 
This allows the code following the check to make certain assumptions about the state
of the prop objects.
This commit is contained in:
Geert Janssens 2016-12-11 16:15:38 +01:00 committed by Geert Janssens
parent d2597ef1e2
commit 2492931094
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/import-export/csv-imp/gnc-trans-props.cpp
View File

@ -267,6 +267,16 @@ Transaction* GncPreTrans::create_trans (QofBook* book, gnc_commodity* currency)
if (created)
return nullptr;
/* Gently refuse to create the transaction if the basics are not set correctly
* This should have been tested before calling this function though!
*/
auto check = verify_essentials();
if (!check.empty())
{
PWARN ("Refusing to create transaction because essentials not set properly: %s", check.c_str());
return nullptr;
}
auto trans = xaccMallocTransaction (book);
xaccTransBeginEdit (trans);
xaccTransSetCurrency (trans, currency);
@ -402,6 +412,16 @@ boost::optional<gnc_numeric> GncPreSplit::create_split (Transaction* trans)
if (created)
return boost::none;
/* Gently refuse to create the split if the basics are not set correctly
* This should have been tested before calling this function though!
*/
auto check = verify_essentials();
if (!check.empty())
{
PWARN ("Refusing to create split because essentials not set properly: %s", check.c_str());
return boost::none;
}
Account *account = nullptr;
Account *taccount = nullptr;
bool amount_set = false;