From 27c0ab490a4fdb0b062ae7f9af688c3980f4cb06 Mon Sep 17 00:00:00 2001
From: Christopher Lam <christopher.lck@gmail.com>
Date: Fri, 22 Feb 2019 17:38:55 +0800
Subject: [PATCH] [register] change other-rows-driver to named-let

---
 gnucash/report/standard-reports/register.scm | 22 +++++++-------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/gnucash/report/standard-reports/register.scm b/gnucash/report/standard-reports/register.scm
index 9f778b3c30..eb037dfdde 100644
--- a/gnucash/report/standard-reports/register.scm
+++ b/gnucash/report/standard-reports/register.scm
@@ -562,20 +562,14 @@
 
   (define (add-other-split-rows split table used-columns row-style
                                 action-for-num? ledger-type? total-collector)
-    (define (other-rows-driver split parent table used-columns i)
-      (let ((current (xaccTransGetSplit parent i)))
-        (if (not (null? current))
-            (begin
-              (add-split-row table current used-columns row-style #f #t
-                             action-for-num? ledger-type? #f
-                             (opt-val "Display" "Memo")
-                             (opt-val "Display" "Description")
-                             total-collector)
-              (other-rows-driver split parent table
-                                 used-columns (+ i 1))))))
-
-    (other-rows-driver split (xaccSplitGetParent split)
-                       table used-columns 0))
+    (let loop ((splits (xaccTransGetSplitList (xaccSplitGetParent split))))
+      (when (pair? splits)
+        (add-split-row table (car splits) used-columns row-style #f #t
+                       action-for-num? ledger-type? #f
+                       (opt-val "Display" "Memo")
+                       (opt-val "Display" "Description")
+                       total-collector)
+        (loop (cdr splits)))))
 
   (define (splits-leader splits)
     (let ((accounts (map xaccSplitGetAccount splits)))