From 2f4438ab28aa3b0cb306027a316f1a97cf75da53 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Thu, 14 Oct 2021 17:21:13 -0700 Subject: [PATCH] Bug 798335 - No longer possible to change trading account Strip trading splits only if "Use Trading Accounts" is enabled for the book so that users who want to manage trading accounts by hand may do so. --- libgnucash/engine/Scrub.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libgnucash/engine/Scrub.c b/libgnucash/engine/Scrub.c index de14940e4c..79bb73fd98 100644 --- a/libgnucash/engine/Scrub.c +++ b/libgnucash/engine/Scrub.c @@ -789,11 +789,8 @@ xaccTransScrubImbalance (Transaction *trans, Account *root, ENTER ("()"); - /* Must look for orphan splits and remove trading splits even if - * there is no imbalance and we're not using trading accounts. - */ + /* Must look for orphan splits even if there is no imbalance. */ xaccTransScrubSplits (trans); - xaccTransClearTradingSplits (trans); /* Return immediately if things are balanced. */ if (xaccTransIsBalanced (trans)) @@ -805,10 +802,11 @@ xaccTransScrubImbalance (Transaction *trans, Account *root, if (! xaccTransUseTradingAccounts (trans)) { gnc_transaction_balance_no_trading (trans, root, account); - LEAVE ("transaction balanced, no trading accounts"); + LEAVE ("transaction balanced, no managed trading accounts"); return; } + xaccTransClearTradingSplits (trans); imbalance = xaccTransGetImbalanceValue (trans); if (! gnc_numeric_zero_p (imbalance)) {