From 30b47d16691df008440949d1d7c73db6154c1afb Mon Sep 17 00:00:00 2001 From: Richard Cohen Date: Fri, 7 Jul 2023 18:21:31 +0100 Subject: [PATCH] Valgrind: fix "definitely lost" memory from get_random_string() - test-job ==88779== 8 bytes in 1 blocks are definitely lost in loss record 9 of 461 ==88779== at 0x4848A13: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==88779== by 0x503C550: g_malloc0 (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1) ==88779== by 0x10B871: get_random_string_without (test-stuff.c:312) ==88779== by 0x10B8EE: get_random_string (test-stuff.c:333) ==88779== by 0x10AB9F: test_string_fcn (test-job.c:157) ==88779== by 0x10A7B1: test_job (test-job.c:87) ==88779== by 0x10AFF3: main (test-job.c:262) + 3 more --- libgnucash/engine/test/test-job.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libgnucash/engine/test/test-job.c b/libgnucash/engine/test/test-job.c index 2b5b4f8155..737f168017 100644 --- a/libgnucash/engine/test/test-job.c +++ b/libgnucash/engine/test/test-job.c @@ -113,13 +113,13 @@ test_job (void) } #endif { - const char *str = get_random_string(); - const char *res; + char *str = get_random_string(); gncJobSetName (job, str); - res = qof_object_printable (GNC_ID_JOB, job); + const char *res = qof_object_printable (GNC_ID_JOB, job); do_test (res != NULL, "Printable NULL?"); do_test (g_strcmp0 (str, res) == 0, "Printable equals"); + g_free (str); } { GList *list; @@ -154,7 +154,7 @@ test_string_fcn (QofBook *book, const char *message, const char * (*get)(const GncJob *)) { GncJob *job = gncJobCreate (book); - char const *str = get_random_string (); + char *str = get_random_string (); do_test (!qof_instance_is_dirty (QOF_INSTANCE(job)), "test if start dirty"); gncJobBeginEdit (job); @@ -169,6 +169,7 @@ test_string_fcn (QofBook *book, const char *message, */ // do_test (!qof_instance_is_dirty (QOF_INSTANCE(job)), "test dirty after commit"); do_test (g_strcmp0 (get (job), str) == 0, message); + g_free (str); gncJobSetActive (job, FALSE); count++; }