From 321a159af29a9b51fe793c2528dccb74b0443bf9 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Thu, 7 Aug 2014 10:00:39 -0700 Subject: [PATCH] Fix broken test-backend-dbi with libdbi 0.9. Segfaulted for an uninitialized dbi_instance. --- configure.ac | 2 +- src/backend/dbi/test/test-backend-dbi-basic.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index bb07382e1e..2f70fc5664 100644 --- a/configure.ac +++ b/configure.ac @@ -34,7 +34,7 @@ GNUCASH_NANO_VERSION=0 #src/backend/dbi/gnc-backend-dbi.c:gnc_dbi_load. GNUCASH_RESAVE_VERSION=19920 # Initialize automake -- make sure we have at least version 1.9 -AM_INIT_AUTOMAKE([1.9 dist-bzip2]) +AM_INIT_AUTOMAKE([1.9 dist-bzip2 subdir-objects]) # Parse out the version number GNUCASH_VERSION_STRING=AC_PACKAGE_VERSION diff --git a/src/backend/dbi/test/test-backend-dbi-basic.c b/src/backend/dbi/test/test-backend-dbi-basic.c index d7e88ebd80..b3203f0bbe 100644 --- a/src/backend/dbi/test/test-backend-dbi-basic.c +++ b/src/backend/dbi/test/test-backend-dbi-basic.c @@ -36,7 +36,7 @@ #if LIBDBI_VERSION >= 900 #define HAVE_LIBDBI_R 1 -static dbi_inst dbi_instance; +static dbi_inst dbi_instance = NULL; #else #define HAVE_LIBDBI_R 0 #endif @@ -597,8 +597,11 @@ test_suite_gnc_backend_dbi (void) dbi_driver driver = NULL; GList *drivers = NULL; #if HAVE_LIBDBI_R + if (dbi_instance == NULL) + dbi_initialize_r (NULL, &dbi_instance); while ((driver = dbi_driver_list_r (driver, dbi_instance))) #else + dbi_initialize (NULL); while ((driver = dbi_driver_list (driver))) #endif {