IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Catch potential boost::process exceptions

Browse Source 
Could happen if the perl executable isn't found and perhaps also
if there's a stream exception.
This commit is contained in:
Geert Janssens 2021-01-29 12:13:46 +01:00 committed by John Ralls
parent d79306f7db
commit 32df095d4f
1 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
libgnucash/quotes/gnc-quotes.cpp
View File

@ -50,20 +50,29 @@ GncQuotes::check (void)
bp::ipstream out_stream; bp::ipstream out_stream;
bp::ipstream err_stream; bp::ipstream err_stream;
bp::child process (perl_executable, "-w", fq_check, bp::std_out > out_stream, bp::std_err > err_stream);
std::string stream_line; try
while (process.running() && getline (out_stream, stream_line)) {
if (m_version.empty()) bp::child process (perl_executable, "-w", fq_check, bp::std_out > out_stream, bp::std_err > err_stream);
std::swap (m_version, stream_line);
else
m_sources.push_back (std::move(stream_line));
while (process.running() && getline (err_stream, stream_line)) std::string stream_line;
m_error_msg.append(stream_line + "\n"); while (process.running() && getline (out_stream, stream_line))
if (m_version.empty())
std::swap (m_version, stream_line);
else
m_sources.push_back (std::move(stream_line));
process.wait(); while (process.running() && getline (err_stream, stream_line))
m_cmd_result = process.exit_code(); m_error_msg.append(stream_line + "\n");
process.wait();
m_cmd_result = process.exit_code();
}
catch (std::exception &e)
{
m_cmd_result = -1;
m_error_msg = e.what();
};
auto success = (m_cmd_result == 0); auto success = (m_cmd_result == 0);