IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix inverted subtraction.

Browse Source
This commit is contained in:
John Ralls 2017-01-30 10:37:45 -08:00
parent a88d21245e
commit 340fb9761c
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libqof/qof/gnc-rational.cpp
View File

@ -103,7 +103,7 @@ operator+(GncRational a, GncRational b)
GncRational
operator-(GncRational a, GncRational b)
{
GncRational retval = -a + b;
GncRational retval = a + (-b);
return retval;
}

14
src/libqof/qof/test/gtest-gnc-rational.cpp
View File

@ -87,18 +87,18 @@ TEST(gncrational_operators, test_subtraction)
GncRational a(123456789987654321, 1000000000);
GncRational b(65432198765432198, 100000000);
GncRational c = a - b;
EXPECT_EQ (530865197666667659, c.m_num);
EXPECT_FALSE(c.m_num.isNeg());
EXPECT_EQ (1000000000, c.m_den);
EXPECT_EQ (GNC_ERROR_OK, c.m_error);
c = b - a;
EXPECT_EQ (-530865197666667659, c.m_num);
EXPECT_TRUE(c.m_num.isNeg());
EXPECT_EQ (1000000000, c.m_den);
EXPECT_EQ (GNC_ERROR_OK, c.m_error);
c = b - a;
EXPECT_EQ (530865197666667659, c.m_num);
EXPECT_FALSE(c.m_num.isNeg());
EXPECT_EQ (1000000000, c.m_den);
EXPECT_EQ (GNC_ERROR_OK, c.m_error);
a -= b;
EXPECT_EQ (530865197666667659, a.m_num);
EXPECT_FALSE(a.m_num.isNeg());
EXPECT_EQ (-530865197666667659, a.m_num);
EXPECT_TRUE(a.m_num.isNeg());
EXPECT_EQ (1000000000, a.m_den);
EXPECT_EQ (GNC_ERROR_OK, a.m_error);
}