From 38060b0258041cd4bc5c34b956e6b2de2f6dcdb1 Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Sat, 13 Jun 2020 22:51:15 +0800 Subject: [PATCH] [balsheet-pnl] value-collector doesn't need to ignore closing The value-collector is only used to tally account balances for asset&liability accounts. These accounts never have closing entries. No need to test closing property. --- gnucash/report/reports/standard/balsheet-pnl.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnucash/report/reports/standard/balsheet-pnl.scm b/gnucash/report/reports/standard/balsheet-pnl.scm index bb7d29c671..4ce6acaa6c 100644 --- a/gnucash/report/reports/standard/balsheet-pnl.scm +++ b/gnucash/report/reports/standard/balsheet-pnl.scm @@ -783,10 +783,8 @@ also show overall period profit & loss.")) (gnc:make-commodity-collector)) #:split->elt (lambda (s) - (unless (xaccTransGetIsClosingTxn (xaccSplitGetParent s)) - (val-coll 'add - (xaccTransGetCurrency (xaccSplitGetParent s)) - (xaccSplitGetValue s))) + (val-coll 'add (xaccTransGetCurrency (xaccSplitGetParent s)) + (xaccSplitGetValue s)) (make-datum s (amt->monetary (xaccSplitGetNoclosingBalance s)) (amt->monetary (xaccSplitGetBalance s))