IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Show transaction value, not amount, for registers with subaccounts.

Browse Source 
If the register has subaccounts in different currencies and a
transaction has splits in more than one, the transaction will
incorrectly appear to be unbalanced if we total amounts because
the balancing logic works on split values.
This commit is contained in:
John Ralls 2020-04-10 15:44:00 -07:00
parent aac3ea6909
commit 3b0c91bb57
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gnucash/register/ledger-core/split-register-model.c
View File

@ -1591,10 +1591,11 @@ gnc_split_register_get_mxfrm_help (VirtualLocation virt_loc,
return g_strdup (help);
}
/* Return the total amount of the transaction for splits of default account
* and all subaccounts of the register. */
/* Return the total value in the register currency of the transaction
* for splits of default account and all subaccounts of the register.
*/
static gnc_numeric
get_trans_total_amount_subaccounts (SplitRegister* reg, Transaction* trans)
get_trans_total_value_subaccounts (SplitRegister* reg, Transaction* trans)
{
GList* children, *child;
Account* parent;
@ -1607,12 +1608,13 @@ get_trans_total_amount_subaccounts (SplitRegister* reg, Transaction* trans)
has no account then we have no way of picking out the desired splits,
return zero. */
return total;
children = gnc_account_get_descendants (parent);
children = g_list_append (children, parent);
for (child = children; child; child = child->next)
{
total = gnc_numeric_add_fixed (total, xaccTransGetAccountAmount (trans,
total = gnc_numeric_add_fixed (total, xaccTransGetAccountValue (trans,
child->data));
}
@ -1642,7 +1644,7 @@ gnc_split_register_get_tdebcred_entry (VirtualLocation virt_loc,
{
case GENERAL_JOURNAL:
case INCOME_LEDGER:
total = get_trans_total_amount_subaccounts (reg, xaccSplitGetParent (split));
total = get_trans_total_value_subaccounts (reg, xaccSplitGetParent (split));
break;
default:
total = get_trans_total_amount (reg, xaccSplitGetParent (split));