IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[html-utilities] tighten code

Browse Source 
using list-ref and length repeatedly is usually less efficient than
testing against null?
This commit is contained in:
Christopher Lam 2019-06-18 22:54:12 +08:00
parent a33302f1e6
commit 3b187a1282
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gnucash/report/report-system/html-utilities.scm
View File

@ -122,13 +122,11 @@
"#F012BE" "#3D9970" "#39CCCC" "#f39c12"
"#e74c3c" "#e67e22" "#9b59b6" "#8e44ad"
"#16a085" "#d35400"))
(define (assign-colors i)
(if (<= num-colors i)
'()
(cons (list-ref base-colors
(modulo i (length base-colors)))
(assign-colors (+ i 1)))))
(assign-colors 0))
(let lp ((i 0) (result '()) (colors base-colors))
(cond
((>= num-colors i) (reverse result))
((null? colors) (lp (1+ i) (cons (car colors) result) base-colors))
(else (lp (1+ i) (cons (car colors) result) (cdr colors))))))
;; Appends a horizontal ruler to a html-table with the specified
;; colspan at, optionally, the specified column.
@ -183,9 +181,6 @@
table tree-depth
current-depth my-name my-balance
reverse-balance? row-style boldface? group-header-line?)
;; just a stupid little helper
(define (identity a)
a)
(gnc:html-table-append-row/markup!
table
row-style