IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug #506251: Fix test-date failure on systems with a timezone east of UTC

Browse Source 
This patch removes all the calls to check_conversion which test zero
seconds (the epoch) and it changes the check_time function to skip
any timestamps that are before noon on January 1, 1970, UTC.

Patch by Daniel Harding.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17721 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Christian Stimming 2008-11-26 13:39:54 +00:00
parent 31b25c1d6e
commit 3eafd15ed2
1 changed files with 11 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/engine/test/test-date.c
View File

@ -24,6 +24,17 @@ check_time (Timespec ts, gboolean always_print)
ts.tv_nsec /= 1000;
ts.tv_nsec *= 1000;
/* We just can't handle dates whose time_t doesn't fit in int - skip those
* cases. */
if (ts.tv_sec > (0x7fffffff - 3600*25))
return TRUE;
/* If we are east of UTC, we also can't handle dates whose tv_sec member
* falls in the range [0, -gnc_timezone(tm)) - make sure were are at least 12
* hours past the epoch to skip those cases too */
if (ts.tv_sec < 3600*12)
return TRUE;
gnc_timespec_to_iso8601_buff (ts, str);
/* The time, in seconds, everywhere on the planet, is always
@ -85,49 +96,6 @@ run_test (void)
int i;
gboolean do_print = FALSE;
/* All of the following strings are equivalent
* representations of zero seconds. Note, zero seconds
* is the same world-wide, independent of timezone.
*/
ts.tv_sec = 0;
ts.tv_nsec = 0;
check_conversion ("1969-12-31 15:00:00.000000 -0900", ts);
check_conversion ("1969-12-31 16:00:00.000000 -0800", ts);
check_conversion ("1969-12-31 17:00:00.000000 -0700", ts);
check_conversion ("1969-12-31 18:00:00.000000 -0600", ts);
check_conversion ("1969-12-31 19:00:00.000000 -0500", ts);
check_conversion ("1969-12-31 20:00:00.000000 -0400", ts);
check_conversion ("1969-12-31 21:00:00.000000 -0300", ts);
check_conversion ("1969-12-31 22:00:00.000000 -0200", ts);
check_conversion ("1969-12-31 23:00:00.000000 -0100", ts);
check_conversion ("1970-01-01 00:00:00.000000 -0000", ts);
check_conversion ("1970-01-01 00:00:00.000000 +0000", ts);
check_conversion ("1970-01-01 01:00:00.000000 +0100", ts);
check_conversion ("1970-01-01 02:00:00.000000 +0200", ts);
check_conversion ("1970-01-01 03:00:00.000000 +0300", ts);
check_conversion ("1970-01-01 04:00:00.000000 +0400", ts);
check_conversion ("1970-01-01 05:00:00.000000 +0500", ts);
check_conversion ("1970-01-01 06:00:00.000000 +0600", ts);
check_conversion ("1970-01-01 07:00:00.000000 +0700", ts);
check_conversion ("1970-01-01 08:00:00.000000 +0800", ts);
/* check minute-offsets as well */
check_conversion ("1970-01-01 08:01:00.000000 +0801", ts);
check_conversion ("1970-01-01 08:02:00.000000 +0802", ts);
check_conversion ("1970-01-01 08:03:00.000000 +0803", ts);
check_conversion ("1970-01-01 08:23:00.000000 +0823", ts);
check_conversion ("1970-01-01 08:35:00.000000 +0835", ts);
check_conversion ("1970-01-01 08:47:00.000000 +0847", ts);
check_conversion ("1970-01-01 08:59:00.000000 +0859", ts);
check_conversion ("1969-12-31 15:01:00.000000 -0859", ts);
check_conversion ("1969-12-31 15:02:00.000000 -0858", ts);
check_conversion ("1969-12-31 15:03:00.000000 -0857", ts);
check_conversion ("1969-12-31 15:23:00.000000 -0837", ts);
check_conversion ("1969-12-31 15:45:00.000000 -0815", ts);
/* Now leaving the 60's:
*
* Black Panthers
@ -400,14 +368,6 @@ run_test (void)
{
ts = *get_random_timespec ();
ts.tv_nsec = MIN (ts.tv_nsec, 999999999);
ts.tv_nsec /= 1000;
ts.tv_nsec *= 1000;
/* We just can't handle dates whose time_t doesn't fit in int. */
if (ts.tv_sec > (0x7fffffff - 3600*25))
continue;
if (!check_time (ts, FALSE))
return;
}