IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Divide the value by the rate to get the amount.

Browse Source 
Avoids overflowing the amount and is anyway much more realistic:
Value = Amount * price, so a large "rate" means a small price. Since
get_random_rate() is biased to producing large rates (denom is fixed
at 100), it was effectively testing infinitesimal prices.
This commit is contained in:
John Ralls 2014-08-01 16:21:01 -07:00
parent bad092a46d
commit 3f8718ea3b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/engine/test-core/test-engine-stuff.c
View File

@ -475,6 +475,9 @@ get_random_gnc_numeric(void)
return gnc_numeric_create(numer, deno);
}
/* Rate here really means price or exchange rate, this is used solely
* to compute an amount from a randomly-created value. */
static gnc_numeric
get_random_rate (void)
{
@ -1322,11 +1325,8 @@ get_random_split(QofBook *book, Account *acct, Transaction *trn)
xaccSplitGetAccount(ret)));
do
{
/* Large rates blow up xaccSplitAssignLot */
rate = get_random_rate ();
amt = gnc_numeric_mul(val, rate,
GNC_DENOM_AUTO, GNC_HOW_DENOM_REDUCE);
amt = gnc_numeric_convert(amt, denom, GNC_HOW_RND_ROUND_HALF_UP);
amt = gnc_numeric_div(val, rate, denom, GNC_HOW_RND_ROUND_HALF_UP);
}
while (gnc_numeric_check(amt) != GNC_ERROR_OK);
}