IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2024-12-01 04:59:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Windows: check permissions actually used on the platform

Browse Source 
The code assumed these would be the same as on all other platforms which turns out not to be the case
This commit is contained in:
Geert Janssens 2017-09-04 23:35:41 +02:00
parent d96bb3ebd5
commit 449d3ca32d
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libgnucash/core-utils/gnc-filepath-utils.cpp
View File

@ -335,7 +335,12 @@ gnc_validate_directory (const bfs::path &dirname, bool create)
/* On Windows only write permission will be checked.
* So strictly speaking we'd need two error messages here depending
* on the platform. For simplicity this detail is glossed over though. */
if ((perms & bfs::owner_all) != bfs::owner_all)
#if PLATFORM(WINDOWS)
auto check_perms = bfs::owner_read | bfs::owner_write;
#else
auto check_perms = bfs::owner_all;
#endif
if ((perms & check_perms) != check_perms)
throw (bfs::filesystem_error(
std::string(_("Insufficient permissions, at least write and access permissions required: "))
+ dirname.string(), dirname,