Move source files for GncQuotes to app-utils

It will depend on functions in that library. This can probably be
fixed by cleaning up app-utils, but that's not the topic of
this feature.

gnucash/CMakeLists.txt

@@ -63,7 +63,7 @@ target_compile_definitions(gnucash PRIVATE -DG_LOG_DOMAIN=\"gnc.bin\")
 
 target_link_libraries (gnucash
    gnc-ledger-core gnc-gnome gnc-gnome-utils gnc-app-utils
-   gnc-engine gnc-module gnc-core-utils gnc-quotes gnucash-guile
+   gnc-engine gnc-module gnc-core-utils gnucash-guile
    gnc-qif-import gnc-csv-import gnc-csv-export gnc-log-replay
    gnc-bi-import gnc-customer-import gnc-report
    PkgConfig::GTK3 ${GUILE_LDFLAGS} ${GLIB2_LDFLAGS}
@@ -98,7 +98,7 @@ target_compile_definitions(gnucash-cli PRIVATE -DG_LOG_DOMAIN=\"gnc.bin\")
 
 target_link_libraries (gnucash-cli
    gnc-gnome-utils gnc-app-utils
-   gnc-engine gnc-core-utils gnc-quotes gnucash-guile gnc-report
+   gnc-engine gnc-core-utils gnucash-guile gnc-report
    ${GUILE_LDFLAGS} ${GLIB2_LDFLAGS}
    ${Boost_LIBRARIES}
 )

gnucash/gnucash-commands.cpp

@@ -88,7 +88,7 @@ scm_add_quotes(void *data, [[maybe_unused]] int argc, [[maybe_unused]] char **ar
         std::cout << bl::format (bl::translate ("Found Finance::Quote version {1}.")) % quotes.version() << std::endl;
         auto quote_sources = quotes.sources_as_glist();
         gnc_quote_source_set_fq_installed (quotes.version().c_str(), quote_sources);
-        g_list_free_full (quote_sources);
+        g_list_free_full (quote_sources, g_free);
     }
     else
     {

libgnucash/app-utils/CMakeLists.txt

@@ -17,6 +17,7 @@ set (app_utils_HEADERS
   gnc-gsettings.h
   gnc-help-utils.h
   gnc-prefs-utils.h
+  gnc-quotes.hpp
   gnc-state.h
   gnc-ui-util.h
   gnc-ui-balances.h
@@ -31,6 +32,7 @@ set (app_utils_SOURCES
   gnc-euro.c
   gnc-gsettings.cpp
   gnc-prefs-utils.c
+  gnc-quotes.cpp
   gnc-state.c
   gnc-ui-util.c
   gnc-ui-balances.c
@@ -46,7 +48,7 @@ endif()
 set(app_utils_ALL_SOURCES ${app_utils_SOURCES} ${app_utils_HEADERS})
 set(app_utils_ALL_LIBRARIES
     gnc-engine
-    ${GLIB_LDFLAGS}
+    ${Boost_FILESYSTEM_LIBRARY}
     ${GIO_LDFLAGS}
     ${LIBXML2_LDFLAGS}
     ${LIBXSLT_LDFLAGS}

libgnucash/quotes/CMakeLists.txt

@@ -1,54 +1,3 @@
-### libgnc-quotes
-set (quotes_SOURCES
-    gnc-quotes.cpp
-)
-
-# Add dependency on config.h
-set_source_files_properties (${quotes_SOURCES} PROPERTIES OBJECT_DEPENDS ${CONFIG_H})
-
-set(quotes_noinst_HEADERS
-    gnc-quotes.hpp
-)
-
-add_library(gnc-quotes ${quotes_SOURCES} ${quotes_noinst_HEADERS})
-
-add_dependencies(gnc-quotes gnc-vcs-info)
-
-target_include_directories(gnc-quotes
-    PUBLIC
-        ${CMAKE_CURRENT_BINARY_DIR}
-        ${CMAKE_CURRENT_SOURCE_DIR}
-        ${GLIB2_INCLUDE_DIRS}
-    PRIVATE
-        ${GTK_MAC_INCLUDE_DIRS}
-)
-
-target_link_libraries(gnc-quotes
-    PRIVATE
-        gnc-core-utils
-        ${Boost_LIBRARIES}
-        ${GLIB2_LDFLAGS}
-        ${GOBJECT_LDFLAGS}
-        ${GTK_MAC_LDFLAGS}
-        "$<$<BOOL:${MAC_INTEGRATION}>:${OSX_EXTRA_LIBRARIES}>"
-)
-
-target_compile_definitions(gnc-quotes
-    PRIVATE
-        G_LOG_DOMAIN=\"gnc.quotes\"
-        ${GTK_MAC_CFLAGS_OTHER}
-)
-
-target_compile_options(gnc-quotes
-    PRIVATE
-        $<$<BOOL:${MAC_INTEGRATION}>:${OSX_EXTRA_COMPILE_FLAGS}>
-)
-
-install(TARGETS gnc-quotes
-    LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
-    ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
-    RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
-)
 
 set(_BIN_FILES "")
 foreach(file gnc-fq-check.in gnc-fq-helper.in gnc-fq-update.in gnc-fq-dump.in)

po/POTFILES.in

@@ -516,6 +516,7 @@ libgnucash/app-utils/gnc-exp-parser.c
 libgnucash/app-utils/gnc-gsettings.cpp
 libgnucash/app-utils/gnc-help-utils.c
 libgnucash/app-utils/gnc-prefs-utils.c
+libgnucash/app-utils/gnc-quotes.cpp
 libgnucash/app-utils/gnc-state.c
 libgnucash/app-utils/gnc-sx-instance-model.c
 libgnucash/app-utils/gnc-ui-balances.c
@@ -672,7 +673,6 @@ libgnucash/engine/Transaction.c
 libgnucash/engine/TransLog.c
 libgnucash/gnc-module/example/gncmod-example.c
 libgnucash/gnc-module/gnc-module.c
-libgnucash/quotes/gnc-quotes.cpp
 libgnucash/tax/de_DE/tax.scm
 libgnucash/tax/de_DE/txf-help.scm
 libgnucash/tax/de_DE/txf.scm