IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

GList* from gtk_container_get_children must be freed

Browse Source 
fix leaks
This commit is contained in:
Christopher Lam
2021-08-19 22:28:02 +08:00
parent c442192bb4
commit 4cf25cb7be
4 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
borrowed/goffice/go-optionmenu.c
View File

@@ -180,6 +180,8 @@ static void handle_menu_signals(GOOptionMenu *option_menu, gboolean connect)
} }
} }
g_list_free (children);
} }
void go_option_menu_set_menu(GOOptionMenu *option_menu, GtkWidget *menu) void go_option_menu_set_menu(GOOptionMenu *option_menu, GtkWidget *menu)
@@ -233,8 +235,9 @@ void go_option_menu_set_history(GOOptionMenu *option_menu, GSList *selection)
while (1) while (1)
{ {
int n = GPOINTER_TO_INT(selection->data); int n = GPOINTER_TO_INT(selection->data);
GtkMenuItem *item = g_list_nth_data( GList *children = gtk_container_get_children (GTK_CONTAINER(menu));
gtk_container_get_children(GTK_CONTAINER(menu)), n); GtkMenuItem *item = g_list_nth_data (children, n);
g_list_free (children);
selection = selection->next; selection = selection->next;
if (selection) if (selection)
menu = GTK_MENU_SHELL(gtk_menu_item_get_submenu(item)); menu = GTK_MENU_SHELL(gtk_menu_item_get_submenu(item));

8
gnucash/gnome-search/dialog-search.c
View File

@@ -888,13 +888,12 @@ gnc_search_dialog_book_option_changed (gpointer new_val, gpointer user_data)
for (l = sw->crit_list; l; l = l->next) for (l = sw->crit_list; l; l = l->next)
{ {
struct _crit_data *data = l->data; struct _crit_data *data = l->data;
GList *children; GList *children = gtk_container_get_children (GTK_CONTAINER(data->container));
/* For each, walk the list of container children to get combo_box */ /* For each, walk the list of container children to get combo_box */
for (children = gtk_container_get_children(GTK_CONTAINER(data->container)); for (GList *child = children; child; child = g_list_next (child))
children; children = children->next)
{ {
GtkWidget *combo_box = children->data; GtkWidget *combo_box = child->data;
/* Get current active item if combo_box */ /* Get current active item if combo_box */
if (GTK_IS_COMBO_BOX(combo_box)) if (GTK_IS_COMBO_BOX(combo_box))
@@ -918,6 +917,7 @@ gnc_search_dialog_book_option_changed (gpointer new_val, gpointer user_data)
gtk_widget_show_all (data->container); gtk_widget_show_all (data->container);
} }
} }
g_list_free (children);
} }
gtk_widget_grab_focus(focused_widget); gtk_widget_grab_focus(focused_widget);
} }

7
gnucash/gnome-utils/dialog-options.c
View File

@@ -3537,12 +3537,9 @@ gnc_option_set_ui_value_radiobutton (GNCOption *option, gboolean use_default,
g_list_free(list); g_list_free(list);
list = gtk_container_get_children (GTK_CONTAINER(box)); list = gtk_container_get_children (GTK_CONTAINER(box));
for (i = 0; i < index && list; i++) button = g_list_nth_data (list, index);
list = list->next;
g_return_val_if_fail (list, TRUE);
button = list->data;
g_list_free (list); g_list_free (list);
g_return_val_if_fail (button, TRUE);
val = g_object_get_data (G_OBJECT(button), "gnc_radiobutton_index"); val = g_object_get_data (G_OBJECT(button), "gnc_radiobutton_index");
g_return_val_if_fail (GPOINTER_TO_INT(val) == index, TRUE); g_return_val_if_fail (GPOINTER_TO_INT(val) == index, TRUE);

7
gnucash/gnome-utils/gnc-main-window.c
View File

@@ -2493,14 +2493,15 @@ main_window_update_page_set_read_only_icon (GncPluginPage *page,
if (GTK_IS_EVENT_BOX(tab_widget)) if (GTK_IS_EVENT_BOX(tab_widget))
tab_widget = gtk_bin_get_child (GTK_BIN(tab_widget)); tab_widget = gtk_bin_get_child (GTK_BIN(tab_widget));
children = gtk_container_get_children (GTK_CONTAINER(tab_widget));
/* For each, walk the list of container children to get image widget */ /* For each, walk the list of container children to get image widget */
for (children = gtk_container_get_children (GTK_CONTAINER(tab_widget)); for (GList *child = children; child; child = g_list_next (child))
children; children = children->next)
{ {
GtkWidget *widget = children->data; GtkWidget *widget = child->data;
if (GTK_IS_IMAGE(widget)) if (GTK_IS_IMAGE(widget))
image = widget; image = widget;
} }
g_list_free (children);
if (!image) if (!image)
{ {